feat: another balance and bug fix pass (#238)

Working through open issues — fixes, balance changes, and features.

## Closed

- Closes #161
- Closes #181
- Closes #191
- Closes #199
- Closes #201
- Closes #202
- Closes #203
- Closes #204
- Closes #205
- Closes #206
- Closes #208
- Closes #211
- Closes #212
- Closes #213
- Closes #214
- Closes #216
- Closes #219
- Closes #220
- Closes #221
- Closes #222
- Closes #224
- Closes #225
- Closes #226
- Closes #228
- Closes #229
- Closes #230
- Closes #231
- Closes #232
- Closes #233
- Closes #234
- Closes #235
- Closes #236

✨ This PR was created with help from Hikari~ 🌸

Reviewed-on: #238
Co-authored-by: Hikari <hikari@nhcarrigan.com>
Co-committed-by: Hikari <hikari@nhcarrigan.com>

apps/api/test/routes/boss.spec.ts

@@ -294,6 +294,52 @@ describe("boss route", () => {
     expect(body.won).toBe(true);
   });
 
+  it("handles zone unlock gracefully when exploration state is undefined", async () => {
+    const state = makeState({
+      bosses: [makeBoss({ currentHp: 100, maxHp: 100, damagePerSecond: 1 })] as GameState["bosses"],
+      adventurers: [makeAdventurer()] as GameState["adventurers"],
+      zones: [{ id: "test_zone", status: "locked", unlockBossId: "test_boss", unlockQuestId: null }] as GameState["zones"],
+      quests: [],
+      exploration: undefined,
+    });
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state } as never);
+    vi.mocked(prisma.gameState.update).mockResolvedValueOnce({} as never);
+    const res = await challenge({ bossId: "test_boss" });
+    expect(res.status).toBe(200);
+    const body = await res.json() as { won: boolean };
+    expect(body.won).toBe(true);
+  });
+
+  it("unlocks exploration areas when a zone is unlocked on boss defeat", async () => {
+    const state = makeState({
+      bosses: [makeBoss({ currentHp: 100, maxHp: 100, damagePerSecond: 1 })] as GameState["bosses"],
+      adventurers: [makeAdventurer()] as GameState["adventurers"],
+      zones: [{ id: "test_zone", status: "locked", unlockBossId: "test_boss", unlockQuestId: null }] as GameState["zones"],
+      quests: [],
+      exploration: {
+        areas: [{ id: "test_area", status: "locked" as const }],
+        materials: [],
+        craftedRecipeIds: [],
+        craftedGoldMultiplier: 1,
+        craftedEssenceMultiplier: 1,
+        craftedClickMultiplier: 1,
+        craftedCombatMultiplier: 1,
+      },
+    });
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state } as never);
+    let savedState: GameState | undefined;
+    vi.mocked(prisma.gameState.update).mockImplementationOnce(async (args) => {
+      /* eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- Test assertion */
+      savedState = (args as { data: { state: GameState } }).data.state;
+      return {} as never;
+    });
+    const res = await challenge({ bossId: "test_boss" });
+    expect(res.status).toBe(200);
+    // Exploration area should remain locked — no matching defaultExploration for "test_area"
+    const area = savedState?.exploration?.areas.find((a) => a.id === "test_area");
+    expect(area?.status).toBe("locked");
+  });
+
   it("returns 500 when the database throws", async () => {
     vi.mocked(prisma.gameState.findUnique).mockRejectedValueOnce(new Error("DB error"));
     const res = await challenge({ bossId: "test_boss" });

apps/api/test/routes/explore.spec.ts

@@ -246,6 +246,22 @@ describe("explore route", () => {
       expect(body.endsAt).toBeGreaterThan(Date.now());
     });
 
+    it("persists endsAt to the DB state on exploration start", async () => {
+      const state = makeState();
+      vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state } as never);
+      vi.mocked(prisma.gameState.update).mockResolvedValueOnce({} as never);
+      const res = await postStart({ areaId: TEST_AREA_ID });
+      expect(res.status).toBe(200);
+      const body = await res.json() as { areaId: string; endsAt: number };
+      const updateCall = vi.mocked(prisma.gameState.update).mock.calls[0]?.[0];
+      /* eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- Test accesses nested mock data */
+      const savedState = (updateCall?.data as { state?: { exploration?: { areas?: Array<{ id: string; endsAt?: number }> } } }).state;
+      const savedArea = savedState?.exploration?.areas?.find((a) => {
+        return a.id === TEST_AREA_ID;
+      });
+      expect(savedArea?.endsAt).toBe(body.endsAt);
+    });
+
     it("backfills exploration state for old saves without exploration", async () => {
       const state = makeState({ exploration: undefined });
       vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state } as never);

apps/api/test/routes/game.spec.ts

@@ -477,6 +477,28 @@ describe("game route", () => {
       expect(body.savedAt).toBeGreaterThan(0);
     });
 
+    it("restores previous upgrades when incoming prestige count is lower (stale post-prestige save)", async () => {
+      const prevUpgrades = [
+        { id: "click_1", purchased: false, unlocked: true, target: "click", multiplier: 2 },
+      ] as GameState["upgrades"];
+      const prevState = makeState({
+        prestige: { count: 1, runestones: 10, productionMultiplier: 1.3, purchasedUpgradeIds: [] },
+        upgrades: prevUpgrades,
+      });
+      const incomingState = makeState({
+        prestige: { count: 0, runestones: 0, productionMultiplier: 1, purchasedUpgradeIds: [] },
+        upgrades: [
+          { id: "click_1", purchased: true, unlocked: true, target: "click", multiplier: 2 },
+        ] as GameState["upgrades"],
+      });
+      vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state: prevState } as never);
+      vi.mocked(prisma.player.findUnique).mockResolvedValueOnce(makePlayer({ createdAt: Date.now() }) as never);
+      vi.mocked(prisma.player.update).mockResolvedValueOnce({} as never);
+      vi.mocked(prisma.gameState.upsert).mockResolvedValueOnce({} as never);
+      const res = await save({ state: incomingState });
+      expect(res.status).toBe(200);
+    });
+
     it("validates companion when active companion is legitimately unlocked", async () => {
       const prevState = makeState();
       const stateWithCompanion = makeState({

apps/api/test/routes/prestige.spec.ts

@@ -81,6 +81,16 @@ describe("prestige route", () => {
       expect(res.status).toBe(400);
     });
 
+    it("returns 400 with echoPrestigeThresholdMultiplier applied when transcendence is present", async () => {
+      const state = makeState({
+        player: { discordId: DISCORD_ID, username: "u", discriminator: "0", avatar: null, totalGoldEarned: 500_000, totalClicks: 0, characterName: "T" },
+        transcendence: { count: 1, echoes: 0, purchasedUpgradeIds: [], echoIncomeMultiplier: 1, echoCombatMultiplier: 1, echoPrestigeThresholdMultiplier: 2, echoPrestigeRunestoneMultiplier: 1, echoMetaMultiplier: 1 },
+      });
+      vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state } as never);
+      const res = await post("");
+      expect(res.status).toBe(400);
+    });
+
     it("returns runestones on successful prestige", async () => {
       const state = makeState();
       vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state, updatedAt: 0 } as never);

apps/api/test/routes/timers.spec.ts

@@ -0,0 +1,189 @@
+/* eslint-disable max-lines-per-function -- Test suites naturally have many cases */
+/* eslint-disable @typescript-eslint/consistent-type-assertions -- Tests build minimal state objects */
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { Hono } from "hono";
+
+vi.mock("../../src/db/client.js", () => ({
+  prisma: {
+    gameState: { findUnique: vi.fn() },
+  },
+}));
+
+vi.mock("../../src/services/logger.js", () => ({
+  logger: {
+    error: vi.fn().mockResolvedValue(undefined),
+    log:   vi.fn().mockResolvedValue(undefined),
+  },
+}));
+
+const makeState = (overrides: Record<string, unknown> = {}) => ({
+  quests:      [],
+  exploration: { areas: [] },
+  ...overrides,
+});
+
+describe("timers route", () => {
+  let app: Hono;
+  let prisma: { gameState: { findUnique: ReturnType<typeof vi.fn> } };
+
+  beforeEach(async () => {
+    vi.clearAllMocks();
+    const { timersRouter } = await import("../../src/routes/timers.js");
+    const { prisma: p } = await import("../../src/db/client.js");
+    prisma = p as typeof prisma;
+    app = new Hono();
+    app.route("/timers", timersRouter);
+  });
+
+  const get = (userId: string) =>
+    app.fetch(new Request(`http://localhost/timers/${userId}`));
+
+  it("returns 400 for a non-numeric user ID", async () => {
+    const res = await get("not-a-number");
+    expect(res.status).toBe(400);
+    const body = await res.json() as { error: string };
+    expect(body.error).toBe("Invalid user ID");
+  });
+
+  it("returns 404 when player is not found", async () => {
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce(null);
+    const res = await get("123456789");
+    expect(res.status).toBe(404);
+    const body = await res.json() as { error: string };
+    expect(body.error).toBe("Player not found");
+  });
+
+  it("returns empty arrays when no active quests or explorations", async () => {
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({
+      state: makeState(),
+    });
+    const res = await get("123456789");
+    expect(res.status).toBe(200);
+    const body = await res.json() as { quests: unknown[]; explorations: unknown[] };
+    expect(body.quests).toEqual([]);
+    expect(body.explorations).toEqual([]);
+  });
+
+  it("returns active quest timers with endsAt computed from startedAt + duration", async () => {
+    const startedAt = Date.now() - 30_000;
+    const state = makeState({
+      quests: [
+        {
+          id:              "q1",
+          name:            "Forest Patrol",
+          status:          "active",
+          startedAt:       startedAt,
+          durationSeconds: 600,
+        },
+      ],
+    });
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state });
+    const res = await get("123456789");
+    expect(res.status).toBe(200);
+    const body = await res.json() as {
+      quests: Array<{ questId: string; name: string; endsAt: number; timeLeft: number }>;
+    };
+    expect(body.quests).toHaveLength(1);
+    expect(body.quests[0]?.questId).toBe("q1");
+    expect(body.quests[0]?.name).toBe("Forest Patrol");
+    expect(body.quests[0]?.endsAt).toBe(startedAt + 600_000);
+    expect(body.quests[0]?.timeLeft).toBeGreaterThan(0);
+  });
+
+  it("filters out quests that are not in_progress", async () => {
+    const state = makeState({
+      quests: [
+        { id: "q1", name: "Done Quest", status: "completed", startedAt: 0, durationSeconds: 60 },
+        { id: "q2", name: "Idle Quest", status: "available", durationSeconds: 60 },
+      ],
+    });
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state });
+    const res = await get("123456789");
+    const body = await res.json() as { quests: unknown[] };
+    expect(body.quests).toHaveLength(0);
+  });
+
+  it("returns timeLeft of 0 for already-completed quests still marked in_progress", async () => {
+    const startedAt = Date.now() - 700_000;
+    const state = makeState({
+      quests: [
+        {
+          id:              "q1",
+          name:            "Old Quest",
+          status:          "active",
+          startedAt:       startedAt,
+          durationSeconds: 600,
+        },
+      ],
+    });
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state });
+    const res = await get("123456789");
+    const body = await res.json() as {
+      quests: Array<{ timeLeft: number }>;
+    };
+    expect(body.quests[0]?.timeLeft).toBe(0);
+  });
+
+  it("returns active exploration timers", async () => {
+    const endsAt = Date.now() + 120_000;
+    const state = makeState({
+      exploration: {
+        areas: [
+          { id: "verdant_meadows", status: "in_progress", endsAt },
+          { id: "unknown_area_xyz", status: "in_progress", endsAt },
+        ],
+      },
+    });
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state });
+    const res = await get("123456789");
+    const body = await res.json() as {
+      explorations: Array<{ areaId: string; name: string; endsAt: number; timeLeft: number }>;
+    };
+    expect(body.explorations).toHaveLength(2);
+    expect(body.explorations[0]?.areaId).toBe("verdant_meadows");
+    expect(body.explorations[0]?.endsAt).toBe(endsAt);
+    expect(body.explorations[0]?.timeLeft).toBeGreaterThan(0);
+    // Unknown area falls back to ID as name
+    expect(body.explorations[1]?.name).toBe("unknown_area_xyz");
+  });
+
+  it("filters out explorations not in_progress", async () => {
+    const state = makeState({
+      exploration: {
+        areas: [
+          { id: "area1", status: "available" },
+          { id: "area2", status: "completed" },
+        ],
+      },
+    });
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state });
+    const res = await get("123456789");
+    const body = await res.json() as { explorations: unknown[] };
+    expect(body.explorations).toHaveLength(0);
+  });
+
+  it("handles missing exploration state gracefully", async () => {
+    const state = { quests: [] };
+    vi.mocked(prisma.gameState.findUnique).mockResolvedValueOnce({ state });
+    const res = await get("123456789");
+    expect(res.status).toBe(200);
+    const body = await res.json() as { explorations: unknown[] };
+    expect(body.explorations).toHaveLength(0);
+  });
+
+  it("returns 500 on database error", async () => {
+    vi.mocked(prisma.gameState.findUnique).mockRejectedValueOnce(
+      new Error("DB failure"),
+    );
+    const res = await get("123456789");
+    expect(res.status).toBe(500);
+    const body = await res.json() as { error: string };
+    expect(body.error).toBe("Internal server error");
+  });
+
+  it("returns 500 and logs non-Error throws", async () => {
+    vi.mocked(prisma.gameState.findUnique).mockRejectedValueOnce("string error");
+    const res = await get("123456789");
+    expect(res.status).toBe(500);
+  });
+});

apps/api/test/services/prestige.spec.ts

@@ -55,18 +55,18 @@ const makeMinimalState = (overrides: Partial<GameState> = {}): GameState =>
 
 describe("calculatePrestigeThreshold", () => {
   it("returns base threshold at count 0", () => {
-    // base × (0+1)^2 = 1_000_000 × 1 = 1_000_000
+    // base × (0+1)^2.5 = 1_000_000 × 1 = 1_000_000
     expect(calculatePrestigeThreshold(0)).toBe(1_000_000);
   });
 
-  it("returns 4× base at count 1", () => {
-    // base × (1+1)^2 = 1_000_000 × 4 = 4_000_000
-    expect(calculatePrestigeThreshold(1)).toBe(4_000_000);
+  it("returns base × 2^2.5 at count 1", () => {
+    // base × (1+1)^2.5 = 1_000_000 × 2^2.5
+    expect(calculatePrestigeThreshold(1)).toBeCloseTo(1_000_000 * Math.pow(2, 2.5));
   });
 
-  it("returns 9× base at count 2", () => {
-    // base × (2+1)^2 = 1_000_000 × 9 = 9_000_000
-    expect(calculatePrestigeThreshold(2)).toBe(9_000_000);
+  it("returns base × 3^2.5 at count 2", () => {
+    // base × (2+1)^2.5 = 1_000_000 × 3^2.5
+    expect(calculatePrestigeThreshold(2)).toBeCloseTo(1_000_000 * Math.pow(3, 2.5));
   });
 
   it("applies threshold multiplier correctly", () => {
@@ -255,6 +255,20 @@ describe("buildPostPrestigeState", () => {
     expect(prestigeData.autoPrestigeEnabled).toBeUndefined();
   });
 
+  it("preserves autoPrestigeMaxRunestonesOnly when set", () => {
+    const state = makeMinimalState({
+      prestige: { autoPrestigeMaxRunestonesOnly: true, count: 0, productionMultiplier: 1, purchasedUpgradeIds: [], runestones: 0 },
+    });
+    const { prestigeData } = buildPostPrestigeState(state, "Tester");
+    expect(prestigeData.autoPrestigeMaxRunestonesOnly).toBe(true);
+  });
+
+  it("omits autoPrestigeMaxRunestonesOnly when not set", () => {
+    const state = makeMinimalState();
+    const { prestigeData } = buildPostPrestigeState(state, "Tester");
+    expect(prestigeData.autoPrestigeMaxRunestonesOnly).toBeUndefined();
+  });
+
   it("preserves apotheosis data across prestige", () => {
     const apotheosis = { count: 2 };
     const state = makeMinimalState({ apotheosis });