fix: do not display decimal places for integer-typed quantities #232

Closed
opened 2026-04-06 11:23:51 -07:00 by hikari · 0 comments
Owner

Improvement

Summary

Several quantity types in the game are always whole numbers, but the formatNumber utility currently displays them with decimal places (e.g. 1.00 / 72.0). These should display as plain integers.

Affected Values

  • Runestones
  • Crystals
  • Exploration items (found during exploration, used in crafting)
  • Crafting item counts
  • Achievement progress counts — e.g. number of equipment owned, quests completed, adventurers, bosses defeated
  • Clicks
  • Echoes (if always a whole number)

Current Behaviour

1.00 / 72.0

Expected Behaviour

1 / 72

Suggested Fix

Add an integer flag or a separate formatting path for known integer quantities, or pass { maximumFractionDigits: 0 } when displaying these values.


This issue was created with help from Hikari~ 🌸

## Improvement ### Summary Several quantity types in the game are always whole numbers, but the `formatNumber` utility currently displays them with decimal places (e.g. `1.00 / 72.0`). These should display as plain integers. ### Affected Values - **Runestones** - **Crystals** - **Exploration items** (found during exploration, used in crafting) - **Crafting item counts** - **Achievement progress counts** — e.g. number of equipment owned, quests completed, adventurers, bosses defeated - **Clicks** - **Echoes** (if always a whole number) ### Current Behaviour ``` 1.00 / 72.0 ``` ### Expected Behaviour ``` 1 / 72 ``` ### Suggested Fix Add an `integer` flag or a separate formatting path for known integer quantities, or pass `{ maximumFractionDigits: 0 }` when displaying these values. --- ✨ This issue was created with help from Hikari~ 🌸
naomi closed this issue 2026-04-06 18:17:02 -07:00
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#232