nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

fix: suppress expected validation errors from error email notifications #228

New Issue
Closed
opened 2026-04-06 11:18:31 -07:00 by hikari · 0 comments
hikari commented 2026-04-06 11:18:31 -07:00
Owner
Copy Link
Copy Source

Bug Report

Description

The error email notifications are being triggered by expected user-facing validation errors. Specifically, when a player attempts to challenge a boss without any adventurers ready, the API throws a validation error that propagates up through the middleware stack and ends up in the error emails.

This is expected behaviour — it is not a system failure, it is a player doing something invalid. It should not be treated as an unexpected error worthy of an email alert.

Example Email Content

challenge_boss Your party has no adventurers ready to fight
Error: Your party has no adventurers ready to fight
    at It (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:426)
    at async Nm (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:831)
    at async https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:207:20048
    at async v (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:235:11794)

Error: challenge_boss Your party has no adventurers ready to fight
Error: Your party has no adventurers ready to fight
    at It (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:426)
    at async Nm (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:831)
    ...

Expected Behaviour

Validation errors (4xx-class errors representing invalid player actions) should not trigger error email notifications. Only unexpected server-side failures (5xx-class errors) warrant alerting.

Suggested Fix

In the error handling middleware (apps/api/src/routes/frontend.ts and/or the global error handler), differentiate between:

  • Validation/user errors — catch, log if desired, return appropriate HTTP 4xx response, do not email
  • Unexpected server errors — catch, log, return HTTP 500, do email

This likely involves checking whether the thrown error is an instance of a known validation error type (or checking the HTTP status code) before deciding whether to trigger the email notification.

✨ This issue was created with help from Hikari~ 🌸

## Bug Report ### Description The error email notifications are being triggered by expected user-facing validation errors. Specifically, when a player attempts to challenge a boss without any adventurers ready, the API throws a validation error that propagates up through the middleware stack and ends up in the error emails. This is **expected behaviour** — it is not a system failure, it is a player doing something invalid. It should not be treated as an unexpected error worthy of an email alert. ### Example Email Content ``` challenge_boss Your party has no adventurers ready to fight Error: Your party has no adventurers ready to fight at It (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:426) at async Nm (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:831) at async https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:207:20048 at async v (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:235:11794) Error: challenge_boss Your party has no adventurers ready to fight Error: Your party has no adventurers ready to fight at It (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:426) at async Nm (https://elysium.nhcarrigan.com/assets/index-B9lj9vRQ.js:162:831) ... ``` ### Expected Behaviour Validation errors (4xx-class errors representing invalid player actions) should **not** trigger error email notifications. Only unexpected server-side failures (5xx-class errors) warrant alerting. ### Suggested Fix In the error handling middleware (`apps/api/src/routes/frontend.ts` and/or the global error handler), differentiate between: - **Validation/user errors** — catch, log if desired, return appropriate HTTP 4xx response, **do not email** - **Unexpected server errors** — catch, log, return HTTP 500, **do email** This likely involves checking whether the thrown error is an instance of a known validation error type (or checking the HTTP status code) before deciding whether to trigger the email notification. --- ✨ This issue was created with help from Hikari~ 🌸
naomi closed this issue 2026-04-06 18:17:04 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?