nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

feat: sync and patch all content stats on existing saves #130

Merged
naomi merged 3 commits from chore/more-feedback into main 2026-03-24 16:01:48 -07:00
Conversation 0 Commits 3 Files Changed 5
+715 -63
hikari commented 2026-03-24 14:47:05 -07:00
Owner
Copy Link
Copy Source

Summary

  • Sync New Content now injects missing entries AND patches canonical fields on all existing entries to match current defaults
  • Adventurers: stats (baseCost, combatPower, goldPerSecond, essencePerSecond, name, class, level)
  • Quests: duration, prerequisites, combat requirement, rewards
  • Bosses: HP, damage, rewards, prestige requirement, upgrade rewards
  • Zones: unlock conditions (boss/quest required)
  • Upgrades: multiplier, costs
  • Equipment: bonus, cost, set membership
  • Achievements: condition, reward
  • Crafting: multipliers recomputed from craftedRecipeIds so recipe balance changes apply retroactively

Closes #126

Test plan

  • On an existing save, click Sync New Content and verify the notification reports patched counts for all content types
  • Verify that rebalanced adventurer/boss/upgrade stats are reflected in the UI after syncing
  • Verify that player-owned state (counts, unlock status, boss HP, quest status) is preserved after syncing
  • Verify crafting multipliers are correct after syncing if any recipes were previously crafted

✨ This issue was created with help from Hikari~ 🌸

## Summary - Sync New Content now **injects** missing entries AND **patches canonical fields** on all existing entries to match current defaults - Adventurers: stats (baseCost, combatPower, goldPerSecond, essencePerSecond, name, class, level) - Quests: duration, prerequisites, combat requirement, rewards - Bosses: HP, damage, rewards, prestige requirement, upgrade rewards - Zones: unlock conditions (boss/quest required) - Upgrades: multiplier, costs - Equipment: bonus, cost, set membership - Achievements: condition, reward - Crafting: multipliers recomputed from `craftedRecipeIds` so recipe balance changes apply retroactively Closes #126 ## Test plan - [ ] On an existing save, click Sync New Content and verify the notification reports patched counts for all content types - [ ] Verify that rebalanced adventurer/boss/upgrade stats are reflected in the UI after syncing - [ ] Verify that player-owned state (counts, unlock status, boss HP, quest status) is preserved after syncing - [ ] Verify crafting multipliers are correct after syncing if any recipes were previously crafted ✨ This issue was created with help from Hikari~ 🌸
hikari added 5 commits 2026-03-24 14:47:05 -07:00
fix: guard against undefined counts in sync and force-unlock messages 0c7a5f50fc 
Closes #125
feat: poll server for exploration claimability before showing collect button b85126c345 
Resolves #127
fix: return authoritative materials from craft API to prevent client desync
CI / Lint, Build & Test (pull_request) Failing after 1m15s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m16s
Details
e808d92909 
Closes #128
test: add coverage for sync-new-content and explore claimable endpoints
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m4s
Details
CI / Lint, Build & Test (pull_request) Successful in 1m10s
Details
050e34e6cd
fix: patch adventurer stats on sync so rebalances apply to existing saves
CI / Lint, Build & Test (pull_request) Failing after 1m0s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m5s
Details
b3913cef52 
Sync New Content now updates baseCost, class, combatPower, essencePerSecond,
goldPerSecond, level, and name for all existing adventurer entries to match
the current defaults, while preserving count and unlocked state.

Closes #126
hikari added 1 commit 2026-03-24 15:10:17 -07:00
feat: patch all content stats on sync to keep saves up to date
CI / Lint, Build & Test (pull_request) Failing after 1m2s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m5s
Details
2a3c20dc45 
Sync New Content now updates canonical fields on all existing entries
to match current defaults: quests (duration, prerequisites, combat
requirement), bosses (HP, damage, rewards, prestige requirement), zones
(unlock conditions), upgrades (costs, multiplier), equipment (bonus,
cost, set), and achievements (condition, reward). Crafting multipliers
are also recomputed from craftedRecipeIds so recipe balance changes
apply to existing saves.
hikari changed title from fix: patch adventurer stats on sync for rebalanced saves to feat: sync and patch all content stats on existing saves 2026-03-24 15:10:54 -07:00
hikari force-pushed chore/more-feedback from 2a3c20dc45 to e7f0a9d537 2026-03-24 15:14:22 -07:00 Compare
hikari added 1 commit 2026-03-24 15:50:26 -07:00
fix: expose new sync patch counts from game context
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m5s
Details
CI / Lint, Build & Test (pull_request) Successful in 1m10s
Details
5c89b24692 
Co-Authored-By: Hikari <hikari@nhcarrigan.com>
naomi merged commit b48beef474 into main 2026-03-24 16:01:48 -07:00
naomi deleted branch chore/more-feedback 2026-03-24 16:01:48 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#130
Delete Branch "chore/more-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?