nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

fix: NaN displayed in Sync New Content notification #125

New Issue
Closed
opened 2026-03-24 09:48:06 -07:00 by hikari · 0 comments
hikari commented 2026-03-24 09:48:06 -07:00
Owner
Copy Link
Copy Source

Bug Report

Description

The "Sync New Content" notification displays NaN item(s) instead of the actual count of synced items.

Example output: Synced NaN item(s): 1 adventurer tier(s), 5 upgrade(s).

Root Cause

In apps/web/src/components/game/debugPanel.tsx, the buildSyncNewContentMessage function calculates a total via reduce over the count entries. If any count property from SyncNewContentResult is undefined (e.g. a newly added field not yet present in the player's saved state), the arithmetic produces NaN, which then gets interpolated directly into the message string.

Steps to Reproduce

  1. Sync new content when the game has been updated with new adventurer tiers or upgrades
  2. Observe the notification — the total count reads NaN

Expected Behaviour

The total should reflect the correct sum of all synced items (e.g. Synced 6 item(s): 1 adventurer tier(s), 5 upgrade(s).).

Suggested Fix

Guard against undefined/NaN values when building the entries array, or use nullish coalescing (?? 0) on each count property before passing it into the reduce.

✨ This issue was created with help from Hikari~ 🌸

## Bug Report ### Description The "Sync New Content" notification displays `NaN item(s)` instead of the actual count of synced items. **Example output:** `Synced NaN item(s): 1 adventurer tier(s), 5 upgrade(s).` ### Root Cause In `apps/web/src/components/game/debugPanel.tsx`, the `buildSyncNewContentMessage` function calculates a `total` via `reduce` over the count entries. If any count property from `SyncNewContentResult` is `undefined` (e.g. a newly added field not yet present in the player's saved state), the arithmetic produces `NaN`, which then gets interpolated directly into the message string. ### Steps to Reproduce 1. Sync new content when the game has been updated with new adventurer tiers or upgrades 2. Observe the notification — the total count reads `NaN` ### Expected Behaviour The total should reflect the correct sum of all synced items (e.g. `Synced 6 item(s): 1 adventurer tier(s), 5 upgrade(s).`). ### Suggested Fix Guard against `undefined`/`NaN` values when building the entries array, or use nullish coalescing (`?? 0`) on each count property before passing it into the reduce. --- ✨ This issue was created with help from Hikari~ 🌸
naomi closed this issue 2026-03-24 13:20:37 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?