nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

chore: more feedback fixes #129

Merged
naomi merged 4 commits from chore/more-feedback into main 2026-03-24 13:20:37 -07:00
Conversation 0 Commits 4 Files Changed 11
+484 -49
hikari commented 2026-03-24 12:15:40 -07:00
Owner
Copy Link
Copy Source

Summary

  • Fix NaN displayed in Sync New Content / Force Unlock notifications by guarding against undefined counts
  • Poll server for exploration claimability before showing Collect button to prevent client/server desync
  • Return authoritative materials list from craft API to prevent client desync causing false affordability
  • Add test coverage for sync-new-content and explore/claimable endpoints

Closes #125
Closes #127
Closes #128

Test plan

  • Trigger a sync with new content and verify the notification shows a real count instead of NaN
  • Start an exploration, wait for it to complete, and verify the Collect button only appears after the server confirms claimable
  • Attempt to craft a recipe and verify the material counts in the UI update to match the server's authoritative values

✨ This issue was created with help from Hikari~ 🌸

## Summary - Fix `NaN` displayed in Sync New Content / Force Unlock notifications by guarding against undefined counts - Poll server for exploration claimability before showing Collect button to prevent client/server desync - Return authoritative materials list from craft API to prevent client desync causing false affordability - Add test coverage for `sync-new-content` and `explore/claimable` endpoints Closes #125 Closes #127 Closes #128 ## Test plan - [ ] Trigger a sync with new content and verify the notification shows a real count instead of `NaN` - [ ] Start an exploration, wait for it to complete, and verify the Collect button only appears after the server confirms claimable - [ ] Attempt to craft a recipe and verify the material counts in the UI update to match the server's authoritative values ✨ This issue was created with help from Hikari~ 🌸
hikari added 3 commits 2026-03-24 12:15:40 -07:00
fix: guard against undefined counts in sync and force-unlock messages 0c7a5f50fc 
Closes #125
feat: poll server for exploration claimability before showing collect button b85126c345 
Resolves #127
fix: return authoritative materials from craft API to prevent client desync
CI / Lint, Build & Test (pull_request) Failing after 1m15s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m16s
Details
e808d92909 
Closes #128
hikari added 1 commit 2026-03-24 13:18:19 -07:00
test: add coverage for sync-new-content and explore claimable endpoints
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m4s
Details
CI / Lint, Build & Test (pull_request) Successful in 1m10s
Details
050e34e6cd
naomi merged commit 6e573bea14 into main 2026-03-24 13:20:37 -07:00
naomi deleted branch chore/more-feedback 2026-03-24 13:20:37 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#129
Delete Branch "chore/more-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?