nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

fix: correct equipment balance and sort items by stat power #69

Merged
naomi merged 2 commits from fix/equipment-duplicate-combat-multiplier into main 2026-03-19 08:51:08 -07:00
Conversation 0 Commits 2 Files Changed 2
+26 -9
hikari commented 2026-03-18 17:39:12 -07:00
Owner
Copy Link
Copy Source

Summary

Two improvements to the equipment system in one PR:

Balance fixes (closes #54)

Full equipment audit revealed 9 items with duplicated stats, regressions, or purchasable items weaker than free boss drops:

Item Change Reason
Void Conduit 4x → 7x combat 100M essence sink was equal to a zone-6 boss drop
Void Edge 2.75x → 3.25x combat Purchasable was weaker than free Celestial Blade (3x)
Astral Robe 2.25x → 2.75x gold Boss drop was weaker than purchasable Titan's Aegis (2.5x)
Philosopher's Stone 2x → 2.25x click Duplicated Frost Crystal's click multiplier
Eternal Flame 1.15x → 1.25x gold Gold regressed vs Philosopher's Stone (1.25x)
Celestial Focus 2.5x → 3x click 20M essence sink was weaker than free Angel's Halo (2.75x click + 1.3x gold)
Abyssal Tome 3x → 3.75x gold 50M essence sink was equal to free Heaven's Mantle (3x)
Crystal Matrix 4x → 4.75x gold 20M crystal sink was equal to free Sinslayer Aegis (4x)
Infernal Gem 3.5x → 4x click 5M crystal sink was identical to free Prism Eye

Equipment sorting (closes #55)

Equipment cards within each slot now render in ascending order of combined bonus power — the sum of all multiplier bonuses — so stronger items always appear further down the list. Hybrid items such as Volcanic Plate sort correctly without needing a per-slot primary stat.

Test plan

  • All purchasable weapons/armour/trinkets now exceed the stats of the highest free boss drop at their tier
  • No duplicate stat values between adjacent items in the same progression track
  • Equipment cards within each slot render weakest → strongest
  • Hybrid multi-stat items sort sensibly alongside single-stat items
  • Full pipeline green (lint + build + tests at 100% coverage)

✨ This PR was created with help from Hikari~ 🌸

## Summary Two improvements to the equipment system in one PR: ### Balance fixes (closes #54) Full equipment audit revealed 9 items with duplicated stats, regressions, or purchasable items weaker than free boss drops: | Item | Change | Reason | |---|---|---| | Void Conduit | 4x → 7x combat | 100M essence sink was equal to a zone-6 boss drop | | Void Edge | 2.75x → 3.25x combat | Purchasable was weaker than free Celestial Blade (3x) | | Astral Robe | 2.25x → 2.75x gold | Boss drop was weaker than purchasable Titan's Aegis (2.5x) | | Philosopher's Stone | 2x → 2.25x click | Duplicated Frost Crystal's click multiplier | | Eternal Flame | 1.15x → 1.25x gold | Gold regressed vs Philosopher's Stone (1.25x) | | Celestial Focus | 2.5x → 3x click | 20M essence sink was weaker than free Angel's Halo (2.75x click + 1.3x gold) | | Abyssal Tome | 3x → 3.75x gold | 50M essence sink was equal to free Heaven's Mantle (3x) | | Crystal Matrix | 4x → 4.75x gold | 20M crystal sink was equal to free Sinslayer Aegis (4x) | | Infernal Gem | 3.5x → 4x click | 5M crystal sink was identical to free Prism Eye | ### Equipment sorting (closes #55) Equipment cards within each slot now render in ascending order of combined bonus power — the sum of all multiplier bonuses — so stronger items always appear further down the list. Hybrid items such as Volcanic Plate sort correctly without needing a per-slot primary stat. ## Test plan - [ ] All purchasable weapons/armour/trinkets now exceed the stats of the highest free boss drop at their tier - [ ] No duplicate stat values between adjacent items in the same progression track - [ ] Equipment cards within each slot render weakest → strongest - [ ] Hybrid multi-stat items sort sensibly alongside single-stat items - [ ] Full pipeline green (lint + build + tests at 100% coverage) ✨ This PR was created with help from Hikari~ 🌸
hikari added 1 commit 2026-03-18 17:39:12 -07:00
fix: correct equipment stat regressions and purchasable item balance
CI / Lint, Build & Test (pull_request) Successful in 1m10s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m11s
Details
798efb3fb6 
Full equipment audit revealed 9 items where stats were duplicated,
regressed, or where purchasable items were weaker than free boss drops:

- Void Conduit: 4x → 7x combat (100M essence sink was equal to zone-6 drop)
- Void Edge: 2.75x → 3.25x combat (purchasable was weaker than Celestial Blade)
- Astral Robe: 2.25x → 2.75x gold (boss drop was weaker than Titan's Aegis)
- Philosopher's Stone: 2x → 2.25x click (duplicated Frost Crystal)
- Eternal Flame: 1.15x → 1.25x gold (regressed vs Philosopher's Stone)
- Celestial Focus: 2.5x → 3x click (20M essence sink was weaker than Angel's Halo)
- Abyssal Tome: 3x → 3.75x gold (50M essence sink was equal to Heaven's Mantle)
- Crystal Matrix: 4x → 4.75x gold (20M crystal sink was equal to Sinslayer Aegis)
- Infernal Gem: 3.5x → 4x click (5M crystal sink was identical to Prism Eye)

Closes #54
hikari added 1 commit 2026-03-18 18:35:12 -07:00
feat: sort equipment by combined stat power within each slot
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m5s
Details
CI / Lint, Build & Test (pull_request) Successful in 1m9s
Details
84be2aab8a 
Equipment cards within each slot (weapon/armour/trinket) now render in
ascending order of combined bonus power — the sum of all multiplier bonuses
— so stronger items always appear further down the list. Hybrid items such
as Volcanic Plate sort correctly without needing a per-slot primary stat.

Closes #55
hikari changed title from fix: correct equipment stat regressions and purchasable item balance to fix: correct equipment balance and sort items by stat power 2026-03-18 18:35:29 -07:00
naomi merged commit ca2edb090e into main 2026-03-19 08:51:08 -07:00
naomi deleted branch fix/equipment-duplicate-combat-multiplier 2026-03-19 08:51:08 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#69
Delete Branch "fix/equipment-duplicate-combat-multiplier"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?