hikari-desktop

nhcarrigan/hikari-desktop

Fork 0

generated from nhcarrigan/template

Files

T

History

hikari 0ea7861047

Security Scan and Upload / Security & DefectDojo Upload (push) Successful in 1m51s

Details

CI / Lint & Test (push) Has started running

Details

CI / Build Linux (push) Has been cancelled

Details

CI / Build Windows (cross-compile) (push) Has been cancelled

Details

fix: execute Claude CLI commands through WSL on Windows (#139 )

Resolves #137

## Summary

Claude CLI commands (plugin list, MCP list, version check, etc.) were being executed directly in Windows context where the `claude` binary doesn't exist, causing "program not found" errors across the UI.

This PR adds a helper function that automatically prefixes commands with `wsl` on Windows builds, ensuring all Claude CLI commands execute in the correct context.

## Changes

- **Added `create_claude_command()` helper function** that:
  - On Windows: Creates command with `wsl claude` prefix
  - On Linux/Mac: Creates command with `claude` directly

- **Updated 8 command functions** to use the helper:
  - `get_claude_version`
  - `list_plugins`
  - `install_plugin`
  - `uninstall_plugin`
  - `list_mcp_servers`
  - `remove_mcp_server`
  - `add_mcp_server`
  - `get_mcp_server_details`

- **Added comprehensive tests** for both Windows and Linux contexts

## What This Fixes

✅ Memory pane will now display files correctly
✅ CLI version will be detected properly
✅ Plugin pane will work correctly
✅ MCP servers pane will function properly
✅ All Claude CLI commands will execute in the correct context on Windows

## Testing

- ✅ All 427 backend tests pass (added 1 new test)
- ✅ All 387 frontend tests pass
- ✅ All linting and formatting checks pass
- ✅ `check-all.sh` reports: "✨ All checks passed!"

✨ This fix was created by Hikari~ 🌸

Reviewed-on: #139
Co-authored-by: Hikari <hikari@nhcarrigan.com>
Co-committed-by: Hikari <hikari@nhcarrigan.com>