nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

fix: validate Claude binary installation before connection #138

Merged
naomi merged 2 commits from fix/binary into main 2026-02-08 13:47:43 -08:00
Conversation 0 Commits 2 Files Changed 3
+53 -1
hikari commented 2026-02-08 11:53:09 -08:00
Owner
Copy Link
Copy Source

Summary

Add validation to check that the Claude CLI is installed before attempting to start a connection. If the claude binary is not found, users receive a helpful error message with installation instructions.

Changes

  • ✅ Add Claude binary check using which command in WslBridge::start()
  • ✅ Return clear error message with installation command if not found
  • ✅ Add test coverage for the binary check logic (test_claude_binary_check_command_structure)
  • ✅ Update CLAUDE.md with Quality Assurance section documenting check-all.sh

Error Message

If Claude Code is not installed, users will see:

Claude Code is not installed. Please install it using:

curl -fsSL https://claude.ai/install.sh | bash

Testing

  • All 427 backend tests pass ✅
  • All 387 frontend tests pass ✅
  • check-all.sh passes with no errors ✅
  • New test validates the which claude command structure

Documentation Updates

Added comprehensive Quality Assurance section to CLAUDE.md explaining:

  • How to run check-all.sh before committing
  • What checks are included and their order
  • How to source necessary binaries (nvm for Node.js)
  • Troubleshooting steps for failures

✨ This pull request was created by Hikari~ 🌸

## Summary Add validation to check that the Claude CLI is installed before attempting to start a connection. If the `claude` binary is not found, users receive a helpful error message with installation instructions. ## Changes - ✅ Add Claude binary check using `which` command in `WslBridge::start()` - ✅ Return clear error message with installation command if not found - ✅ Add test coverage for the binary check logic (`test_claude_binary_check_command_structure`) - ✅ Update `CLAUDE.md` with Quality Assurance section documenting `check-all.sh` ## Error Message If Claude Code is not installed, users will see: ``` Claude Code is not installed. Please install it using: curl -fsSL https://claude.ai/install.sh | bash ``` ## Testing - All 427 backend tests pass ✅ - All 387 frontend tests pass ✅ - `check-all.sh` passes with no errors ✅ - New test validates the `which claude` command structure ## Documentation Updates Added comprehensive Quality Assurance section to `CLAUDE.md` explaining: - How to run `check-all.sh` before committing - What checks are included and their order - How to source necessary binaries (nvm for Node.js) - Troubleshooting steps for failures ✨ This pull request was created by Hikari~ 🌸
hikari added 1 commit 2026-02-08 11:53:10 -08:00
fix: validate Claude binary installation before connection
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m1s
Details
CI / Lint & Test (pull_request) Failing after 5m50s
Details
CI / Build Linux (pull_request) Has been skipped
Details
CI / Build Windows (cross-compile) (pull_request) Has been skipped
Details
42673b1a01 
Add check to verify that the Claude CLI is installed before attempting
to start a connection. If the binary is not found via `which claude`,
show a helpful error message with installation instructions.

Changes:
- Add Claude binary check using `which` command in WslBridge::start()
- Return clear error message with installation command if not found
- Add test coverage for the binary check logic
- Update CLAUDE.md with Quality Assurance section and check-all.sh docs

The error message guides users to install Claude Code using:
curl -fsSL https://claude.ai/install.sh | bash

✨ This fix was implemented by Hikari~ 🌸
naomi added 1 commit 2026-02-08 12:07:36 -08:00
chore: format
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m5s
Details
CI / Lint & Test (pull_request) Successful in 18m0s
Details
CI / Build Linux (pull_request) Successful in 26m6s
Details
CI / Build Windows (cross-compile) (pull_request) Successful in 41m34s
Details
fe988f5177
naomi merged commit 381bc8410a into main 2026-02-08 13:47:43 -08:00
naomi deleted branch fix/binary 2026-02-08 13:47:44 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#138
Delete Branch "fix/binary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?