nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

fix: execute Claude CLI commands through WSL on Windows #139

Merged
naomi merged 3 commits from fix/windows into main 2026-02-08 13:48:03 -08:00
Conversation 0 Commits 3 Files Changed 2
+111 -15
hikari commented 2026-02-08 12:04:55 -08:00
Owner
Copy Link
Copy Source

Resolves #137

Summary

Claude CLI commands (plugin list, MCP list, version check, etc.) were being executed directly in Windows context where the claude binary doesn't exist, causing "program not found" errors across the UI.

This PR adds a helper function that automatically prefixes commands with wsl on Windows builds, ensuring all Claude CLI commands execute in the correct context.

Changes

  • Added create_claude_command() helper function that:

    • On Windows: Creates command with wsl claude prefix
    • On Linux/Mac: Creates command with claude directly

  • Updated 8 command functions to use the helper:

    • get_claude_version
    • list_plugins
    • install_plugin
    • uninstall_plugin
    • list_mcp_servers
    • remove_mcp_server
    • add_mcp_server
    • get_mcp_server_details

  • Added comprehensive tests for both Windows and Linux contexts

What This Fixes

✅ Memory pane will now display files correctly
✅ CLI version will be detected properly
✅ Plugin pane will work correctly
✅ MCP servers pane will function properly
✅ All Claude CLI commands will execute in the correct context on Windows

Testing

  • ✅ All 427 backend tests pass (added 1 new test)
  • ✅ All 387 frontend tests pass
  • ✅ All linting and formatting checks pass
  • ✅ check-all.sh reports: "✨ All checks passed!"

✨ This fix was created by Hikari~ 🌸

Resolves #137 ## Summary Claude CLI commands (plugin list, MCP list, version check, etc.) were being executed directly in Windows context where the `claude` binary doesn't exist, causing "program not found" errors across the UI. This PR adds a helper function that automatically prefixes commands with `wsl` on Windows builds, ensuring all Claude CLI commands execute in the correct context. ## Changes - **Added `create_claude_command()` helper function** that: - On Windows: Creates command with `wsl claude` prefix - On Linux/Mac: Creates command with `claude` directly - **Updated 8 command functions** to use the helper: - `get_claude_version` - `list_plugins` - `install_plugin` - `uninstall_plugin` - `list_mcp_servers` - `remove_mcp_server` - `add_mcp_server` - `get_mcp_server_details` - **Added comprehensive tests** for both Windows and Linux contexts ## What This Fixes ✅ Memory pane will now display files correctly ✅ CLI version will be detected properly ✅ Plugin pane will work correctly ✅ MCP servers pane will function properly ✅ All Claude CLI commands will execute in the correct context on Windows ## Testing - ✅ All 427 backend tests pass (added 1 new test) - ✅ All 387 frontend tests pass - ✅ All linting and formatting checks pass - ✅ `check-all.sh` reports: "✨ All checks passed!" ✨ This fix was created by Hikari~ 🌸
hikari added 2 commits 2026-02-08 12:04:55 -08:00
fix: execute Claude CLI commands through WSL on Windows e4b27bdff3 
Resolves #137

Claude CLI commands (plugin list, MCP list, version check, etc.) were
being executed directly in Windows context where the `claude` binary
doesn't exist. This caused "program not found" errors across the UI.

Changes:
- Added `create_claude_command()` helper that automatically prefixes
  commands with `wsl` on Windows builds
- Updated 7 command functions to use the helper:
  - get_claude_version
  - list_plugins
  - install_plugin
  - uninstall_plugin
  - list_mcp_servers
  - enable_mcp_server
  - disable_mcp_server
- Added comprehensive tests for both Windows and Linux contexts

This ensures all Claude CLI commands execute in the correct WSL
context on Windows, fixing the memory pane, plugin pane, MCP servers
pane, and CLI version detection.

✨ This fix was created by Hikari~ 🌸
fix: execute Claude CLI commands through WSL on Windows
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m0s
Details
CI / Lint & Test (pull_request) Successful in 17m40s
Details
CI / Build Linux (pull_request) Successful in 24m39s
Details
CI / Build Windows (cross-compile) (pull_request) Successful in 42m6s
Details
269f33b52a 
Resolves #137

Claude CLI commands (plugin list, MCP list, version check, etc.) were
being executed directly in Windows context where the `claude` binary
doesn't exist. This caused "program not found" errors across the UI.

Changes:
- Added `create_claude_command()` helper that automatically prefixes
  commands with `wsl` on Windows builds
- Updated 8 command functions to use the helper:
  - get_claude_version
  - list_plugins
  - install_plugin
  - uninstall_plugin
  - list_mcp_servers
  - remove_mcp_server
  - add_mcp_server
  - get_mcp_server_details
- Added comprehensive tests for both Windows and Linux contexts

This ensures all Claude CLI commands execute in the correct WSL
context on Windows, fixing the memory pane, plugin pane, MCP servers
pane, and CLI version detection.

✨ This fix was created by Hikari~ 🌸
naomi added 1 commit 2026-02-08 12:33:36 -08:00
fix: dynamically resolve Claude binary path on Windows
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 2m9s
Details
CI / Lint & Test (pull_request) Successful in 21m19s
Details
CI / Build Linux (pull_request) Successful in 24m4s
Details
CI / Build Windows (cross-compile) (pull_request) Successful in 34m53s
Details
dfbb6a9b64 
Previously hardcoded `/home/naomi/.local/bin/claude` which would break
for other users. Now uses `wsl -e bash -l -c "which claude"` to find
the Claude binary dynamically using a login shell that has the full PATH.

Also updated 6 plugin/marketplace functions that were still using
`std::process::Command::new("claude")` directly instead of the
`create_claude_command()` helper:
- enable_plugin
- disable_plugin
- update_plugin
- list_marketplaces
- add_marketplace
- remove_marketplace

This ensures all Claude CLI commands work properly on Windows regardless
of where Claude is installed, whilst maintaining backwards compatibility.

✨ This fix was created by Hikari~ 🌸
naomi merged commit 0ea7861047 into main 2026-02-08 13:48:03 -08:00
naomi deleted branch fix/windows 2026-02-08 13:48:03 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#139
Delete Branch "fix/windows"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?