generated from nhcarrigan/template
hikari
a36c8e72a5
## Summary
- Add comprehensive try/catch error handling across all API routes, middleware, and the Hono global error handler, piping every unhandled error to the `@nhcarrigan/logger` service to prevent silent crashes and unhandled Promise rejections
- Add a `logError` utility on the frontend that forwards errors through the overridden `console.error` to the backend telemetry endpoint; apply it to every silent `catch {}` block in the game context, sound, notification, and clipboard utilities, and wrap the React tree in an `ErrorBoundary`
- Add Plausible analytics, Open Graph + Twitter Card meta tags, Tree-Nation widget, and Google Ads to `index.html`
- Make the game sidebar sticky with a `--resource-bar-height` CSS custom property offset so it stays viewport-height without overlapping the resource bar; reset sticky behaviour in the mobile responsive override
## Test plan
- [ ] Lint passes: `pnpm lint`
- [ ] Build passes: `pnpm build`
- [ ] Verify errors thrown in API routes appear in the logger service rather than crashing the process
- [ ] Verify frontend errors appear in the `/api/fe/error` backend log
- [ ] Verify Open Graph tags render correctly when sharing the URL
- [ ] Verify Plausible analytics fires on page load
- [ ] Verify Tree-Nation badge renders in the sidebar
- [ ] Verify sidebar stays fixed while the main content scrolls on desktop
- [ ] Verify mobile layout is unaffected
✨ This issue was created with help from Hikari~ 🌸
Reviewed-on: #44
Co-authored-by: Hikari <hikari@nhcarrigan.com>
Co-committed-by: Hikari <hikari@nhcarrigan.com>
70 lines
2.5 KiB
TypeScript
70 lines
2.5 KiB
TypeScript
/* eslint-disable max-lines-per-function -- Test suites naturally have many cases */
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { Hono } from "hono";
|
|
|
|
vi.mock("../../src/services/jwt.js", () => ({
|
|
verifyToken: vi.fn(),
|
|
}));
|
|
|
|
describe("authMiddleware", () => {
|
|
beforeEach(() => {
|
|
vi.resetModules();
|
|
});
|
|
|
|
const makeApp = async () => {
|
|
const { authMiddleware } = await import("../../src/middleware/auth.js");
|
|
const { verifyToken } = await import("../../src/services/jwt.js");
|
|
const app = new Hono<{ Variables: { discordId: string } }>();
|
|
app.use("*", authMiddleware);
|
|
app.get("/test", (c) => c.json({ discordId: c.get("discordId") }));
|
|
return { app, verifyToken };
|
|
};
|
|
|
|
it("returns 401 when Authorization header is missing", async () => {
|
|
const { app } = await makeApp();
|
|
const res = await app.fetch(new Request("http://localhost/test"));
|
|
expect(res.status).toBe(401);
|
|
});
|
|
|
|
it("returns 401 when Authorization header does not start with Bearer", async () => {
|
|
const { app } = await makeApp();
|
|
const res = await app.fetch(new Request("http://localhost/test", {
|
|
headers: { Authorization: "Basic abc123" },
|
|
}));
|
|
expect(res.status).toBe(401);
|
|
});
|
|
|
|
it("sets discordId in context when token is valid", async () => {
|
|
const { app, verifyToken } = await makeApp();
|
|
vi.mocked(verifyToken).mockReturnValueOnce({ discordId: "user_123", iat: 0, exp: 9999999999 });
|
|
const res = await app.fetch(new Request("http://localhost/test", {
|
|
headers: { Authorization: "Bearer valid_token" },
|
|
}));
|
|
expect(res.status).toBe(200);
|
|
const body = await res.json() as { discordId: string };
|
|
expect(body.discordId).toBe("user_123");
|
|
});
|
|
|
|
it("returns 401 when verifyToken throws", async () => {
|
|
const { app, verifyToken } = await makeApp();
|
|
vi.mocked(verifyToken).mockImplementationOnce(() => {
|
|
throw new Error("Invalid token");
|
|
});
|
|
const res = await app.fetch(new Request("http://localhost/test", {
|
|
headers: { Authorization: "Bearer bad_token" },
|
|
}));
|
|
expect(res.status).toBe(401);
|
|
});
|
|
|
|
it("returns 401 when verifyToken throws a non-Error value", async () => {
|
|
const { app, verifyToken } = await makeApp();
|
|
vi.mocked(verifyToken).mockImplementationOnce(() => {
|
|
throw "raw string error";
|
|
});
|
|
const res = await app.fetch(new Request("http://localhost/test", {
|
|
headers: { Authorization: "Bearer bad_token" },
|
|
}));
|
|
expect(res.status).toBe(401);
|
|
});
|
|
});
|