nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

fix: adventurer unlocks not applied by force-unlock tool #93

Merged
naomi merged 3 commits from fix/force-unlock-adventurers into main 2026-03-20 10:28:18 -07:00
Conversation 0 Commits 3 Files Changed 5
+442 -27
hikari commented 2026-03-20 09:45:15 -07:00
Owner
Copy Link
Copy Source

The force-unlock debug route now scans completed quests for adventurer rewards and ensures those tiers are marked as unlocked in game state.

The UI and API response type both surface the new adventurersUnlocked count alongside the existing zone/quest/boss/exploration counts.

Closes #88

✨ This PR was created with help from Hikari~ 🌸

The force-unlock debug route now scans completed quests for adventurer rewards and ensures those tiers are marked as unlocked in game state. The UI and API response type both surface the new `adventurersUnlocked` count alongside the existing zone/quest/boss/exploration counts. Closes #88 ✨ This PR was created with help from Hikari~ 🌸
hikari added 1 commit 2026-03-20 09:45:15 -07:00
fix: adventurer unlocks not applied by force-unlock tool
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m9s
Details
CI / Lint, Build & Test (pull_request) Failing after 1m13s
Details
715ccd3fc7 
The force-unlock debug route now scans completed quests for adventurer
rewards and ensures those tiers are marked as unlocked in game state.
The UI and API response type both surface the new adventurersUnlocked
count alongside existing zone/quest/boss/exploration counts.

Closes #88
hikari added 1 commit 2026-03-20 10:00:13 -07:00
fix: extend force-unlock to cover upgrades, equipment, and story chapters
CI / Lint, Build & Test (pull_request) Failing after 1m8s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m10s
Details
16c95f4fb3 
The force-unlock debug tool now also corrects three additional categories
of stuck state:

- Upgrades: scans defeated bosses and completed quests for upgrade
  rewards and marks those upgrades as unlocked
- Equipment: scans defeated bosses for equipment rewards and marks those
  items as owned (without auto-equipping)
- Story chapters: checks every chapter's unlock condition against the
  current game state and adds any missing IDs to unlockedChapterIds

The result message in the debug panel now reports all eight corrected
categories.
hikari added 1 commit 2026-03-20 10:11:22 -07:00
fix: guard against missing reward arrays in force-unlock helpers
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m2s
Details
CI / Lint, Build & Test (pull_request) Successful in 1m9s
Details
212bd2ea27 
Reward lookups now use the game definitions (defaultBosses, defaultQuests)
as the source of truth rather than reading arrays directly off state
objects. This avoids runtime crashes when state objects are minimal
(e.g. in tests or from old save data) and is more semantically correct.

Adds full test coverage for the new applyUpgradeUnlocks,
applyEquipmentUnlocks, applyStoryUnlocks, and applyAdventurerUnlocks
paths in debug.spec.ts (42 tests, 100% coverage).
naomi merged commit 635c630e49 into main 2026-03-20 10:28:18 -07:00
naomi deleted branch fix/force-unlock-adventurers 2026-03-20 10:28:18 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#93
Delete Branch "fix/force-unlock-adventurers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?