nhcarrigan/elysium
11
0
Fork 0
generated from nhcarrigan/template
Code Issues 10 Pull Requests 4 Actions Releases 10 Activity

WIP: feat: respect integer format pref #261

Draft
nerdychara wants to merge 2 commits from feat/respect-format-preference into main
pull from: feat/respect-format-preference
merge into: nhcarrigan:main
Conversation 0 Commits 2 Files Changed 9
+114 -51
nerdychara commented 2026-07-09 13:47:58 -07:00
Member
Copy Link
Copy Source

Explanation

Players set their format preference in the game. It ought to be used. The problem is I don't know how much should be used given these methods are everywhere.

Issue

253

Attestations

Dependencies

  • I have pinned the dependencies to a specific patch version.

Style

  • I have run the linter and resolved any errors.
  • My pull request uses an appropriate title, matching the conventional commit standards.
  • My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request.

Tests

  • My contribution adds new code, and I have added tests to cover it.
  • My contribution modifies existing code, and I have updated the tests to reflect these changes.
  • All new and existing tests pass locally with my changes.
  • Code coverage remains at or above the configured threshold.

Documentation

N/A

Versioning

Minor - My pull request introduces a new non-breaking feature.

### Explanation Players set their format preference in the game. It ought to be used. The problem is I don't know how much should be used given these methods are everywhere. ### Issue 253 ### Attestations - [x] I have read and agree to the [Code of Conduct](https://docs.nhcarrigan.com/community/coc/) - [x] I have read and agree to the [Community Guidelines](https://docs.nhcarrigan.com/community/guide/). - [x] My contribution complies with the [Contributor Covenant](https://docs.nhcarrigan.com/dev/covenant/). ### Dependencies - [x] I have pinned the dependencies to a specific patch version. ### Style - [x] I have run the linter and resolved any errors. - [x] My pull request uses an appropriate title, matching the conventional commit standards. - [x] My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request. ### Tests - [x] My contribution adds new code, and I have added tests to cover it. - [x] My contribution modifies existing code, and I have updated the tests to reflect these changes. - [x] All new and existing tests pass locally with my changes. - [x] Code coverage remains at or above the configured threshold. ### Documentation N/A ### Versioning Minor - My pull request introduces a new non-breaking feature.
nerdychara added 2 commits 2026-07-09 13:47:58 -07:00
feat: respect integer format pref f09fcca0ef
update formatNumber
CI / Lint, Build & Test (pull_request) Failing after 54s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m13s
Details
70e031eed7
Some checks are pending
CI / Lint, Build & Test (pull_request) Failing after 54s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m13s
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/respect-format-preference:feat/respect-format-preference
git checkout feat/respect-format-preference
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
hanna (Hanna Rose) hikari (Hikari) ilenia kirsten minori (Minori) naomi (Naomi Carrigan) nerdychara (Anna Cottrill) nick rain somil tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#261
Delete Branch "feat/respect-format-preference"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?