fix: auto-boss no longer halts on client/server save race condition #91

Merged
naomi merged 1 commits from fix/auto-boss-sync into main 2026-03-20 09:30:57 -07:00
Owner

Summary

Fixes #86. When the client state is ahead of the server save, the auto-boss tick would receive a "Boss is not currently available" error from the API. This error was already acknowledged as an expected race condition and suppressed from telemetry — but it was still setting the error state and turning auto-boss off.

Root Cause

The catch handler treated all errors identically: set autoBossError, turn off autoBoss. The race-condition case should instead silently skip so the next tick can retry naturally.

Fix

When the error is "Boss is not currently available", return early from the catch handler. The finally block still runs, resetting isAutoBossingReference.current = false, so the next tick retries cleanly.

This PR was created with help from Hikari~ 🌸

## Summary Fixes #86. When the client state is ahead of the server save, the auto-boss tick would receive a "Boss is not currently available" error from the API. This error was already acknowledged as an expected race condition and suppressed from telemetry — but it was still setting the error state and turning auto-boss off. ## Root Cause The `catch` handler treated all errors identically: set `autoBossError`, turn off `autoBoss`. The race-condition case should instead silently skip so the next tick can retry naturally. ## Fix When the error is `"Boss is not currently available"`, return early from the `catch` handler. The `finally` block still runs, resetting `isAutoBossingReference.current = false`, so the next tick retries cleanly. ✨ This PR was created with help from Hikari~ 🌸
hikari added 1 commit 2026-03-20 09:23:07 -07:00
fix: auto-boss no longer halts on client/server save race condition
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m3s
CI / Lint, Build & Test (pull_request) Successful in 1m9s
51dd9556b5
Closes #86
naomi merged commit ee47c1e8c9 into main 2026-03-20 09:30:57 -07:00
naomi deleted branch fix/auto-boss-sync 2026-03-20 09:30:58 -07:00
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#91