bug: sync new content count includes all items, not just updated ones #147

Closed
opened 2026-03-25 15:03:41 -07:00 by hikari · 0 comments
Owner

Description

The "Sync New Content" modal reports an inflated count of synced items. It is currently counting every item in every category rather than only the items that actually had changes applied.

For example, the modal reported "387 item(s)" including "33 adventurer stat(s) patched, 95 quest stat(s) patched, 72 boss stat(s) patched..." — these numbers reflect the total content count, not the delta of what was actually updated.

Root Cause (suspected)

This likely regressed when the sync flow was updated to refresh existing content in addition to adding new content. The counter was not scoped to only increment when a record actually differs from its default value (i.e. a real update occurred).

Steps to Reproduce

  1. Have a save with all existing content already synced
  2. Run "Sync New Content" with no actual new content to add
  3. Observe the reported count — it will show a large number despite nothing meaningfully changing

Expected Behaviour

The count should reflect only the items that were genuinely modified (value differed from current state). If nothing changed, the count should be 0 (or a small number reflecting only truly new entries).

Actual Behaviour

The count reflects the total number of items processed, regardless of whether they were actually different.

This issue was created with help from Hikari~ 🌸

## Description The "Sync New Content" modal reports an inflated count of synced items. It is currently counting **every** item in every category rather than only the items that actually had changes applied. For example, the modal reported "387 item(s)" including "33 adventurer stat(s) patched, 95 quest stat(s) patched, 72 boss stat(s) patched..." — these numbers reflect the total content count, not the delta of what was actually updated. ## Root Cause (suspected) This likely regressed when the sync flow was updated to refresh existing content in addition to adding new content. The counter was not scoped to only increment when a record actually differs from its default value (i.e. a real update occurred). ## Steps to Reproduce 1. Have a save with all existing content already synced 2. Run "Sync New Content" with no actual new content to add 3. Observe the reported count — it will show a large number despite nothing meaningfully changing ## Expected Behaviour The count should reflect only the items that were genuinely modified (value differed from current state). If nothing changed, the count should be 0 (or a small number reflecting only truly new entries). ## Actual Behaviour The count reflects the total number of items processed, regardless of whether they were actually different. ✨ This issue was created with help from Hikari~ 🌸
naomi closed this issue 2026-03-31 19:57:53 -07:00
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#147