generated from nhcarrigan/template
bug: sync new content count includes all items, not just updated ones #147
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
The "Sync New Content" modal reports an inflated count of synced items. It is currently counting every item in every category rather than only the items that actually had changes applied.
For example, the modal reported "387 item(s)" including "33 adventurer stat(s) patched, 95 quest stat(s) patched, 72 boss stat(s) patched..." — these numbers reflect the total content count, not the delta of what was actually updated.
Root Cause (suspected)
This likely regressed when the sync flow was updated to refresh existing content in addition to adding new content. The counter was not scoped to only increment when a record actually differs from its default value (i.e. a real update occurred).
Steps to Reproduce
Expected Behaviour
The count should reflect only the items that were genuinely modified (value differed from current state). If nothing changed, the count should be 0 (or a small number reflecting only truly new entries).
Actual Behaviour
The count reflects the total number of items processed, regardless of whether they were actually different.
✨ This issue was created with help from Hikari~ 🌸