nhcarrigan/maribelle
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 3 Pull Requests 7 Actions Releases Activity

feat: add Prisma ORM #5

Open
nerdychara wants to merge 3 commits from feat/add-prisma into main
pull from: feat/add-prisma
merge into: nhcarrigan:main
Conversation 2 Commits 3 Files Changed 10
+418 -88
nerdychara commented 2026-01-06 12:52:59 -08:00
Member
Copy Link
Copy Source

Explanation

This allows the opportunity to use less hard-coded values for this particular bot. This PR should not be merged until Naomi creates a variable for the bot to use.

Issue

1

Attestations

Dependencies

  • I have pinned the dependencies to a specific patch version.

Style

  • I have run the linter and resolved any errors.
  • My pull request uses an appropriate title, matching the conventional commit standards.
  • My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request.

Tests

  • My contribution adds new code, and I have added tests to cover it.
  • My contribution modifies existing code, and I have updated the tests to reflect these changes.
  • All new and existing tests pass locally with my changes.
  • Code coverage remains at or above the configured threshold.

Documentation

No response

Versioning

Major - My pull request introduces a breaking change.

### Explanation This allows the opportunity to use less hard-coded values for this particular bot. This PR should not be merged until Naomi creates a variable for the bot to use. ### Issue 1 ### Attestations - [x] I have read and agree to the [Code of Conduct](https://docs.nhcarrigan.com/community/coc/) - [x] I have read and agree to the [Community Guidelines](https://docs.nhcarrigan.com/community/guide/). - [x] My contribution complies with the [Contributor Covenant](https://docs.nhcarrigan.com/dev/covenant/). ### Dependencies - [x] I have pinned the dependencies to a specific patch version. ### Style - [x] I have run the linter and resolved any errors. - [x] My pull request uses an appropriate title, matching the conventional commit standards. - [x] My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request. ### Tests - [x] My contribution adds new code, and I have added tests to cover it. - [x] My contribution modifies existing code, and I have updated the tests to reflect these changes. - [x] All new and existing tests pass locally with my changes. - [x] Code coverage remains at or above the configured threshold. ### Documentation _No response_ ### Versioning Major - My pull request introduces a breaking change.
nerdychara added 2 commits 2026-01-06 12:52:59 -08:00
feat: add prisma 6fda359b2d
able to sign in and create a local database
Node.js CI / CI (pull_request) Failing after 18s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 49s
Details
1e25328711
nerdychara added 1 commit 2026-01-07 06:05:28 -08:00
move generated folder back to where it belongs
Node.js CI / CI (pull_request) Failing after 19s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 52s
Details
0a0c8dc17c
nerdychara commented 2026-01-07 06:05:48 -08:00
Author
Member
Copy Link
Copy Source

The generatedfolder was moved back where it originally was.

The `generated`folder was moved back where it originally was.
naomi requested changes 2026-01-08 15:58:39 -08:00
naomi left a comment
Owner
Copy Link
Copy Source

https://git.nhcarrigan.com/nhcarrigan/liora is a decent example of our Prisma approach.

https://git.nhcarrigan.com/nhcarrigan/liora is a decent example of our Prisma approach.
.gitignore
@@ -1,2 +1,4 @@
node_modules
prod
generated/prisma
naomi commented 2026-01-08 15:52:50 -08:00
Owner
Copy Link
Copy Source

Prisma should not be creating this at all.

Prisma should not be creating this at all.
.vscode/settings.json
@@ -6,0 +5,4 @@
"eslint.validate": [
"typescript"
],
"prisma.pinToPrisma6": true
naomi commented 2026-01-08 15:53:05 -08:00
Owner
Copy Link
Copy Source

Also not something we set - the version is managed via the package.json file.

Also not something we set - the version is managed via the package.json file.
package.json
@@ -28,2 +29,3 @@
"discord.js": "14.21.0",
"node-schedule": "2.1.1"
"node-schedule": "2.1.1",
"prisma": "6.19"
naomi commented 2026-01-08 15:53:23 -08:00
Owner
Copy Link
Copy Source

This does not look like a proper semver. Did you install correctly?

This does not look like a proper semver. Did you install correctly?
prisma/schema.prisma
@@ -0,0 +5,4 @@
// Try Prisma Accelerate: https://pris.ly/cli/accelerate-init
generator client {
provider = "prisma-client"
naomi commented 2026-01-08 15:54:50 -08:00
Owner
Copy Link
Copy Source

This should be prisma-client-js, I believe.

This should be `prisma-client-js`, I believe.
prisma/schema.prisma
@@ -0,0 +6,4 @@
generator client {
provider = "prisma-client"
output = "../generated/prisma"
naomi commented 2026-01-08 15:54:59 -08:00
Owner
Copy Link
Copy Source

We should not need this at all.

We should not need this at all.
prisma/schema.prisma
@@ -0,0 +14,4 @@
url = env("DATABASE_URL")
}
model ServerData {
naomi commented 2026-01-08 15:56:15 -08:00
Owner
Copy Link
Copy Source

We should index this by serverId to optimise fetches, I think.

We should index this by serverId to optimise fetches, I think.
src/index.ts
@@ -22,6 +23,7 @@ process.on("unhandledRejection", (error) => {
process.on("uncaughtException", (error) => {
if (error instanceof Error) {
void logger.error("Uncaught Exception", error);
void prisma.$disconnect();
naomi commented 2026-01-08 15:56:43 -08:00
Owner
Copy Link
Copy Source

This should not be necessary, why are we disconnecting the database on any uncaught exceptions?

This should not be necessary, why are we disconnecting the database on any uncaught exceptions?
src/prisma.config.ts
@@ -0,0 +1,12 @@
import { defineConfig } from "prisma/config";
naomi commented 2026-01-08 15:57:12 -08:00
Owner
Copy Link
Copy Source

We should not need a config file at all. The schema handles all of the config we need.

We should not need a config file at all. The schema handles all of the config we need.
tsconfig.json
@@ -1,7 +1,7 @@
{
naomi commented 2026-01-08 15:57:29 -08:00
Owner
Copy Link
Copy Source

These changes are incorrect and should be reverted.

These changes are incorrect and should be reverted.
nerdychara marked the pull request as ready for review 2026-01-12 06:51:26 -08:00
Some checks are pending
Node.js CI / CI (pull_request) Failing after 19s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 52s
Details
This pull request has changes conflicting with the target branch.
  • package.json
  • pnpm-lock.yaml
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/add-prisma:feat/add-prisma
git checkout feat/add-prisma
Sign in to join this conversation.
Reviewers
No Reviewers
naomi
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/maribelle#5
Delete Branch "feat/add-prisma"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?