fix: handle base64 uploads correctly #64

Merged

naomi merged 8 commits from fix/urls into main 2026-02-20 16:53:48 -08:00

Conversation 0 Commits 8 Files Changed 6

+98 -11

naomi commented 2026-02-20 16:41:04 -08:00

Owner

Copy Link

Copy Source

Explanation

No response

Issue

No response

Attestations

• I have read and agree to the Code of Conduct
• I have read and agree to the Community Guidelines.
• My contribution complies with the Contributor Covenant.

Dependencies

• I have pinned the dependencies to a specific patch version.

Style

• I have run the linter and resolved any errors.
• My pull request uses an appropriate title, matching the conventional commit standards.
• My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request.

Tests

• My contribution adds new code, and I have added tests to cover it.
• My contribution modifies existing code, and I have updated the tests to reflect these changes.
• All new and existing tests pass locally with my changes.
• Code coverage remains at or above the configured threshold.

Documentation

No response

Versioning

No response

### Explanation _No response_ ### Issue _No response_ ### Attestations - [ ] I have read and agree to the [Code of Conduct](https://docs.nhcarrigan.com/community/coc/) - [ ] I have read and agree to the [Community Guidelines](https://docs.nhcarrigan.com/community/guide/). - [ ] My contribution complies with the [Contributor Covenant](https://docs.nhcarrigan.com/dev/covenant/). ### Dependencies - [ ] I have pinned the dependencies to a specific patch version. ### Style - [ ] I have run the linter and resolved any errors. - [ ] My pull request uses an appropriate title, matching the conventional commit standards. - [ ] My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request. ### Tests - [ ] My contribution adds new code, and I have added tests to cover it. - [ ] My contribution modifies existing code, and I have updated the tests to reflect these changes. - [ ] All new and existing tests pass locally with my changes. - [ ] Code coverage remains at or above the configured threshold. ### Documentation _No response_ ### Versioning _No response_

naomi added 2 commits 2026-02-20 16:41:04 -08:00

feat: add data URL validation aa6252d79f

feat: validate book image correctly b3eac4f584

naomi added 1 commit 2026-02-20 16:44:00 -08:00

fix: correct enum value in books 7e47e87d85

naomi added 1 commit 2026-02-20 16:46:20 -08:00

fix: handle base64 in game service 4b2a8e6fed

naomi added 1 commit 2026-02-20 16:47:01 -08:00

fix: handle base64 in manga service 08e25d9f60

naomi added 1 commit 2026-02-20 16:47:37 -08:00

fix: handle base64 in music service 2e7e718def

naomi added 1 commit 2026-02-20 16:48:47 -08:00

fix: handle base64 in show service f2d3576547

naomi added 1 commit 2026-02-20 16:52:14 -08:00

fix: correct prop for music e3a846ac3b

naomi merged commit 208c11d153 into main 2026-02-20 16:53:48 -08:00

naomi deleted branch fix/urls 2026-02-20 16:53:49 -08:00

naomi referenced this issue from a commit 2026-02-20 16:53:49 -08:00

fix: handle base64 uploads correctly (#64)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

aspect

code

Concerns the software code in the repository

aspect

dx

Concerns developers' experience with the codebase

aspect

interface

Concerns end-users' experience with the software

aspect

text

Concerns the documentation material in the repository

contribute

good first issue

A great opportunity for a team member to learn a new codebase

contribute

help wanted

Open for anyone on our team to grab.

contribute

staff only

Restricted to our executive leadership.

goal

addition

Addition of new feature

goal

fix

Bug fix

goal

improvement

Improvement to an existing feature

points

1

Very simple issue requiring minimal effort and complexity.

points

13

Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.

points

2

Simple issue that requires a bit more thought or investigation.

points

3

Moderate complexity issue requiring more substantial work.

points

5

Complex issue requiring significant effort and expertise.

points

8

Very complex issue requiring extensive work and deep expertise.

priority

critical

1

Must be fixed ASAP

priority

high

2

Stalls work on the project or its dependents

priority

low

4

Low priority and doesn't need to be rushed

priority

medium

3

Not blocking but should be fixed soon

priority

none

5

No priority, should only be performed when a developer is available

status

awaiting triage

Has not been triaged & therefore, not ready for work

status

blocked

Blocked and therefore not ready for work

status

discarded

Will not be worked on

status

discontinued

Not suitable for work as repo is in maintenance

status

label work required

Needs proper labelling before it can be worked on

status

ready for dev

Ready for work

status

ticket work required

Needs more details before it can be worked on

talk

discussion

Open for discussions and feedback

talk

question

Can be resolved with an answer

time

1 day

Approximately one full day of development work.

time

1-2 weeks

One to two weeks of focused development effort.

time

2-3 days

Two to three days of development effort.

time

4-5 days

Approximately one week of development work.

time

<1 day

Less than one day of focused work. Quick fixes or simple tasks.

time

>2 weeks

More than two weeks of development work. Must be broken down into smaller pieces.

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: nhcarrigan/library#64