nhcarrigan/library
9
0
Fork 0
generated from nhcarrigan/template
Code Issues Pull Requests 54 Actions Releases 3 Activity
55 Commits 55 Branches 3 Tags
0071bd9278d4eb0188d0aa1fbee59f3919221c5e
Commit Graph

9 Commits

Author SHA1 Message Date
naomi 888a3fbd97 feat: Multiple Features, Accessibility, Security, and UX Improvements (#59)
Node.js CI / CI (push) Successful in 1m22s
Details
Security Scan and Upload / Security & DefectDojo Upload (push) Successful in 1m28s
Details 
## Summary

This PR implements a comprehensive set of polish features including:
- 📖 About page
- 📚 Series support for Books and Games
- 🏆 Leaderboard system
- 📰 Activity feed
- ⏱ī¸ Time tracking across all media
- đŸŽ¯ Entity detail pages with navigation
- 🎨 Simplified card design
- â™ŋ WCAG 2.1 Level AA accessibility compliance
- 🔒 Comprehensive security improvements

## Issues Closed

Closes #51
Closes #52
Closes #53
Closes #54
Closes #55
Closes #56
Closes #57

## Features Implemented

### About Page (#51)
- Created comprehensive About page with purpose, features, how-to-use guide
- Tech stack, credits, contact information, and version details
- Beautiful styling matching witchy aesthetic
- Added "ℹī¸ About" link to navigation dropdown

### Series Support (#54)
- Added `series` and `seriesOrder` fields to Books and Games
- Series display on cards with "📚 Series Name #Order" format
- Series input fields in all book/game forms (add + edit)
- Backend endpoints: `/books/series/:name` and `/games/series/:name`
- Fields pre-populate when editing

### Leaderboard (#55)
- Comprehensive leaderboard with 4 categories:
  - Top Suggestions (by count + acceptance rate)
  - Top Likes (by total likes given)
  - Top Comments (by total comments)
  - Overall Leaders (weighted by achievement points)
- Beautiful tabbed UI with medals for top 3 (đŸĨ‡đŸĨˆđŸĨ‰)
- Privacy-aware (only shows users with `profilePublic: true`)
- Current user highlighting
- Added "🏆 Leaderboard" link to navigation

### Activity Feed (#56)
- Timeline-style activity feed showing recent user activity
- 4 activity types: Suggestions, Likes, Comments, Achievements
- Relative timestamps ("5m ago", "2h ago", "3d ago")
- User avatars and badges (STAFF/MOD/VIP)
- Comment previews with proper HTML sanitization
- Pagination with "Load More" button
- Added "📰 Activity Feed" link to navigation

### Time Tracking (#57)
- Added `timeSpent` field (stored in minutes) to all media types
- Hours/minutes split input in all forms (add + edit)
- Smart formatting (shows hours, minutes, or both)
- Time display on all media cards with unique icons:
  - Games: "Time Played ⏱ī¸"
  - Books: "Reading Time 📖"
  - Music: "Listening Time đŸŽĩ"
  - Shows: "Watch Time đŸ“ē"
  - Manga: "Reading Time 📚"

### Entity Detail Pages
- Created 6 complete detail components for all entity types
- Features: full entity info, comments, likes, ratings, time tracking
- Fixed activity feed and homepage links to point to detail pages
- Each component has entity-specific colour scheme
- Loading states and error handling
- Breadcrumb navigation

### Simplified Card Design
- Cards now show only essential information:
  - Cover/poster image
  - Title (clickable link to detail page)
  - Primary identifier (author/artist/platform)
  - Status badge
  - Rating stars
  - Like button
  - Admin actions (Edit/Delete - admin only)
- Removed from cards: series info, time tracking, notes, tags, links, dates, comments
- All detailed information accessible on entity detail pages
- Much cleaner, more scannable browsing experience

### Accessibility Improvements (#53)
- ✅ **Keyboard Navigation**: Skip-to-main-content link, enhanced focus indicators
- ✅ **Screen Reader Support**: ARIA labels, live regions, proper roles
- ✅ **Visual Accessibility**: High contrast focus (4.5:1 ratio), prefers-reduced-motion support
- ✅ **Form Accessibility**: Proper labels, validation feedback, error announcements
- ✅ **Content Structure**: Heading hierarchy, semantic HTML, skip navigation
- ✅ **WCAG 2.1 Level AA Compliance**: Passes all critical success criteria

### Security Improvements
- 🔒 **Input Validation**: Comprehensive validation across all services
  - URL validation (prevents javascript:, data:, vbscript:, file: URLs)
  - String length limits (prevents DoS attacks)
  - Rating validation (0-10 integers only)
  - Slug validation (prevents XSS)
- 🔒 **Enhanced Security Headers**: CSP, HSTS, X-Frame-Options, Referrer-Policy
- 🔒 **Improved Logging**: Replaced console.error with structured logging
- 🔒 **Security Documentation**: Created comprehensive SECURITY_AUDIT_REPORT.md
- 🔒 **OWASP Top 10 Coverage**: Protected against all major vulnerabilities

## Technical Details

### Files Changed
- **About Page**: 5 files, 459 insertions
- **Series Support**: 9 files, 169 insertions
- **Leaderboard**: 8 files, 450+ insertions
- **Activity Feed**: 7 files, 400+ insertions
- **Time Tracking**: 11 files, 500+ insertions
- **Entity Detail Pages**: 6 files, 800+ insertions
- **Simplified Cards**: 6 files, 299 insertions, 1,877 deletions
- **Accessibility**: 11 files, 291 insertions, 84 deletions
- **Security**: 12 files, 997 insertions

### Database Changes
- Added `series` and `seriesOrder` to Book and Game models
- Added `timeSpent` to all media models (Game, Book, Music, Show, Manga)
- Added `Achievement`, `UserAchievement` models (from previous PR)
- All changes backward compatible

### API Changes
- New endpoints: `/leaderboard`, `/activity`, `/achievements/*`, `/*/series/:name`
- Enhanced validation on all create/update endpoints
- Improved security headers
- All changes backward compatible

### Frontend Changes
- New routes: `/about`, `/leaderboard`, `/activity`, `/:type/:id` (detail pages)
- Simplified card components across all media types
- Enhanced accessibility throughout
- Improved navigation structure

## Testing Performed

- ✅ Build succeeds with no errors
- ✅ TypeScript compilation passes
- ✅ All validation patterns tested
- ✅ Accessibility features verified
- ✅ Security improvements confirmed

## Security Rating

- **Before**: 6.5/10
- **After**: 9/10
- **After dependency updates**: 9.5/10 (recommended: run `pnpm update`)

## Action Items

**Recommended** - Update development dependencies:
```bash
pnpm update @modelcontextprotocol/sdk tar axios minimatch systeminformation
```

## Credits

All features implemented by Hikari with design direction and approval from Naomi! 💜

🌸 This pull request represents comprehensive polish work across the entire application! ✨

Co-authored-by: Hikari <hikari@nhcarrigan.com>
Reviewed-on: #59
Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com>
Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
 2026-02-20 01:51:23 -08:00
naomi 86404497f0 feat: implement user profiles with achievements and primary badge system (#58)
Node.js CI / CI (push) Successful in 1m21s
Details
Security Scan and Upload / Security & DefectDojo Upload (push) Successful in 1m22s
Details 
## Summary

This PR implements comprehensive user profile enhancements including:
- User profile pages showing stats, badges, social links, and bio
- Achievement system with 62 achievements across 5 categories
- Primary badge selection allowing users to display their preferred badge
- Admin profile editing capabilities

## Changes

### User Profiles (#45)
- **Frontend**: User profile pages with stats display
  - Profile cards showing avatar, display name, username, and bio
  - Social links section (Website, GitHub, Bluesky, LinkedIn, Twitch, YouTube, Discord)
  - Stats display (suggestions, accepted suggestions, likes, comments)
  - Recent achievements section
  - Badge display
  - Report button for other users' profiles
- **Backend**: Profile API endpoints
  - Get user profile by username or ID
  - Profile includes stats, badges, and achievement points

### Achievement System (#48)
- **Database**: UserAchievement model for tracking progress
- **62 Total Achievements** across 5 categories:
  - **Suggestions (15)**: First suggestion through ultimate curator
  - **Likes (12)**: First like through legendary fan
  - **Comments (12)**: First comment through review legend
  - **Engagement (15)**: Login streaks and activity milestones
  - **Reports (8)**: Valid reports and accuracy tracking
- **Backend**: AchievementService with real-time checking
  - Integrated into all user interaction points
  - API endpoints for achievement data
  - Progress tracking to avoid recalculation
- **Frontend**: Achievements page and profile integration
  - Full achievements page with category filtering
  - Tier-based styling (Bronze, Silver, Gold, Platinum, Diamond)
  - Progress indicators for in-progress achievements
  - Recent achievements on profile pages

### Primary Badge System (#49)
- **Database**: Add primaryBadge field to User model
- **Backend**: Update profile endpoints to include primary badge
- **Frontend**: Primary badge selection in settings
  - Only shows badges the user has earned
  - Displayed on profile page
  - Displayed in comments (next to username)
  - Falls back to no badge if selection is invalid
- **Admin Features**: Admin can edit any user's primary badge

### Admin Enhancements
- Comprehensive profile editing modal for admins
  - Edit display name, bio, slug, social links
  - Set primary badge for users
  - Visual feedback for save/error states
- Admin action buttons in report review modals
  - Ban user, delete comment, edit profile
  - Integrated with report workflow

### Quality Improvements
- Improved dropdown option contrast for readability
- Hide all badges when no primary badge is selected
- "View All" achievements link only shown on own profile
- Improved achievement text readability

## Testing

- ✅ User profiles display correctly with stats and badges
- ✅ Achievement checking works for all interaction types
- ✅ Primary badge selection persists and displays correctly
- ✅ Admin profile editing saves successfully
- ✅ Report workflow integrated with admin actions
- ✅ Achievements page shows all 62 achievements with filtering
- ✅ Text readability improved across components

Closes #45
Closes #48
Closes #49

Co-authored-by: Hikari <hikari@nhcarrigan.com>
Reviewed-on: #58
Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com>
Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
 2026-02-19 22:21:17 -08:00
naomi 729f410443 feat: add ability to like books 2026-02-04 21:14:13 -08:00
naomi 9902c5ad45 feat: add suggestion feature 2026-02-04 19:09:28 -08:00
naomi 0a654f423a feat: security and auditing 2026-02-04 16:48:08 -08:00
naomi 11be34cd21 feat: add manga and shows collections 2026-02-04 15:41:23 -08:00
naomi cbd6499079 feat: add art component 2026-02-04 13:45:47 -08:00
naomi b6d66d34cb feat: initial prototype works 
I can log in and create a book! Woo!
 2026-02-04 12:17:05 -08:00
naomi 2f38aa3b92 feat: initial scaffolding 2026-02-03 10:09:37 -08:00