hikari-desktop

nhcarrigan/hikari-desktop

Fork 0

generated from nhcarrigan/template

Files

T

History

hikari 381bc8410a

CI / Build Linux (push) Has been cancelled

Details

CI / Lint & Test (push) Has been cancelled

Details

CI / Build Windows (cross-compile) (push) Has been cancelled

Details

Security Scan and Upload / Security & DefectDojo Upload (push) Has been cancelled

Details

fix: validate Claude binary installation before connection (#138 )

## Summary

Add validation to check that the Claude CLI is installed before attempting to start a connection. If the `claude` binary is not found, users receive a helpful error message with installation instructions.

## Changes

- ✅ Add Claude binary check using `which` command in `WslBridge::start()`
- ✅ Return clear error message with installation command if not found
- ✅ Add test coverage for the binary check logic (`test_claude_binary_check_command_structure`)
- ✅ Update `CLAUDE.md` with Quality Assurance section documenting `check-all.sh`

## Error Message

If Claude Code is not installed, users will see:
```
Claude Code is not installed. Please install it using:

curl -fsSL https://claude.ai/install.sh | bash
```

## Testing

- All 427 backend tests pass ✅
- All 387 frontend tests pass ✅
- `check-all.sh` passes with no errors ✅
- New test validates the `which claude` command structure

## Documentation Updates

Added comprehensive Quality Assurance section to `CLAUDE.md` explaining:
- How to run `check-all.sh` before committing
- What checks are included and their order
- How to source necessary binaries (nvm for Node.js)
- Troubleshooting steps for failures

✨ This pull request was created by Hikari~ 🌸

Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com>
Reviewed-on: #138
Co-authored-by: Hikari <hikari@nhcarrigan.com>
Co-committed-by: Hikari <hikari@nhcarrigan.com>