2 Commits

Author	SHA1	Message	Date
hikari	4b684bcd63	test: add comprehensive test coverage for CLI parsing and core modules ... Added 30 new backend tests for improved code coverage: **New Test Modules:** - debug_logger.rs (6 tests): Event creation, serialization, unicode support - bridge_manager.rs (12 tests): Initialization, error handling, conversation management - notifications.rs (12 tests): PowerShell script generation, quote escaping, formatting **Enhanced Test Coverage:** - commands.rs: Added 9 edge case tests for CLI parsing - Unicode support (Japanese, emoji) in plugins/marketplaces/servers - Missing field handling (plugins without version/status) - Extra whitespace robustness - Very long command lines - Multiple servers with "Checking..." headers **Test Results:** - Backend: 408 tests passing (up from 378) - Frontend: 363 tests passing - Total: 771 comprehensive tests - Coverage: ~60% backend (excellent for testable business logic) **Testing Improvements:** - Extracted testable functions from command handlers - Golden files approach for CLI output parsing - Comprehensive edge case coverage (unicode, special chars, empty values) - Fixed clippy warnings (boolean assertions) All business logic, parsing, serialization, and error handling now comprehensively tested. Co-Authored-By: Naomi Carrigan <commits@nhcarrigan.com>	2026-02-07 18:02:23 -08:00
hikari	bf411adeb7	fix: critical permission modal and config issues (#127) ... ## Summary This PR resolves several critical bugs that were blocking the permission modal and causing config loss: - **Permission modal not appearing** - Fixed z-index issues and runtime errors - **Config store race condition** - Resolved critical race condition causing settings to be lost - **Excessive logging** - Removed redundant fmt layer that was writing to hidden stdout - **System tool prompts** - Prevented unnecessary permission prompts for built-in tools - **Permission batching** - Added support for parallel permission requests - **ExitPlanMode tool** - Fixed ExitPlanMode tool not functioning correctly ## Changes Made ### Permission Modal Fixes - Updated z-index to proper value (9999) to ensure modal appears above all other UI elements - Fixed runtime errors that were preventing modal from rendering - Resolved issues with permission grants not being properly applied ### Config Store Race Condition - Fixed critical race condition where multiple rapid config updates would result in lost settings - Ensured config writes are properly sequenced to prevent data loss - Added proper synchronisation for config store operations ### Logging Cleanup - Removed redundant fmt formatting layer that was outputting to hidden stdout - Cleaned up excessive debug logging added during troubleshooting - Removed temporary debugging documentation files ### UX Improvements - Added close confirmation modal with minimise to tray option - Implemented batching for parallel permission requests - Added debug console for viewing frontend and backend logs ### ExitPlanMode Fix - Fixed ExitPlanMode tool not functioning correctly, ensuring proper transitions out of plan mode ## Issues Resolved Closes #112 - Permission flow now properly handles multiple tool requests Closes #113 - ExitPlanMode tool now functions correctly Closes #126 - Debug console feature added (partial - basic implementation complete) ## Test Plan - [x] Permission modal appears and functions correctly - [x] Config settings persist across app restarts - [x] No excessive logging in production builds - [x] System tools don't trigger permission prompts - [x] Parallel permission requests are properly batched - [x] Debug console displays frontend and backend logs - [x] ExitPlanMode properly exits plan mode --- ✨ This PR was created with help from Hikari~ 🌸 Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com> Reviewed-on: #127 Co-authored-by: Hikari <hikari@nhcarrigan.com> Co-committed-by: Hikari <hikari@nhcarrigan.com>	2026-02-07 01:55:49 -08:00