nhcarrigan/forms
2
0
Fork 0
generated from nhcarrigan/template
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

chore: remove colons from input components #4

Open
nerdychara wants to merge 1 commits from chore/remove-colons into main
pull from: chore/remove-colons
merge into: nhcarrigan:main
Conversation 0 Commits 1 Files Changed 13 +38 -38
nerdychara commented 2025-03-01 18:51:42 -08:00
Member
Copy Link

Explanation

Hard-coding colons into input components, while saving time, is a terrible idea in the long term.

Issue

1

Attestations

Dependencies

  • I have pinned the dependencies to a specific patch version.

Style

  • I have run the linter and resolved any errors.
  • My pull request uses an appropriate title, matching the conventional commit standards.
  • My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request.

Tests

  • My contribution adds new code, and I have added tests to cover it.
  • My contribution modifies existing code, and I have updated the tests to reflect these changes.
  • All new and existing tests pass locally with my changes.
  • Code coverage remains at or above the configured threshold.

Documentation

No response

Versioning

Patch - My pull request introduces bug fixes ONLY.

### Explanation Hard-coding colons into input components, while saving time, is a terrible idea in the long term. ### Issue 1 ### Attestations - [x] I have read and agree to the [Code of Conduct](https://docs.nhcarrigan.com/community/coc/) - [x] I have read and agree to the [Community Guidelines](https://docs.nhcarrigan.com/community/guide/). - [x] My contribution complies with the [Contributor Covenant](https://docs.nhcarrigan.com/dev/covenant/). ### Dependencies - [x] I have pinned the dependencies to a specific patch version. ### Style - [x] I have run the linter and resolved any errors. - [x] My pull request uses an appropriate title, matching the conventional commit standards. - [x] My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request. ### Tests - [x] My contribution adds new code, and I have added tests to cover it. - [x] My contribution modifies existing code, and I have updated the tests to reflect these changes. - [x] All new and existing tests pass locally with my changes. - [ ] Code coverage remains at or above the configured threshold. ### Documentation _No response_ ### Versioning Patch - My pull request introduces bug fixes ONLY.
nerdychara added 1 commit 2025-03-01 18:51:43 -08:00
chore: remove colons from input componentns
All checks were successful
Node.js CI / Lint and Test (pull_request) Successful in 1m37s
Details
fc3f175150
All checks were successful
Node.js CI / Lint and Test (pull_request) Successful in 1m37s
Required
Details
This pull request doesn't have enough required approvals yet. 0 of 1 approvals granted from users or teams on the allowlist.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin chore/remove-colons:chore/remove-colons
git checkout chore/remove-colons
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
New-contributor friendly
contribute
help wanted
Open to participation from the community
contribute
mentorship
Reserved for someone in our mentorship programme
contribute
staff only
Restricted to project staff members
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
priority
critical
Must be fixed ASAP
priority
high
Stalls work on the project or its dependents
priority
low
Low priority and doesn't need to be rushed
priority
medium
Not blocking but should be fixed soon
priority
none
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
naomi nerdychara
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/forms#4
No description provided.
Delete Branch "chore/remove-colons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?