nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

fix: preserve runestone bounty flag for legacy defeated bosses #67

Merged
naomi merged 1 commits from fix/boss-runestone-repeat-kill into main 2026-03-18 13:50:20 -07:00
Conversation 0 Commits 1 Files Changed 2
+30 -1
hikari commented 2026-03-18 13:31:47 -07:00
Owner
Copy Link
Copy Source

Summary

  • Bosses defeated before bountyRunestonesClaimed was introduced had status: "defeated" but the field undefined
  • After prestige, the preservation check (=== true) missed these bosses, so the first-kill bounty was re-awarded on the next run
  • Now also treats status === "defeated" as proof the bounty was already earned, covering the migration case

Test plan

  • Existing test: preserves bountyRunestonesClaimed flag on bosses across prestige — still passes
  • New test: sets bountyRunestonesClaimed on bosses defeated before the flag was introduced — covers the legacy save migration path
  • Full coverage maintained at 100%

Closes #52

✨ This PR was created with help from Hikari~ 🌸

## Summary - Bosses defeated before `bountyRunestonesClaimed` was introduced had `status: "defeated"` but the field `undefined` - After prestige, the preservation check (`=== true`) missed these bosses, so the first-kill bounty was re-awarded on the next run - Now also treats `status === "defeated"` as proof the bounty was already earned, covering the migration case ## Test plan - [ ] Existing test: `preserves bountyRunestonesClaimed flag on bosses across prestige` — still passes - [ ] New test: `sets bountyRunestonesClaimed on bosses defeated before the flag was introduced` — covers the legacy save migration path - [ ] Full coverage maintained at 100% Closes #52 ✨ This PR was created with help from Hikari~ 🌸
hikari added 1 commit 2026-03-18 13:31:48 -07:00
fix: preserve bounty flag for bosses defeated before flag was introduced
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m1s
Details
CI / Lint, Build & Test (pull_request) Successful in 1m8s
Details
05c0faa432 
Bosses killed before `bountyRunestonesClaimed` was added to the codebase
had `status: "defeated"` but the field undefined. After prestige, the
preservation check (`=== true`) missed these, so the bounty was re-awarded
next run. Now also treat `status === "defeated"` as proof the bounty was
already earned.

Closes #52
naomi merged commit aede55a13d into main 2026-03-18 13:50:20 -07:00
naomi deleted branch fix/boss-runestone-repeat-kill 2026-03-18 13:50:20 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#67
Delete Branch "fix/boss-runestone-repeat-kill"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?