nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

fix: resolve all 8 open bug tickets (#242–#249) #250

Merged
naomi merged 1 commits from feat/feedback-v2 into main 2026-04-13 09:50:21 -07:00
Conversation 0 Commits 1 Files Changed 5
+58 -6
hikari commented 2026-04-13 09:44:06 -07:00
Owner
Copy Link
Copy Source

Summary

  • Closes #242 — Crystals in the resource bar now use formatNumber to respect the player's notation setting (suffix/scientific/engineering)
  • Closes #243 — Companion unlock progress includes current-run gold (totalGoldEarned) on both client and server, so companions unlock at the correct threshold
  • Closes #244 — Empty green reward bubbles no longer render for quest crystal rewards with a zero amount
  • Closes #245 / Closes #248 — Auto-save skips when isAutoPrestigingReference.current is true, preventing it from racing with an in-flight prestige and breaking the optimistic lock
  • Closes #246 — Generated and uploaded CDN images for crystal_pulse, crystal_surge, and crystal_tempest upgrades
  • Closes #247 — validateAndSanitize merges daily challenge progress by taking the max of client vs. server progress per challenge, so stale auto-saves can no longer roll back server-side completions
  • Closes #249 — Cached save signature is cleared after buyPrestigeUpgrade succeeds, preventing a stale-signature mismatch on the next auto-save

Test plan

  • Lint passes (pnpm lint)
  • Build passes (pnpm build)
  • Tests pass with 100% coverage (pnpm test)
  • Crystals display in resource bar respects notation setting
  • No empty reward bubbles on quests that don't award crystals
  • Companion progress bar shows correct value including current-run gold
  • Auto-prestige no longer causes save errors
  • Crafting a recipe updates daily challenge progress persistently (not rolled back by next auto-save)
  • Buying a prestige upgrade does not cause a signature mismatch error on next save
  • Crystal upgrade images display correctly in-game

✨ This PR was created with help from Hikari~ 🌸

## Summary - **Closes #242** — Crystals in the resource bar now use `formatNumber` to respect the player's notation setting (suffix/scientific/engineering) - **Closes #243** — Companion unlock progress includes current-run gold (`totalGoldEarned`) on both client and server, so companions unlock at the correct threshold - **Closes #244** — Empty green reward bubbles no longer render for quest crystal rewards with a zero amount - **Closes #245 / Closes #248** — Auto-save skips when `isAutoPrestigingReference.current` is true, preventing it from racing with an in-flight prestige and breaking the optimistic lock - **Closes #246** — Generated and uploaded CDN images for `crystal_pulse`, `crystal_surge`, and `crystal_tempest` upgrades - **Closes #247** — `validateAndSanitize` merges daily challenge progress by taking the max of client vs. server progress per challenge, so stale auto-saves can no longer roll back server-side completions - **Closes #249** — Cached save signature is cleared after `buyPrestigeUpgrade` succeeds, preventing a stale-signature mismatch on the next auto-save ## Test plan - [ ] Lint passes (`pnpm lint`) - [ ] Build passes (`pnpm build`) - [ ] Tests pass with 100% coverage (`pnpm test`) - [ ] Crystals display in resource bar respects notation setting - [ ] No empty reward bubbles on quests that don't award crystals - [ ] Companion progress bar shows correct value including current-run gold - [ ] Auto-prestige no longer causes save errors - [ ] Crafting a recipe updates daily challenge progress persistently (not rolled back by next auto-save) - [ ] Buying a prestige upgrade does not cause a signature mismatch error on next save - [ ] Crystal upgrade images display correctly in-game ✨ This PR was created with help from Hikari~ 🌸
hikari added 1 commit 2026-04-13 09:44:06 -07:00
fix: resolve all 8 open bug tickets (#242–#249)
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m32s
Details
CI / Lint, Build & Test (pull_request) Successful in 1m39s
Details
9eb99069a6 
- #242: use formatNumber for crystals in resource bar to respect notation setting
- #243: include current-run gold in companion unlock progress (client + server)
- #244: skip rendering empty reward spans for zero-crystal quest rewards
- #245/#248: skip auto-save while auto-prestige is in-flight to prevent optimistic lock collision
- #246: generate and upload CDN images for crystal_pulse, crystal_surge, crystal_tempest upgrades
- #247: merge daily challenge progress in validateAndSanitize (take max of client vs server) to prevent stale auto-saves rolling back server-side completions
- #249: clear cached signature after buying prestige upgrade to prevent mismatch on next save
naomi merged commit 9bb1d01d2b into main 2026-04-13 09:50:21 -07:00
naomi deleted branch feat/feedback-v2 2026-04-13 09:50:22 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#250
Delete Branch "feat/feedback-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?