nhcarrigan/elysium
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 5 Pull Requests 1 Actions Releases 10 Activity

balance: frozen_peaks and shadow_marshes quests are in the wrong order in quests.ts #123

New Issue
Closed
opened 2026-03-23 17:16:11 -07:00 by hikari · 0 comments
hikari commented 2026-03-23 17:16:11 -07:00
Owner
Copy Link
Copy Source

Issue

In apps/api/src/data/quests.ts, the zone sections are listed in the wrong order. The actual unlock progression is:

  1. verdant_vale
  2. shattered_ruins
  3. frozen_peaks ← unlocked by elder_dragon + dragon_lair (zone 2)
  4. shadow_marshes ← unlocked by void_titan + storm_citadel (zone 3)
  5. volcanic_depths
  6. astral_void

However, the file currently lists the zones in this order:

  1. verdant_vale
  2. shattered_ruins
  3. shadow_marshes ← listed before frozen_peaks!
  4. frozen_peaks ← listed after shadow_marshes!
  5. volcanic_depths
  6. astral_void

Impact

This does not affect gameplay (quests are filtered by zoneId and zone unlock status), but it causes the quest CP values in the file to read as non-monotonic (zone 4's 300M CP appears before zone 3's 100K CP), making balance auditing difficult and the file misleading for future maintainers.

Suggested Fix

Reorder the // ── Shadow Marshes and // ── Frozen Peaks sections so frozen_peaks precedes shadow_marshes, matching the actual unlock chain.

Priority

🟡 Medium — no gameplay impact but creates ongoing confusion for maintainers

✨ This issue was created with help from Hikari~ 🌸

## Issue In `apps/api/src/data/quests.ts`, the zone sections are listed in the wrong order. The actual unlock progression is: 1. verdant_vale 2. shattered_ruins 3. **frozen_peaks** ← unlocked by elder_dragon + dragon_lair (zone 2) 4. **shadow_marshes** ← unlocked by void_titan + storm_citadel (zone 3) 5. volcanic_depths 6. astral_void However, the file currently lists the zones in this order: 1. verdant_vale 2. shattered_ruins 3. **shadow_marshes** ← listed before frozen_peaks! 4. **frozen_peaks** ← listed after shadow_marshes! 5. volcanic_depths 6. astral_void ## Impact This does not affect gameplay (quests are filtered by `zoneId` and zone unlock status), but it causes the quest CP values in the file to read as non-monotonic (zone 4's 300M CP appears before zone 3's 100K CP), making balance auditing difficult and the file misleading for future maintainers. ## Suggested Fix Reorder the `// ── Shadow Marshes` and `// ── Frozen Peaks` sections so frozen_peaks precedes shadow_marshes, matching the actual unlock chain. ## Priority 🟡 Medium — no gameplay impact but creates ongoing confusion for maintainers ✨ This issue was created with help from Hikari~ 🌸
naomi closed this issue 2026-03-23 17:28:29 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/elysium#123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?