nhcarrigan-archive/forms
Archived
2
0
Fork 0
generated from nhcarrigan/template
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

chore: remove colons from input components #4

Closed
nerdychara wants to merge 1 commits from chore/remove-colons into main
pull from: chore/remove-colons
merge into: nhcarrigan-archive:main
Conversation 0 Commits 1 Files Changed 13 +38 -38
nerdychara commented 2025-03-01 18:51:42 -08:00
First-time contributor
Copy Link

Explanation

Hard-coding colons into input components, while saving time, is a terrible idea in the long term.

Issue

1

Attestations

Dependencies

  • I have pinned the dependencies to a specific patch version.

Style

  • I have run the linter and resolved any errors.
  • My pull request uses an appropriate title, matching the conventional commit standards.
  • My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request.

Tests

  • My contribution adds new code, and I have added tests to cover it.
  • My contribution modifies existing code, and I have updated the tests to reflect these changes.
  • All new and existing tests pass locally with my changes.
  • Code coverage remains at or above the configured threshold.

Documentation

No response

Versioning

Patch - My pull request introduces bug fixes ONLY.

### Explanation Hard-coding colons into input components, while saving time, is a terrible idea in the long term. ### Issue 1 ### Attestations - [x] I have read and agree to the [Code of Conduct](https://docs.nhcarrigan.com/community/coc/) - [x] I have read and agree to the [Community Guidelines](https://docs.nhcarrigan.com/community/guide/). - [x] My contribution complies with the [Contributor Covenant](https://docs.nhcarrigan.com/dev/covenant/). ### Dependencies - [x] I have pinned the dependencies to a specific patch version. ### Style - [x] I have run the linter and resolved any errors. - [x] My pull request uses an appropriate title, matching the conventional commit standards. - [x] My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request. ### Tests - [x] My contribution adds new code, and I have added tests to cover it. - [x] My contribution modifies existing code, and I have updated the tests to reflect these changes. - [x] All new and existing tests pass locally with my changes. - [ ] Code coverage remains at or above the configured threshold. ### Documentation _No response_ ### Versioning Patch - My pull request introduces bug fixes ONLY.
nerdychara added 1 commit 2025-03-01 18:51:43 -08:00
chore: remove colons from input componentns
All checks were successful
Node.js CI / Lint and Test (pull_request) Successful in 1m37s
Details
fc3f175150
naomi closed this pull request 2025-06-12 20:29:10 -07:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
naomi
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan-archive/forms#4
No description provided.
Delete Branch "chore/remove-colons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?