fix(ci): pin LLVM 18 for Windows cross-compilation #17

Merged

naomi merged 3 commits from fix/ci into main 2026-04-13 16:21:43 -07:00

Conversation 0 Commits 3 Files Changed 1

hikari commented 2026-04-13 11:50:49 -07:00

Owner

Copy Link

Copy Source

Summary

The Windows build job has been failing on every PR since the initial release. The root cause is that the default clang/lld/llvm apt packages resolve to an older version of llvm-rc that cannot handle PNG-compressed entries in .ico files — and all six images in icon.ico use PNG compression.

Pinning to clang-18, lld-18, and llvm-18 (available in Ubuntu 24.04's default repos) and registering them via update-alternatives ensures llvm-rc, clang-cl, lld-link, and friends all resolve to a version that handles the icon resource correctly.

✨ This PR was created with help from Hikari~ 🌸

## Summary The Windows build job has been failing on every PR since the initial release. The root cause is that the default `clang`/`lld`/`llvm` apt packages resolve to an older version of `llvm-rc` that cannot handle PNG-compressed entries in `.ico` files — and all six images in `icon.ico` use PNG compression. Pinning to `clang-18`, `lld-18`, and `llvm-18` (available in Ubuntu 24.04's default repos) and registering them via `update-alternatives` ensures `llvm-rc`, `clang-cl`, `lld-link`, and friends all resolve to a version that handles the icon resource correctly. ✨ This PR was created with help from Hikari~ 🌸

hikari added 1 commit 2026-04-13 11:50:50 -07:00

fix(ci): pin LLVM 18 for Windows cross-compilation ... 42b4958c2a

Older llvm-rc versions cannot handle PNG-compressed ICO entries,
causing the Windows build to fail. Pinning to LLVM 18 and setting
up alternatives ensures llvm-rc, clang-cl, and lld-link all resolve
to a version that handles the icon resource correctly.

hikari added 1 commit 2026-04-13 12:13:50 -07:00

fix(ci): use LLVM 18 bin path instead of update-alternatives ... ef7f74a919

clang-cl-18 does not have a versioned symlink in /usr/bin on this
runner, causing update-alternatives to fail and abort the step before
llvm-rc was ever configured. Prepending /usr/lib/llvm-18/bin to PATH
is more robust and ensures all LLVM 18 tools (clang-cl, lld-link,
llvm-rc) are resolved correctly without relying on symlink names.

hikari added 1 commit 2026-04-13 13:15:12 -07:00

fix(ci): regenerate icon.ico with BMP-only entries ... 0903033180

All six entries in the original icon.ico used PNG compression inside
the ICO container. Older versions of llvm-rc (used during Windows
cross-compilation) cannot parse PNG-compressed ICO entries, causing
the resource compilation step to fail since PR #1.

Regenerated with ImageMagick using -compress None to force BMP format
for all sizes including 256x256. Reverts the LLVM pinning attempts
as they are no longer needed.

naomi merged commit 5bfd25e60d into main 2026-04-13 16:21:43 -07:00

naomi referenced this issue from a commit 2026-04-13 16:21:43 -07:00

fix(ci): pin LLVM 18 for Windows cross-compilation (#17)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

aspect

code

Concerns the software code in the repository

aspect

dx

Concerns developers' experience with the codebase

aspect

interface

Concerns end-users' experience with the software

aspect

text

Concerns the documentation material in the repository

contribute

good first issue

A great opportunity for a team member to learn a new codebase

contribute

help wanted

Open for anyone on our team to grab.

contribute

staff only

Restricted to our executive leadership.

goal

addition

Addition of new feature

goal

fix

Bug fix

goal

improvement

Improvement to an existing feature

points

1

Very simple issue requiring minimal effort and complexity.

points

13

Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.

points

2

Simple issue that requires a bit more thought or investigation.

points

3

Moderate complexity issue requiring more substantial work.

points

5

Complex issue requiring significant effort and expertise.

points

8

Very complex issue requiring extensive work and deep expertise.

priority

critical

1

Must be fixed ASAP

priority

high

2

Stalls work on the project or its dependents

priority

low

4

Low priority and doesn't need to be rushed

priority

medium

3

Not blocking but should be fixed soon

priority

none

5

No priority, should only be performed when a developer is available

status

awaiting triage

Has not been triaged & therefore, not ready for work

status

blocked

Blocked and therefore not ready for work

status

discarded

Will not be worked on

status

discontinued

Not suitable for work as repo is in maintenance

status

label work required

Needs proper labelling before it can be worked on

status

ready for dev

Ready for work

status

ticket work required

Needs more details before it can be worked on

talk

discussion

Open for discussions and feedback

talk

question

Can be resolved with an answer

time

1 day

Approximately one full day of development work.

time

1-2 weeks

One to two weeks of focused development effort.

time

2-3 days

Two to three days of development effort.

time

4-5 days

Approximately one week of development work.

time

<1 day

Less than one day of focused work. Quick fixes or simple tasks.

time

>2 weeks

More than two weeks of development work. Must be broken down into smaller pieces.

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: nhcarrigan/tatsumi#17