nhcarrigan/rosalia-nightsong
9
0
Fork 0
generated from nhcarrigan/template
Code Issues Pull Requests 8 Actions Releases 1 Activity

feat: Update Error Notifications with ComponentsV2 #14

Merged
naomi merged 3 commits from feat/errors into main 2026-02-20 20:08:45 -08:00
Conversation 0 Commits 3 Files Changed 7
+195 -46
hikari commented 2026-02-20 19:53:44 -08:00
Owner
Copy Link
Copy Source

Summary

This PR updates Rosalia's Discord error notifications to use Discord's Components V2 for a beautiful, organized display.

Changes Made

  • Removed @mention - Error notifications no longer ping anyone
  • Updated channel - Notifications now go to the correct channel (1474606829504954511)
  • Implemented ComponentsV2 - Using Container (type 17) with Text Display (type 10) components
  • Visual improvements:
    • Added accent color (#E91E63) for the container
    • Added separators (type 14) between sections
    • Organized content with headers for scope, message, and stack trace
    • Code blocks for message and stack trace

Technical Changes

  1. src/modules/pipeLog.ts:

    • Created PipeErrorOptions and DiscordErrorPayloadOptions interfaces
    • Refactored pipeError to accept options object
    • Extracted payload creation into createDiscordErrorPayload helper
    • Implemented ComponentsV2 structure with container, text displays, and separators

  2. src/utils/errorHandler.ts:

    • Updated error handler to use new pipeError interface

  3. src/server/serve.ts:

    • Updated /error webhook endpoint to use new interface

✨ Created by Hikari~ 🌸

## Summary This PR updates Rosalia's Discord error notifications to use Discord's Components V2 for a beautiful, organized display. ### Changes Made - **Removed @mention** - Error notifications no longer ping anyone - **Updated channel** - Notifications now go to the correct channel (1474606829504954511) - **Implemented ComponentsV2** - Using Container (type 17) with Text Display (type 10) components - **Visual improvements**: - Added accent color (#E91E63) for the container - Added separators (type 14) between sections - Organized content with headers for scope, message, and stack trace - Code blocks for message and stack trace ### Technical Changes 1. **`src/modules/pipeLog.ts`**: - Created `PipeErrorOptions` and `DiscordErrorPayloadOptions` interfaces - Refactored `pipeError` to accept options object - Extracted payload creation into `createDiscordErrorPayload` helper - Implemented ComponentsV2 structure with container, text displays, and separators 2. **`src/utils/errorHandler.ts`**: - Updated error handler to use new `pipeError` interface 3. **`src/server/serve.ts`**: - Updated `/error` webhook endpoint to use new interface ✨ Created by Hikari~ 🌸
hikari added 1 commit 2026-02-20 19:53:44 -08:00
feat: update error notifications with ComponentsV2
Node.js CI / CI (pull_request) Failing after 10s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m2s
Details
637fdcf997 
Updated Discord error notifications to use Components V2 with a beautiful
container layout. Changes include:

- Removed @mention from error notifications
- Updated channel ID to 1474606829504954511
- Implemented Container component (type 17) with Text Display components (type 10)
- Added accent color (#E91E63) and separators for visual appeal
- Organized error information with headers for scope, message, and stack trace
- Refactored pipeError to use options object for better code organization
naomi added 1 commit 2026-02-20 19:58:30 -08:00
feat: add media container with error image to notifications
Node.js CI / CI (pull_request) Failing after 8s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m6s
Details
0f7ab59889 
Added a Media Container component (type 9) with a Media Image accessory
(type 11) to display an error image alongside the error header in Discord
notifications. This creates a more visually appealing and informative
error alert.

Changes:
- Created createMediaContainer helper function to generate the media
  container with error image
- Updated createDiscordErrorPayload to use the media container
- Extracted helper to reduce function length and improve code organization
naomi changed title from Update Error Notifications with ComponentsV2 to feat: Update Error Notifications with ComponentsV2 2026-02-20 20:05:17 -08:00
naomi added 1 commit 2026-02-20 20:06:52 -08:00
chore: pin fastify-raw-body dependency to exact version
Node.js CI / CI (pull_request) Successful in 23s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m3s
Details
c28069e7b0 
Pinned fastify-raw-body from ^5.0.0 to 5.0.0 to ensure consistent
dependency versions across all environments.

Changes:
- Pinned fastify-raw-body to 5.0.0
- Regenerated pnpm-lock.yaml
naomi merged commit 9db206ebbc into main 2026-02-20 20:08:45 -08:00
naomi deleted branch feat/errors 2026-02-20 20:08:46 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/rosalia-nightsong#14
Delete Branch "feat/errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?