generated from nhcarrigan/template
7579f1ec97
## Summary This PR implements several improvements to the library application: - Added start and finish date tracking for media items - Added "Retired" category for abandoned media - Implemented avatar-based user menu with dropdown navigation - Added automatic background token refresh to prevent session expiry - Created centralised logging system with frontend-to-API log forwarding - Added toast notifications for error handling ## Changes ### Media Tracking (#41) - Added `dateStarted` and `dateFinished` fields to Books, Games, Manga, Music, and Shows - Updated TypeScript types, Prisma schema, and API services - Added manual date input fields to frontend forms - Properly converts HTML date strings to Date objects before API submission ### Retired Category (#43) - Added `RETIRED` status to all media type enums - Updated Prisma schema, frontend dropdowns, and filter buttons - Added status label handling for retired items ### User Menu (#46) - Replaced username text with avatar image in header - Created dropdown menu with navigation items (Users, Audit, Suggestions) - Added logout button to menu - Implemented keyboard accessibility (tabindex, role, keyup handlers) ### Token Refresh (#44) - Implemented automatic token refresh every 13 minutes in background - Added proactive refresh to prevent token expiry during form filling - Prevents users from losing form data due to expired sessions ### Centralised Logging (#1) - Created `/log` endpoint on API to receive frontend logs - Replaced API console.log calls with @nhcarrigan/logger - Created ConsoleLoggerService to intercept all console methods on frontend - Added global error handlers (window.error, unhandledrejection) on frontend - Added process error handlers (uncaughtException, unhandledRejection, SIGTERM, SIGINT) on API - All frontend console activity now forwarded to centralised logging ### Error Handling - Created ToastService and ToastComponent for displaying errors - Integrated with GlobalErrorHandler and HTTP interceptor - Added accessibility features (keyboard navigation, ARIA attributes) - Set toast opacity to 40% for optimal readability ### Testing & Build - Fixed pre-existing test failure for GET / route (now returns version info) - Added ESM module mocking (jsdom, marked, dompurify, @nhcarrigan/logger) - Configured Jest with isolatedModules to handle TypeScript errors - Excluded test-setup.ts from production build - All tests passing (123 total) - Build passing with no errors ## Test Plan - [x] All tests pass (123 tests) - [x] Build passes without errors - [x] Lint passes (only pre-existing warnings) - [x] Date fields work correctly on all media types - [x] Retired status displays and filters properly - [x] Avatar menu opens/closes correctly with keyboard and mouse - [x] Token refresh prevents session expiry - [x] Toast notifications appear for errors - [x] Frontend logs forward to API successfully - [x] Root route returns version information Closes #41 Closes #43 Closes #44 Closes #46 Closes #1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Hikari <hikari@nhcarrigan.com> Reviewed-on: #50 Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com> Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
152 lines
5.3 KiB
TypeScript
152 lines
5.3 KiB
TypeScript
/**
|
|
* @copyright NHCarrigan
|
|
* @license Naomi's Public License
|
|
* @author Naomi Carrigan
|
|
*/
|
|
|
|
import { BookStatus } from "../src/lib/book.types";
|
|
import type { Book, CreateBookDto, UpdateBookDto } from "../src/lib/book.types";
|
|
|
|
describe("book Types", () => {
|
|
describe("bookStatus enum", () => {
|
|
it("should have the correct values", () => {
|
|
expect(BookStatus.reading).toBe("READING");
|
|
expect(BookStatus.finished).toBe("FINISHED");
|
|
expect(BookStatus.toRead).toBe("TO_READ");
|
|
});
|
|
|
|
it("should have all expected enum values", () => {
|
|
const values = Object.values(BookStatus);
|
|
expect(values).toHaveLength(4);
|
|
expect(values).toContain("READING");
|
|
expect(values).toContain("FINISHED");
|
|
expect(values).toContain("TO_READ");
|
|
expect(values).toContain("RETIRED");
|
|
});
|
|
});
|
|
|
|
describe("book interface", () => {
|
|
it("should accept valid book object with minimal fields", () => {
|
|
const book: Book = {
|
|
author: "F. Scott Fitzgerald",
|
|
createdAt: new Date("2024-01-15"),
|
|
dateAdded: new Date("2024-01-15"),
|
|
id: "book123",
|
|
links: [],
|
|
status: BookStatus.reading,
|
|
tags: [],
|
|
title: "The Great Gatsby",
|
|
updatedAt: new Date("2024-01-16"),
|
|
};
|
|
|
|
expect(book.isbn).toBeUndefined();
|
|
expect(book.dateFinished).toBeUndefined();
|
|
expect(book.rating).toBeUndefined();
|
|
expect(book.notes).toBeUndefined();
|
|
expect(book.coverImage).toBeUndefined();
|
|
});
|
|
|
|
it("should accept valid book object with all fields", () => {
|
|
const fullBook: Book = {
|
|
author: "George Orwell",
|
|
coverImage: "https://example.com/1984-cover.jpg",
|
|
createdAt: new Date("2024-01-01"),
|
|
dateAdded: new Date("2024-01-01"),
|
|
dateFinished: new Date("2024-01-20"),
|
|
id: "book456",
|
|
isbn: "978-0-452-28423-4",
|
|
links: [
|
|
{ title: "Goodreads", url: "https://goodreads.com/book/1984" },
|
|
{ title: "Wikipedia", url: "https://wikipedia.org/wiki/1984" },
|
|
],
|
|
notes: "A dystopian masterpiece that remains relevant",
|
|
rating: 5,
|
|
status: BookStatus.finished,
|
|
tags: [ "dystopian", "classic", "political" ],
|
|
title: "1984",
|
|
updatedAt: new Date("2024-01-20"),
|
|
};
|
|
|
|
expect(fullBook.isbn).toBe("978-0-452-28423-4");
|
|
expect(fullBook.rating).toBe(5);
|
|
expect(fullBook.tags).toHaveLength(3);
|
|
expect(fullBook.links).toHaveLength(2);
|
|
});
|
|
});
|
|
|
|
describe("createBookDto interface", () => {
|
|
it("should accept DTO with required fields only", () => {
|
|
const createDto: CreateBookDto = {
|
|
author: "Harper Lee",
|
|
status: BookStatus.toRead,
|
|
title: "To Kill a Mockingbird",
|
|
};
|
|
|
|
expect(createDto.isbn).toBeUndefined();
|
|
expect(createDto.rating).toBeUndefined();
|
|
expect(createDto.notes).toBeUndefined();
|
|
expect(createDto.coverImage).toBeUndefined();
|
|
expect(createDto.tags).toBeUndefined();
|
|
expect(createDto.links).toBeUndefined();
|
|
});
|
|
|
|
it("should accept DTO with all fields", () => {
|
|
const fullCreateDto: CreateBookDto = {
|
|
author: "J.R.R. Tolkien",
|
|
coverImage: "https://example.com/hobbit-cover.jpg",
|
|
isbn: "978-0-547-92822-7",
|
|
links: [ { title: "Author Website", url: "https://tolkien.com" } ],
|
|
notes: "Starting the journey to Middle-earth",
|
|
rating: 4,
|
|
status: BookStatus.reading,
|
|
tags: [ "fantasy", "adventure", "classic" ],
|
|
title: "The Hobbit",
|
|
};
|
|
|
|
expect(fullCreateDto.isbn).toBe("978-0-547-92822-7");
|
|
expect(fullCreateDto.rating).toBe(4);
|
|
expect(fullCreateDto.tags).toEqual([ "fantasy", "adventure", "classic" ]);
|
|
expect(fullCreateDto.links).toHaveLength(1);
|
|
});
|
|
});
|
|
|
|
describe("updateBookDto type", () => {
|
|
it("should accept empty update DTO", () => {
|
|
const emptyUpdate: UpdateBookDto = {};
|
|
expect(emptyUpdate).toEqual({});
|
|
});
|
|
|
|
it("should accept partial updates including dateFinished", () => {
|
|
const partialUpdate: UpdateBookDto = {
|
|
dateFinished: new Date("2024-02-01"),
|
|
rating: 5,
|
|
status: BookStatus.finished,
|
|
};
|
|
|
|
expect(partialUpdate.status).toBe(BookStatus.finished);
|
|
expect(partialUpdate.dateFinished).toEqual(new Date("2024-02-01"));
|
|
expect(partialUpdate.rating).toBe(5);
|
|
expect(partialUpdate.title).toBeUndefined();
|
|
});
|
|
|
|
it("should accept full update", () => {
|
|
const fullUpdate: UpdateBookDto = {
|
|
author: "Different Author",
|
|
coverImage: "https://example.com/new-cover.jpg",
|
|
dateFinished: new Date("2024-02-15"),
|
|
isbn: "978-1-234-56789-0",
|
|
links: [ { title: "New Link", url: "https://newlink.com" } ],
|
|
notes: "Updated notes after finishing",
|
|
rating: 3,
|
|
status: BookStatus.finished,
|
|
tags: [ "updated", "tags" ],
|
|
title: "Updated Title",
|
|
};
|
|
|
|
expect(fullUpdate.title).toBe("Updated Title");
|
|
expect(fullUpdate.dateFinished).toEqual(new Date("2024-02-15"));
|
|
expect(fullUpdate.links).toHaveLength(1);
|
|
});
|
|
});
|
|
});
|