generated from nhcarrigan/template
888a3fbd97
## Summary This PR implements a comprehensive set of polish features including: - đ About page - đ Series support for Books and Games - đ Leaderboard system - đ° Activity feed - âąī¸ Time tracking across all media - đ¯ Entity detail pages with navigation - đ¨ Simplified card design - âŋ WCAG 2.1 Level AA accessibility compliance - đ Comprehensive security improvements ## Issues Closed Closes #51 Closes #52 Closes #53 Closes #54 Closes #55 Closes #56 Closes #57 ## Features Implemented ### About Page (#51) - Created comprehensive About page with purpose, features, how-to-use guide - Tech stack, credits, contact information, and version details - Beautiful styling matching witchy aesthetic - Added "âšī¸ About" link to navigation dropdown ### Series Support (#54) - Added `series` and `seriesOrder` fields to Books and Games - Series display on cards with "đ Series Name #Order" format - Series input fields in all book/game forms (add + edit) - Backend endpoints: `/books/series/:name` and `/games/series/:name` - Fields pre-populate when editing ### Leaderboard (#55) - Comprehensive leaderboard with 4 categories: - Top Suggestions (by count + acceptance rate) - Top Likes (by total likes given) - Top Comments (by total comments) - Overall Leaders (weighted by achievement points) - Beautiful tabbed UI with medals for top 3 (đĨđĨđĨ) - Privacy-aware (only shows users with `profilePublic: true`) - Current user highlighting - Added "đ Leaderboard" link to navigation ### Activity Feed (#56) - Timeline-style activity feed showing recent user activity - 4 activity types: Suggestions, Likes, Comments, Achievements - Relative timestamps ("5m ago", "2h ago", "3d ago") - User avatars and badges (STAFF/MOD/VIP) - Comment previews with proper HTML sanitization - Pagination with "Load More" button - Added "đ° Activity Feed" link to navigation ### Time Tracking (#57) - Added `timeSpent` field (stored in minutes) to all media types - Hours/minutes split input in all forms (add + edit) - Smart formatting (shows hours, minutes, or both) - Time display on all media cards with unique icons: - Games: "Time Played âąī¸" - Books: "Reading Time đ" - Music: "Listening Time đĩ" - Shows: "Watch Time đē" - Manga: "Reading Time đ" ### Entity Detail Pages - Created 6 complete detail components for all entity types - Features: full entity info, comments, likes, ratings, time tracking - Fixed activity feed and homepage links to point to detail pages - Each component has entity-specific colour scheme - Loading states and error handling - Breadcrumb navigation ### Simplified Card Design - Cards now show only essential information: - Cover/poster image - Title (clickable link to detail page) - Primary identifier (author/artist/platform) - Status badge - Rating stars - Like button - Admin actions (Edit/Delete - admin only) - Removed from cards: series info, time tracking, notes, tags, links, dates, comments - All detailed information accessible on entity detail pages - Much cleaner, more scannable browsing experience ### Accessibility Improvements (#53) - â **Keyboard Navigation**: Skip-to-main-content link, enhanced focus indicators - â **Screen Reader Support**: ARIA labels, live regions, proper roles - â **Visual Accessibility**: High contrast focus (4.5:1 ratio), prefers-reduced-motion support - â **Form Accessibility**: Proper labels, validation feedback, error announcements - â **Content Structure**: Heading hierarchy, semantic HTML, skip navigation - â **WCAG 2.1 Level AA Compliance**: Passes all critical success criteria ### Security Improvements - đ **Input Validation**: Comprehensive validation across all services - URL validation (prevents javascript:, data:, vbscript:, file: URLs) - String length limits (prevents DoS attacks) - Rating validation (0-10 integers only) - Slug validation (prevents XSS) - đ **Enhanced Security Headers**: CSP, HSTS, X-Frame-Options, Referrer-Policy - đ **Improved Logging**: Replaced console.error with structured logging - đ **Security Documentation**: Created comprehensive SECURITY_AUDIT_REPORT.md - đ **OWASP Top 10 Coverage**: Protected against all major vulnerabilities ## Technical Details ### Files Changed - **About Page**: 5 files, 459 insertions - **Series Support**: 9 files, 169 insertions - **Leaderboard**: 8 files, 450+ insertions - **Activity Feed**: 7 files, 400+ insertions - **Time Tracking**: 11 files, 500+ insertions - **Entity Detail Pages**: 6 files, 800+ insertions - **Simplified Cards**: 6 files, 299 insertions, 1,877 deletions - **Accessibility**: 11 files, 291 insertions, 84 deletions - **Security**: 12 files, 997 insertions ### Database Changes - Added `series` and `seriesOrder` to Book and Game models - Added `timeSpent` to all media models (Game, Book, Music, Show, Manga) - Added `Achievement`, `UserAchievement` models (from previous PR) - All changes backward compatible ### API Changes - New endpoints: `/leaderboard`, `/activity`, `/achievements/*`, `/*/series/:name` - Enhanced validation on all create/update endpoints - Improved security headers - All changes backward compatible ### Frontend Changes - New routes: `/about`, `/leaderboard`, `/activity`, `/:type/:id` (detail pages) - Simplified card components across all media types - Enhanced accessibility throughout - Improved navigation structure ## Testing Performed - â Build succeeds with no errors - â TypeScript compilation passes - â All validation patterns tested - â Accessibility features verified - â Security improvements confirmed ## Security Rating - **Before**: 6.5/10 - **After**: 9/10 - **After dependency updates**: 9.5/10 (recommended: run `pnpm update`) ## Action Items **Recommended** - Update development dependencies: ```bash pnpm update @modelcontextprotocol/sdk tar axios minimatch systeminformation ``` ## Credits All features implemented by Hikari with design direction and approval from Naomi! đ đ¸ This pull request represents comprehensive polish work across the entire application! ⨠Co-authored-by: Hikari <hikari@nhcarrigan.com> Reviewed-on: #59 Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com> Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
288 lines
7.1 KiB
TypeScript
288 lines
7.1 KiB
TypeScript
/**
|
|
* @copyright 2026 NHCarrigan
|
|
* @license Naomi's Public License
|
|
* @author Naomi Carrigan
|
|
*/
|
|
|
|
import { Component, Input, Output, EventEmitter, computed } from '@angular/core';
|
|
import { CommonModule } from '@angular/common';
|
|
|
|
@Component({
|
|
selector: 'app-pagination',
|
|
standalone: true,
|
|
imports: [CommonModule],
|
|
template: `
|
|
<nav class="pagination-container" aria-label="Pagination">
|
|
<div class="pagination-info" role="status" aria-live="polite">
|
|
Showing {{ startItem() }} - {{ endItem() }} of {{ totalItems }} items
|
|
</div>
|
|
|
|
<div class="pagination-controls" role="navigation" aria-label="Page navigation">
|
|
<button
|
|
(click)="onPageChange(1)"
|
|
[disabled]="currentPage === 1"
|
|
class="btn btn-sm pagination-btn"
|
|
aria-label="Go to first page"
|
|
type="button"
|
|
>
|
|
<span aria-hidden="true">âĒ</span>
|
|
</button>
|
|
|
|
<button
|
|
(click)="onPageChange(currentPage - 1)"
|
|
[disabled]="currentPage === 1"
|
|
class="btn btn-sm pagination-btn"
|
|
aria-label="Go to previous page"
|
|
type="button"
|
|
>
|
|
<span aria-hidden="true">â</span>
|
|
</button>
|
|
|
|
<div class="page-numbers" role="group" aria-label="Page numbers">
|
|
@for (page of pageNumbers(); track page) {
|
|
@if (page === '...') {
|
|
<span class="page-ellipsis" aria-hidden="true">{{ page }}</span>
|
|
} @else {
|
|
<button
|
|
(click)="onPageChange(+page)"
|
|
[class.active]="currentPage === +page"
|
|
[attr.aria-current]="currentPage === +page ? 'page' : null"
|
|
[attr.aria-label]="'Go to page ' + page"
|
|
class="btn btn-sm pagination-btn page-number"
|
|
type="button"
|
|
>
|
|
{{ page }}
|
|
</button>
|
|
}
|
|
}
|
|
</div>
|
|
|
|
<button
|
|
(click)="onPageChange(currentPage + 1)"
|
|
[disabled]="currentPage === totalPages()"
|
|
class="btn btn-sm pagination-btn"
|
|
aria-label="Go to next page"
|
|
type="button"
|
|
>
|
|
<span aria-hidden="true">â</span>
|
|
</button>
|
|
|
|
<button
|
|
(click)="onPageChange(totalPages())"
|
|
[disabled]="currentPage === totalPages()"
|
|
class="btn btn-sm pagination-btn"
|
|
aria-label="Go to last page"
|
|
type="button"
|
|
>
|
|
<span aria-hidden="true">âĢ</span>
|
|
</button>
|
|
</div>
|
|
|
|
<div class="page-size-selector">
|
|
<label for="page-size">Items per page:</label>
|
|
<select
|
|
id="page-size"
|
|
[value]="pageSize"
|
|
(change)="onPageSizeChange($event)"
|
|
class="page-size-select"
|
|
aria-label="Select number of items per page"
|
|
>
|
|
<option value="10">10</option>
|
|
<option value="25">25</option>
|
|
<option value="50">50</option>
|
|
<option value="100">100</option>
|
|
</select>
|
|
</div>
|
|
</nav>
|
|
`,
|
|
styles: [`
|
|
.pagination-container {
|
|
display: flex;
|
|
justify-content: space-between;
|
|
align-items: center;
|
|
padding: 1rem 0;
|
|
flex-wrap: wrap;
|
|
gap: 1rem;
|
|
}
|
|
|
|
.pagination-info {
|
|
color: var(--witch-plum);
|
|
font-size: 0.9rem;
|
|
}
|
|
|
|
.pagination-controls {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: 0.5rem;
|
|
}
|
|
|
|
.pagination-btn {
|
|
padding: 0.25rem 0.75rem;
|
|
border: 1px solid var(--witch-lavender);
|
|
background: var(--witch-moon);
|
|
color: var(--witch-purple);
|
|
border-radius: 4px;
|
|
cursor: pointer;
|
|
transition: all 0.2s;
|
|
min-width: 2.5rem;
|
|
}
|
|
|
|
.pagination-btn:hover:not(:disabled) {
|
|
background: var(--witch-lavender);
|
|
border-color: var(--witch-mauve);
|
|
transform: translateY(-1px);
|
|
}
|
|
|
|
.pagination-btn:disabled {
|
|
opacity: 0.5;
|
|
cursor: not-allowed;
|
|
}
|
|
|
|
.pagination-btn.active {
|
|
background: #8b6f47;
|
|
color: white;
|
|
border-color: #8b6f47;
|
|
}
|
|
|
|
.page-numbers {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: 0.25rem;
|
|
}
|
|
|
|
.page-number {
|
|
min-width: 2.5rem;
|
|
}
|
|
|
|
.page-ellipsis {
|
|
padding: 0 0.5rem;
|
|
color: var(--witch-mauve);
|
|
}
|
|
|
|
.page-size-selector {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: 0.5rem;
|
|
}
|
|
|
|
.page-size-selector label {
|
|
font-size: 0.9rem;
|
|
color: var(--witch-plum);
|
|
}
|
|
|
|
.page-size-select {
|
|
padding: 0.25rem 0.5rem;
|
|
border: 2px solid var(--witch-lavender);
|
|
border-radius: 4px;
|
|
background: var(--witch-moon);
|
|
color: var(--witch-purple);
|
|
cursor: pointer;
|
|
transition: border-color 0.2s;
|
|
}
|
|
|
|
.page-size-select:hover {
|
|
border-color: var(--witch-mauve);
|
|
}
|
|
|
|
.page-size-select:focus {
|
|
outline: none;
|
|
border-color: var(--witch-rose);
|
|
box-shadow: 0 0 0 3px rgba(168, 87, 126, 0.2);
|
|
}
|
|
|
|
@media (max-width: 768px) {
|
|
.pagination-container {
|
|
justify-content: center;
|
|
}
|
|
|
|
.pagination-controls {
|
|
order: 2;
|
|
width: 100%;
|
|
justify-content: center;
|
|
}
|
|
|
|
.pagination-info {
|
|
order: 1;
|
|
width: 100%;
|
|
text-align: center;
|
|
}
|
|
|
|
.page-size-selector {
|
|
order: 3;
|
|
width: 100%;
|
|
justify-content: center;
|
|
}
|
|
}
|
|
`]
|
|
})
|
|
export class PaginationComponent {
|
|
@Input() currentPage = 1;
|
|
@Input() pageSize = 25;
|
|
@Input() totalItems = 0;
|
|
@Output() pageChange = new EventEmitter<number>();
|
|
@Output() pageSizeChange = new EventEmitter<number>();
|
|
|
|
totalPages = computed(() => Math.ceil(this.totalItems / this.pageSize));
|
|
|
|
startItem = computed(() => {
|
|
if (this.totalItems === 0) return 0;
|
|
return (this.currentPage - 1) * this.pageSize + 1;
|
|
});
|
|
|
|
endItem = computed(() => {
|
|
return Math.min(this.currentPage * this.pageSize, this.totalItems);
|
|
});
|
|
|
|
pageNumbers = computed(() => {
|
|
const total = this.totalPages();
|
|
const current = this.currentPage;
|
|
const pages: (number | string)[] = [];
|
|
|
|
if (total <= 7) {
|
|
// Show all pages if 7 or fewer
|
|
for (let i = 1; i <= total; i++) {
|
|
pages.push(i);
|
|
}
|
|
} else {
|
|
// Always show first page
|
|
pages.push(1);
|
|
|
|
if (current <= 3) {
|
|
// Near the beginning
|
|
for (let i = 2; i <= 5; i++) {
|
|
pages.push(i);
|
|
}
|
|
pages.push('...');
|
|
pages.push(total);
|
|
} else if (current >= total - 2) {
|
|
// Near the end
|
|
pages.push('...');
|
|
for (let i = total - 4; i <= total; i++) {
|
|
pages.push(i);
|
|
}
|
|
} else {
|
|
// In the middle
|
|
pages.push('...');
|
|
pages.push(current - 1);
|
|
pages.push(current);
|
|
pages.push(current + 1);
|
|
pages.push('...');
|
|
pages.push(total);
|
|
}
|
|
}
|
|
|
|
return pages;
|
|
});
|
|
|
|
onPageChange(page: number) {
|
|
if (page >= 1 && page <= this.totalPages() && page !== this.currentPage) {
|
|
this.pageChange.emit(page);
|
|
}
|
|
}
|
|
|
|
onPageSizeChange(event: Event) {
|
|
const target = event.target as HTMLSelectElement;
|
|
const newSize = parseInt(target.value, 10);
|
|
this.pageSizeChange.emit(newSize);
|
|
}
|
|
} |