Files
library/apps/frontend/src/app/components/manga/manga-detail.component.ts
T
hikari 983b78b0e9
Security Scan and Upload / Security & DefectDojo Upload (push) Successful in 1m20s
Node.js CI / CI (push) Successful in 1m24s
feat: base64 uploads, reusable forms, Discord roles, and UX improvements (#66)
## Summary

This PR includes multiple feature additions and fixes to improve the library application:

### 🎨 Base64 Image Upload Support
- Fixed Fastify body limit (1MB → 10MB) to accommodate base64-encoded images
- Corrected base64 size calculation and validation logic
- Improved error handling with proper 400 status codes and helpful messages
- Removed duplicate validation that was blocking uploads
- Users can now upload cover images up to 5MB (decoded size)

### 📝 Reusable Form Components
- Created 6 form components: `GameForm`, `BookForm`, `MusicForm`, `ShowForm`, `MangaForm`, `ArtForm`
- All forms support both 'add' and 'edit' modes with pre-population
- Integrated inline editing into all detail views (edit/delete buttons)
- Enhanced admin suggestions workflow with full forms instead of basic modals
- Added scroll-to-top when clicking edit in list views for better UX

### 🖼️ Default Cover Image
- Added beautiful library reading image as default cover for all media types
- Fixed static asset serving to use correct MIME types
- Updated all 12 components (6 list views + 6 detail views) to always show images

### 🔒 Tiered Rate Limiting
- Unauthenticated users: 100 requests/minute
- Authenticated users: 500 requests/minute (5x more lenient)
- Admin users: No rate limits (complete bypass via allowList)

### 🎮 Discord Integration
- Auto-assign library member role to users in NHCarrigan Discord server
- Checks server membership on every login
- Only assigns role if user is in server and doesn't have it yet
- Graceful error handling without blocking login
- Similar pattern to badge refresh flow

### 📚 Documentation
- Added comprehensive CLAUDE.md with:
  - Project structure and tech stack
  - Development workflow and commands
  - Database schema documentation
  - Authentication flow details
  - Security features
  - Code style conventions
  - Common gotchas and solutions

## Test Plan

- [x] Base64 image uploads work for cover images up to 5MB
- [x] Helpful error messages appear for validation failures
- [x] Edit/delete buttons appear on all detail views for admin users
- [x] Inline edit forms display and save correctly
- [x] Admin suggestions workflow uses full forms for all media types
- [x] Scroll-to-top works when editing from list views
- [x] Default cover image displays when no cover is provided
- [x] Static assets serve with correct MIME types
- [x] Rate limiting works correctly for different user types
- [x] Discord role assignment works on login
- [x] All builds pass without errors
- [x] No TypeScript errors

## Related Issues

Closes #65 - Base64 image upload issue

 This pull request was created with help from Hikari~ 🌸

Reviewed-on: #66
Co-authored-by: Hikari <hikari@nhcarrigan.com>
Co-committed-by: Hikari <hikari@nhcarrigan.com>
2026-02-20 20:32:52 -08:00

747 lines
18 KiB
TypeScript

/**
* @copyright 2026 NHCarrigan
* @license Naomi's Public License
* @author Naomi Carrigan
*/
import { Component, OnInit, inject, signal } from '@angular/core';
import { CommonModule } from '@angular/common';
import { RouterLink, ActivatedRoute, Router } from '@angular/router';
import { FormsModule } from '@angular/forms';
import { MangaService } from '../../services/manga.service';
import { CommentsService } from '../../services/comments.service';
import { AuthService } from '../../services/auth.service';
import { SanitizeService } from '../../services/sanitize.service';
import { CommentDisplayComponent } from '../comment-display/comment-display.component';
import { LikeButtonComponent } from '../shared/like-button.component';
import { MangaFormComponent } from '../shared/manga-form.component';
import { Manga, Comment, MangaStatus, UpdateMangaDto } from '@library/shared-types';
@Component({
selector: 'app-manga-detail',
standalone: true,
imports: [CommonModule, RouterLink, FormsModule, CommentDisplayComponent, LikeButtonComponent, MangaFormComponent],
template: `
<div class="container">
<div class="breadcrumb">
<a routerLink="/manga" class="breadcrumb-link">← Back to Manga</a>
</div>
@if (showEditForm() && authService.user()?.isAdmin && manga()) {
<app-manga-form
mode="edit"
[manga]="manga()!"
(formSubmit)="saveEdit($event)"
(formCancel)="cancelEdit()"
></app-manga-form>
}
@if (loading()) {
<div class="loading">Loading manga details...</div>
} @else if (error()) {
<div class="error-state">
<h2>Manga Not Found</h2>
<p>{{ error() }}</p>
<a routerLink="/manga" class="btn btn-primary">Return to Manga</a>
</div>
} @else if (manga()) {
<div class="manga-detail-card">
<div class="manga-cover-section">
<img [src]="manga()!.coverImage || '/assets/default-cover.jpg'" [alt]="manga()!.title" class="manga-cover-large">
</div>
<div class="manga-content">
<div class="manga-header">
<h1>{{ manga()!.title }}</h1>
<span class="status status-{{ manga()!.status }}">
{{ getStatusLabel(manga()!.status) }}
</span>
</div>
<p class="author">by {{ manga()!.author }}</p>
@if (authService.user()?.isAdmin) {
<div class="admin-actions">
<button (click)="toggleEditForm()" class="btn btn-edit">✏️ {{ showEditForm() ? 'Cancel Edit' : 'Edit' }}</button>
<button (click)="deleteManga()" class="btn btn-delete">🗑️ Delete</button>
</div>
}
@if (manga()!.rating) {
<div class="info-row">
<span class="info-label">Rating:</span>
<div class="rating">
@for (star of [1,2,3,4,5,6,7,8,9,10]; track star) {
<span [class.filled]="star <= manga()!.rating!">★</span>
}
<span class="rating-text">({{ manga()!.rating }}/10)</span>
</div>
</div>
}
@if (manga()!.timeSpent) {
<div class="info-row">
<span class="info-label">Reading Time:</span>
<span class="info-value time-spent">{{ formatTimeSpent(manga()!.timeSpent!) }}</span>
</div>
}
@if (manga()!.dateStarted) {
<div class="info-row">
<span class="info-label">Started:</span>
<span class="info-value">{{ formatDate(manga()!.dateStarted!) }}</span>
</div>
}
@if (manga()!.dateFinished) {
<div class="info-row">
<span class="info-label">Finished:</span>
<span class="info-value">{{ formatDate(manga()!.dateFinished!) }}</span>
</div>
}
<div class="info-row">
<span class="info-label">Added:</span>
<span class="info-value">{{ formatDate(manga()!.createdAt) }}</span>
</div>
<div class="info-row">
<span class="info-label">Last Updated:</span>
<span class="info-value">{{ formatDate(manga()!.updatedAt) }}</span>
</div>
<div class="like-section">
<app-like-button
entityType="manga"
[entityId]="manga()!.id"
></app-like-button>
</div>
@if (manga()!.notes) {
<div class="notes-section">
<h3>Notes</h3>
<p class="notes">{{ manga()!.notes }}</p>
</div>
}
@if (manga()!.tags && manga()!.tags.length > 0) {
<div class="tags-section">
<h3>Tags</h3>
<div class="tags-display">
@for (tag of manga()!.tags; track tag) {
<span class="tag-chip">{{ tag }}</span>
}
</div>
</div>
}
@if (manga()!.links && manga()!.links.length > 0) {
<div class="links-section">
<h3>External Links</h3>
<div class="links-display">
@for (link of manga()!.links; track link.url) {
<a [href]="link.url" target="_blank" rel="noopener noreferrer" class="external-link">
{{ link.title }} ↗
</a>
}
</div>
</div>
}
<div class="comments-section">
<h3>Comments</h3>
@if (authService.isAuthenticated()) {
@if (authService.user()?.isBanned) {
<div class="banned-notice">
You have been banned from commenting.
</div>
} @else {
<form (ngSubmit)="addComment()" class="comment-form">
<textarea
[(ngModel)]="newCommentContent"
name="comment"
placeholder="Add a comment (Markdown supported)..."
rows="3"
></textarea>
<button type="submit" class="btn btn-primary">Post Comment</button>
</form>
}
} @else {
<div class="auth-prompt">
<p>Please sign in to comment.</p>
</div>
}
@if (commentsLoading()) {
<div class="comments-loading">Loading comments...</div>
} @else {
<app-comment-display
[comments]="comments"
(edit)="handleCommentEdit($event)"
(delete)="deleteComment($event)"
/>
}
</div>
</div>
</div>
}
</div>
`,
styles: [`
.container {
max-width: 900px;
margin: 0 auto;
padding: 2rem;
}
.breadcrumb {
margin-bottom: 1.5rem;
}
.breadcrumb-link {
color: #f59e0b;
text-decoration: none;
font-weight: 500;
transition: opacity 0.3s;
}
.breadcrumb-link:hover {
opacity: 0.8;
}
.loading {
text-align: center;
padding: 3rem;
color: #666;
font-size: 1.1rem;
}
.error-state {
text-align: center;
padding: 3rem;
background: #fef2f2;
border: 1px solid #fecaca;
border-radius: 8px;
}
.error-state h2 {
color: #991b1b;
margin-bottom: 1rem;
}
.error-state p {
color: #dc2626;
margin-bottom: 1.5rem;
}
.manga-detail-card {
background: white;
border: 1px solid #e5e7eb;
border-radius: 8px;
overflow: hidden;
box-shadow: 0 1px 3px rgba(0,0,0,0.1);
}
.manga-cover-section {
width: 100%;
background: #f3f4f6;
display: flex;
justify-content: center;
align-items: center;
padding: 2rem;
}
.manga-cover-large {
max-width: 100%;
max-height: 400px;
object-fit: contain;
border-radius: 4px;
}
.manga-content {
padding: 2rem;
}
.manga-header {
display: flex;
align-items: center;
gap: 1rem;
margin-bottom: 1rem;
flex-wrap: wrap;
}
.manga-header h1 {
margin: 0;
font-size: 2rem;
color: #1f2937;
}
.author {
color: #6b7280;
font-style: italic;
font-size: 1.1rem;
margin: 0 0 1rem 0;
}
.status {
display: inline-block;
padding: 0.5rem 1rem;
border-radius: 4px;
font-size: 0.9rem;
font-weight: 500;
}
.status-reading {
background: #fef3c7;
color: #92400e;
}
.status-completed {
background: #d1fae5;
color: #065f46;
}
.status-wantToRead {
background: #e0e7ff;
color: #3730a3;
}
.status-retired {
background: #f3f4f6;
color: #4b5563;
}
.admin-actions {
display: flex;
gap: 0.75rem;
margin-bottom: 1.5rem;
padding: 1rem;
background: #fef3c7;
border-radius: 4px;
border: 1px solid #fbbf24;
}
.btn-edit {
background: #3b82f6;
color: white;
}
.btn-edit:hover {
background: #2563eb;
}
.btn-delete {
background: #ef4444;
color: white;
}
.btn-delete:hover {
background: #dc2626;
}
.info-row {
display: flex;
align-items: center;
gap: 1rem;
margin-bottom: 0.75rem;
padding: 0.5rem 0;
border-bottom: 1px solid #f3f4f6;
}
.info-label {
font-weight: 600;
color: #4b5563;
min-width: 120px;
}
.info-value {
color: #1f2937;
}
.time-spent {
color: #f59e0b;
font-weight: 600;
}
.rating {
display: flex;
align-items: center;
gap: 0.25rem;
}
.rating span {
color: #e5e7eb;
font-size: 1.2rem;
}
.rating span.filled {
color: #f59e0b;
}
.rating-text {
margin-left: 0.5rem;
font-size: 1rem;
color: #6b7280;
font-weight: 500;
}
.like-section {
margin: 1.5rem 0;
}
.notes-section,
.tags-section,
.links-section {
margin-top: 2rem;
}
.notes-section h3,
.tags-section h3,
.links-section h3,
.comments-section h3 {
font-size: 1.25rem;
color: #1f2937;
margin-bottom: 1rem;
}
.notes {
font-size: 1rem;
color: #4b5563;
line-height: 1.6;
white-space: pre-wrap;
}
.tags-display {
display: flex;
flex-wrap: wrap;
gap: 0.5rem;
}
.tag-chip {
background: #f59e0b;
color: white;
padding: 0.375rem 0.875rem;
border-radius: 12px;
font-size: 0.875rem;
font-weight: 500;
}
.links-display {
display: flex;
flex-wrap: wrap;
gap: 0.75rem;
}
.external-link {
color: #f59e0b;
text-decoration: none;
font-size: 0.95rem;
padding: 0.5rem 1rem;
border: 2px solid #f59e0b;
border-radius: 4px;
transition: all 0.2s;
font-weight: 500;
}
.external-link:hover {
background: #f59e0b;
color: white;
}
.comments-section {
margin-top: 2rem;
padding-top: 2rem;
border-top: 2px solid #e5e7eb;
}
.comment-form {
margin-bottom: 1.5rem;
}
.comment-form textarea {
width: 100%;
padding: 0.75rem;
border: 1px solid #d1d5db;
border-radius: 4px;
font-size: 1rem;
resize: vertical;
margin-bottom: 0.75rem;
font-family: inherit;
}
.comment-form textarea:focus {
outline: none;
border-color: #f59e0b;
}
.banned-notice {
background: #fef2f2;
border: 1px solid #fecaca;
color: #991b1b;
padding: 1rem;
border-radius: 4px;
text-align: center;
margin-bottom: 1.5rem;
font-size: 0.95rem;
}
.auth-prompt {
background: #f3f4f6;
padding: 1rem;
border-radius: 4px;
text-align: center;
margin-bottom: 1.5rem;
}
.auth-prompt p {
margin: 0;
color: #4b5563;
}
.comments-loading {
text-align: center;
padding: 1.5rem;
color: #6b7280;
font-size: 0.95rem;
}
.btn {
padding: 0.625rem 1.25rem;
border: none;
border-radius: 4px;
cursor: pointer;
font-size: 1rem;
transition: all 0.3s;
font-weight: 500;
}
.btn:hover {
opacity: 0.9;
}
.btn-primary {
background: #f59e0b;
color: white;
}
@media (max-width: 640px) {
.container {
padding: 1rem;
}
.manga-header {
flex-direction: column;
align-items: flex-start;
}
.manga-header h1 {
font-size: 1.5rem;
}
.admin-actions {
display: flex;
gap: 0.75rem;
margin-bottom: 1.5rem;
padding: 1rem;
background: #fef3c7;
border-radius: 4px;
border: 1px solid #fbbf24;
}
.btn-edit {
background: #3b82f6;
color: white;
}
.btn-edit:hover {
background: #2563eb;
}
.btn-delete {
background: #ef4444;
color: white;
}
.btn-delete:hover {
background: #dc2626;
}
.info-row {
flex-direction: column;
align-items: flex-start;
gap: 0.25rem;
}
.info-label {
min-width: auto;
}
}
`]
})
export class MangaDetailComponent implements OnInit {
private readonly mangaService = inject(MangaService);
private readonly commentsService = inject(CommentsService);
readonly authService = inject(AuthService);
private readonly sanitizeService = inject(SanitizeService);
private readonly route = inject(ActivatedRoute);
private readonly router = inject(Router);
manga = signal<Manga | null>(null);
comments = signal<Comment[]>([]);
loading = signal(true);
commentsLoading = signal(false);
error = signal<string | null>(null);
newCommentContent = '';
showEditForm = signal(false);
ngOnInit() {
const mangaId = this.route.snapshot.paramMap.get('id');
if (!mangaId) {
this.error.set('No manga ID provided');
this.loading.set(false);
return;
}
this.loadManga(mangaId);
this.loadComments(mangaId);
}
private loadManga(mangaId: string) {
this.loading.set(true);
this.mangaService.getMangaById(mangaId).subscribe({
next: (manga) => {
if (!manga) {
this.error.set('Manga not found');
} else {
this.manga.set(manga);
}
this.loading.set(false);
},
error: () => {
this.error.set('Failed to load manga. It may not exist or there was an error.');
this.loading.set(false);
}
});
}
private loadComments(mangaId: string) {
this.commentsLoading.set(true);
this.commentsService.getCommentsForManga(mangaId).subscribe({
next: (comments) => {
this.comments.set(comments);
this.commentsLoading.set(false);
},
error: () => {
this.commentsLoading.set(false);
}
});
}
addComment() {
const manga = this.manga();
if (!manga || !this.newCommentContent.trim()) return;
this.commentsService.addCommentToManga(manga.id, { content: this.newCommentContent }).subscribe({
next: (comment) => {
this.comments.set([comment, ...this.comments()]);
this.newCommentContent = '';
}
});
}
handleCommentEdit(event: { commentId: string; content: string }) {
const manga = this.manga();
if (!manga) return;
this.commentsService.updateCommentOnManga(manga.id, event.commentId, event.content).subscribe({
next: (updatedComment) => {
this.comments.set(
this.comments().map(c => c.id === event.commentId ? updatedComment : c)
);
}
});
}
deleteComment(commentId: string) {
const manga = this.manga();
if (!manga || !confirm('Are you sure you want to delete this comment?')) return;
this.commentsService.deleteCommentFromManga(manga.id, commentId).subscribe({
next: () => {
this.comments.set(this.comments().filter(c => c.id !== commentId));
}
});
}
getStatusLabel(status: MangaStatus): string {
switch (status) {
case MangaStatus.reading: return 'Currently Reading';
case MangaStatus.completed: return 'Completed';
case MangaStatus.wantToRead: return 'Want to Read';
case MangaStatus.retired: return 'Retired';
}
}
formatDate(date: Date | string): string {
return new Date(date).toLocaleDateString('en-GB', {
year: 'numeric',
month: 'long',
day: 'numeric'
});
}
formatTimeSpent(minutes: number): string {
const hours = Math.floor(minutes / 60);
const mins = minutes % 60;
if (hours === 0) {
return `${mins} minutes`;
} else if (mins === 0) {
return `${hours} hour${hours === 1 ? '' : 's'}`;
} else {
return `${hours} hour${hours === 1 ? '' : 's'} ${mins} minute${mins === 1 ? '' : 's'}`;
}
}
toggleEditForm() {
this.showEditForm.update(value => !value);
}
saveEdit(data: UpdateMangaDto) {
const manga = this.manga();
if (!manga) return;
this.mangaService.updateManga(manga.id, data).subscribe({
next: (updatedManga) => {
this.manga.set(updatedManga);
this.showEditForm.set(false);
},
error: (err) => {
alert('Failed to update manga: ' + (err.error?.message || 'Unknown error'));
}
});
}
cancelEdit() {
this.showEditForm.set(false);
}
deleteManga() {
const manga = this.manga();
if (!manga) return;
if (!confirm(`Are you sure you want to delete "${manga.title}"? This action cannot be undone.`)) {
return;
}
this.mangaService.deleteManga(manga.id).subscribe({
next: () => {
this.router.navigate(['/manga']);
},
error: (err) => {
alert('Failed to delete manga: ' + (err.error?.message || 'Unknown error'));
}
});
}
}