Files
library/apps/frontend/src/app/components/my-suggestions/my-suggestions.component.ts
T
naomi 7579f1ec97
Node.js CI / CI (push) Successful in 1m18s
Security Scan and Upload / Security & DefectDojo Upload (push) Successful in 1m17s
feat: multiple improvements to library functionality (#50)
## Summary

This PR implements several improvements to the library application:

- Added start and finish date tracking for media items
- Added "Retired" category for abandoned media
- Implemented avatar-based user menu with dropdown navigation
- Added automatic background token refresh to prevent session expiry
- Created centralised logging system with frontend-to-API log forwarding
- Added toast notifications for error handling

## Changes

### Media Tracking (#41)
- Added `dateStarted` and `dateFinished` fields to Books, Games, Manga, Music, and Shows
- Updated TypeScript types, Prisma schema, and API services
- Added manual date input fields to frontend forms
- Properly converts HTML date strings to Date objects before API submission

### Retired Category (#43)
- Added `RETIRED` status to all media type enums
- Updated Prisma schema, frontend dropdowns, and filter buttons
- Added status label handling for retired items

### User Menu (#46)
- Replaced username text with avatar image in header
- Created dropdown menu with navigation items (Users, Audit, Suggestions)
- Added logout button to menu
- Implemented keyboard accessibility (tabindex, role, keyup handlers)

### Token Refresh (#44)
- Implemented automatic token refresh every 13 minutes in background
- Added proactive refresh to prevent token expiry during form filling
- Prevents users from losing form data due to expired sessions

### Centralised Logging (#1)
- Created `/log` endpoint on API to receive frontend logs
- Replaced API console.log calls with @nhcarrigan/logger
- Created ConsoleLoggerService to intercept all console methods on frontend
- Added global error handlers (window.error, unhandledrejection) on frontend
- Added process error handlers (uncaughtException, unhandledRejection, SIGTERM, SIGINT) on API
- All frontend console activity now forwarded to centralised logging

### Error Handling
- Created ToastService and ToastComponent for displaying errors
- Integrated with GlobalErrorHandler and HTTP interceptor
- Added accessibility features (keyboard navigation, ARIA attributes)
- Set toast opacity to 40% for optimal readability

### Testing & Build
- Fixed pre-existing test failure for GET / route (now returns version info)
- Added ESM module mocking (jsdom, marked, dompurify, @nhcarrigan/logger)
- Configured Jest with isolatedModules to handle TypeScript errors
- Excluded test-setup.ts from production build
- All tests passing (123 total)
- Build passing with no errors

## Test Plan

- [x] All tests pass (123 tests)
- [x] Build passes without errors
- [x] Lint passes (only pre-existing warnings)
- [x] Date fields work correctly on all media types
- [x] Retired status displays and filters properly
- [x] Avatar menu opens/closes correctly with keyboard and mouse
- [x] Token refresh prevents session expiry
- [x] Toast notifications appear for errors
- [x] Frontend logs forward to API successfully
- [x] Root route returns version information

Closes #41
Closes #43
Closes #44
Closes #46
Closes #1

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Hikari <hikari@nhcarrigan.com>
Reviewed-on: #50
Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com>
Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
2026-02-19 16:52:43 -08:00

421 lines
12 KiB
TypeScript

/**
* @copyright 2026 NHCarrigan
* @license Naomi's Public License
* @author Naomi Carrigan
*/
import { Component, OnInit, inject, signal, computed } from '@angular/core';
import { CommonModule } from '@angular/common';
import { SuggestionService } from '../../services/suggestion.service';
import { AuthService } from '../../services/auth.service';
import { PaginationComponent } from '../shared/pagination.component';
import { Suggestion, SuggestionStatus, SuggestionEntity } from '@library/shared-types';
@Component({
selector: 'app-my-suggestions',
standalone: true,
imports: [CommonModule, PaginationComponent],
template: `
<div class="container">
<div class="header-section">
<h2>My Suggestions</h2>
<p class="subtitle">Track the status of items you've suggested to Naomi</p>
</div>
@if (!authService.isAuthenticated()) {
<div class="not-authenticated">
<p>Please log in to view your suggestions.</p>
</div>
} @else if (loading()) {
<div class="loading">Loading your suggestions...</div>
} @else if (suggestions().length === 0) {
<div class="empty-state">
<p>You haven't made any suggestions yet!</p>
<p class="hint">Visit any collection page and click "Suggest a..." to recommend something to Naomi.</p>
</div>
} @else {
<div class="filters">
<button
(click)="setFilter('all')"
[class.active]="statusFilter() === 'all'"
class="filter-btn"
>
All ({{ suggestions().length }})
</button>
<button
(click)="setFilter(SuggestionStatus.unreviewed)"
[class.active]="statusFilter() === SuggestionStatus.unreviewed"
class="filter-btn pending"
>
Pending ({{ unreviewedCount() }})
</button>
<button
(click)="setFilter(SuggestionStatus.accepted)"
[class.active]="statusFilter() === SuggestionStatus.accepted"
class="filter-btn accepted"
>
Accepted ({{ acceptedCount() }})
</button>
<button
(click)="setFilter(SuggestionStatus.declined)"
[class.active]="statusFilter() === SuggestionStatus.declined"
class="filter-btn declined"
>
Declined ({{ declinedCount() }})
</button>
</div>
<app-pagination
[currentPage]="currentPage()"
[pageSize]="pageSize()"
[totalItems]="totalFilteredSuggestions()"
(pageChange)="onPageChange($event)"
(pageSizeChange)="onPageSizeChange($event)"
></app-pagination>
<div class="suggestions-list">
@for (suggestion of paginatedSuggestions(); track suggestion.id) {
<div class="suggestion-card" [class]="'status-' + suggestion.status.toLowerCase()">
<div class="suggestion-header">
<span class="entity-badge" [class]="'entity-' + suggestion.entityType.toLowerCase()">
{{ getEntityIcon(suggestion.entityType) }} {{ suggestion.entityType }}
</span>
<span class="status-badge" [class]="'status-' + suggestion.status.toLowerCase()">
{{ getStatusLabel(suggestion.status) }}
</span>
</div>
<h3 class="suggestion-title">{{ suggestion.title }}</h3>
<div class="suggestion-details">
@if (suggestion.gameData) {
@if (suggestion.gameData.platform) {
<p><strong>Platform:</strong> {{ suggestion.gameData.platform }}</p>
}
}
@if (suggestion.bookData) {
@if (suggestion.bookData.author) {
<p><strong>Author:</strong> {{ suggestion.bookData.author }}</p>
}
}
@if (suggestion.musicData) {
@if (suggestion.musicData.artist) {
<p><strong>Artist:</strong> {{ suggestion.musicData.artist }}</p>
}
}
@if (suggestion.artData) {
@if (suggestion.artData.artist) {
<p><strong>Artist:</strong> {{ suggestion.artData.artist }}</p>
}
}
@if (suggestion.showData) {
@if (suggestion.showData.type) {
<p><strong>Type:</strong> {{ suggestion.showData.type }}</p>
}
}
@if (suggestion.mangaData) {
@if (suggestion.mangaData.author) {
<p><strong>Author:</strong> {{ suggestion.mangaData.author }}</p>
}
}
</div>
@if (suggestion.status === SuggestionStatus.declined && suggestion.declineReason) {
<div class="decline-reason">
<strong>Reason:</strong> {{ suggestion.declineReason }}
</div>
}
<div class="suggestion-footer">
<span class="date">Suggested on {{ formatDate(suggestion.createdAt) }}</span>
</div>
</div>
}
</div>
<app-pagination
[currentPage]="currentPage()"
[pageSize]="pageSize()"
[totalItems]="totalFilteredSuggestions()"
(pageChange)="onPageChange($event)"
(pageSizeChange)="onPageSizeChange($event)"
></app-pagination>
}
</div>
`,
styles: [`
.container {
max-width: 900px;
margin: 0 auto;
padding: 2rem 1rem;
}
.header-section {
margin-bottom: 2rem;
}
.header-section h2 {
margin: 0 0 0.5rem 0;
}
.subtitle {
color: #666;
margin: 0;
}
.not-authenticated,
.loading,
.empty-state {
text-align: center;
padding: 3rem;
color: #666;
background: #f8f9fa;
border-radius: 8px;
}
.hint {
font-size: 0.9rem;
color: #888;
}
.filters {
display: flex;
gap: 0.75rem;
margin-bottom: 2rem;
flex-wrap: wrap;
}
.filter-btn {
padding: 0.5rem 1rem;
background: #e5e7eb;
border: none;
border-radius: 4px;
cursor: pointer;
transition: all 0.3s;
}
.filter-btn:hover {
background: #d1d5db;
}
.filter-btn.active {
color: white;
}
.filter-btn.active,
.filter-btn.active.pending {
background: #f59e0b;
}
.filter-btn.active.accepted {
background: #10b981;
}
.filter-btn.active.declined {
background: #ef4444;
}
.suggestions-list {
display: flex;
flex-direction: column;
gap: 1rem;
}
.suggestion-card {
background: white;
border: 1px solid #e5e7eb;
border-radius: 8px;
padding: 1.25rem;
transition: box-shadow 0.3s;
}
.suggestion-card:hover {
box-shadow: 0 4px 12px rgba(0,0,0,0.1);
}
.suggestion-card.status-accepted {
border-left: 4px solid #10b981;
}
.suggestion-card.status-declined {
border-left: 4px solid #ef4444;
}
.suggestion-card.status-unreviewed {
border-left: 4px solid #f59e0b;
}
.suggestion-header {
display: flex;
gap: 0.75rem;
margin-bottom: 0.75rem;
}
.entity-badge,
.status-badge {
padding: 0.25rem 0.5rem;
border-radius: 4px;
font-size: 0.75rem;
font-weight: 600;
text-transform: uppercase;
}
.entity-badge {
background: #e5e7eb;
color: #374151;
}
.entity-badge.entity-game { background: #fff1f1; color: #dc2626; }
.entity-badge.entity-book { background: #fdf4ed; color: #8b6f47; }
.entity-badge.entity-music { background: #eff6ff; color: #2563eb; }
.entity-badge.entity-manga { background: #ecfdf5; color: #059669; }
.entity-badge.entity-show { background: #fdf2f8; color: #db2777; }
.entity-badge.entity-art { background: #fefce8; color: #ca8a04; }
.status-badge.status-unreviewed {
background: #fef3c7;
color: #92400e;
}
.status-badge.status-accepted {
background: #d1fae5;
color: #065f46;
}
.status-badge.status-declined {
background: #fee2e2;
color: #991b1b;
}
.suggestion-title {
margin: 0 0 0.75rem 0;
font-size: 1.1rem;
}
.suggestion-details {
font-size: 0.9rem;
color: #4b5563;
}
.suggestion-details p {
margin: 0.25rem 0;
}
.decline-reason {
background: #fee2e2;
border: 1px solid #fecaca;
border-radius: 4px;
padding: 0.75rem;
margin-top: 0.75rem;
font-size: 0.9rem;
color: #991b1b;
}
.suggestion-footer {
margin-top: 0.75rem;
padding-top: 0.75rem;
border-top: 1px solid #e5e7eb;
}
.date {
font-size: 0.8rem;
color: #9ca3af;
}
`]
})
export class MySuggestionsComponent implements OnInit {
suggestionService = inject(SuggestionService);
authService = inject(AuthService);
suggestions = signal<Suggestion[]>([]);
loading = signal(true);
statusFilter = signal<'all' | SuggestionStatus>('all');
// Pagination state
currentPage = signal(1);
pageSize = signal(25);
SuggestionStatus = SuggestionStatus;
unreviewedCount = () => this.suggestions().filter(s => s.status === SuggestionStatus.unreviewed).length;
acceptedCount = () => this.suggestions().filter(s => s.status === SuggestionStatus.accepted).length;
declinedCount = () => this.suggestions().filter(s => s.status === SuggestionStatus.declined).length;
filteredSuggestions = computed(() => {
const filter = this.statusFilter();
if (filter === 'all') {
return this.suggestions();
}
return this.suggestions().filter(s => s.status === filter);
});
paginatedSuggestions = computed(() => {
const suggestions = this.filteredSuggestions();
const start = (this.currentPage() - 1) * this.pageSize();
const end = start + this.pageSize();
return suggestions.slice(start, end);
});
totalFilteredSuggestions = computed(() => this.filteredSuggestions().length);
ngOnInit() {
if (this.authService.isAuthenticated()) {
this.loadSuggestions();
} else {
this.loading.set(false);
}
}
async loadSuggestions() {
this.loading.set(true);
try {
const suggestions = await this.suggestionService.getMySuggestions();
this.suggestions.set(suggestions);
} catch {
// Handle error silently
} finally {
this.loading.set(false);
}
}
setFilter(filter: 'all' | SuggestionStatus) {
this.statusFilter.set(filter);
this.currentPage.set(1); // Reset to first page when filter changes
}
onPageChange(page: number) {
this.currentPage.set(page);
}
onPageSizeChange(pageSize: number) {
this.pageSize.set(pageSize);
// Calculate new current page to stay on approximately the same content
const firstItemIndex = (this.currentPage() - 1) * this.pageSize();
const newPage = Math.floor(firstItemIndex / pageSize) + 1;
this.currentPage.set(newPage);
}
getStatusLabel(status: SuggestionStatus): string {
switch (status) {
case SuggestionStatus.unreviewed: return 'Pending Review';
case SuggestionStatus.accepted: return 'Accepted';
case SuggestionStatus.declined: return 'Declined';
}
}
getEntityIcon(entityType: SuggestionEntity): string {
switch (entityType) {
case SuggestionEntity.game: return '🎮';
case SuggestionEntity.book: return '📚';
case SuggestionEntity.music: return '🎵';
case SuggestionEntity.manga: return '📖';
case SuggestionEntity.show: return '📺';
case SuggestionEntity.art: return '🎨';
}
}
formatDate(date: Date | string): string {
return new Date(date).toLocaleDateString();
}
}