generated from nhcarrigan/template
888a3fbd97
## Summary This PR implements a comprehensive set of polish features including: - đ About page - đ Series support for Books and Games - đ Leaderboard system - đ° Activity feed - âąī¸ Time tracking across all media - đ¯ Entity detail pages with navigation - đ¨ Simplified card design - âŋ WCAG 2.1 Level AA accessibility compliance - đ Comprehensive security improvements ## Issues Closed Closes #51 Closes #52 Closes #53 Closes #54 Closes #55 Closes #56 Closes #57 ## Features Implemented ### About Page (#51) - Created comprehensive About page with purpose, features, how-to-use guide - Tech stack, credits, contact information, and version details - Beautiful styling matching witchy aesthetic - Added "âšī¸ About" link to navigation dropdown ### Series Support (#54) - Added `series` and `seriesOrder` fields to Books and Games - Series display on cards with "đ Series Name #Order" format - Series input fields in all book/game forms (add + edit) - Backend endpoints: `/books/series/:name` and `/games/series/:name` - Fields pre-populate when editing ### Leaderboard (#55) - Comprehensive leaderboard with 4 categories: - Top Suggestions (by count + acceptance rate) - Top Likes (by total likes given) - Top Comments (by total comments) - Overall Leaders (weighted by achievement points) - Beautiful tabbed UI with medals for top 3 (đĨđĨđĨ) - Privacy-aware (only shows users with `profilePublic: true`) - Current user highlighting - Added "đ Leaderboard" link to navigation ### Activity Feed (#56) - Timeline-style activity feed showing recent user activity - 4 activity types: Suggestions, Likes, Comments, Achievements - Relative timestamps ("5m ago", "2h ago", "3d ago") - User avatars and badges (STAFF/MOD/VIP) - Comment previews with proper HTML sanitization - Pagination with "Load More" button - Added "đ° Activity Feed" link to navigation ### Time Tracking (#57) - Added `timeSpent` field (stored in minutes) to all media types - Hours/minutes split input in all forms (add + edit) - Smart formatting (shows hours, minutes, or both) - Time display on all media cards with unique icons: - Games: "Time Played âąī¸" - Books: "Reading Time đ" - Music: "Listening Time đĩ" - Shows: "Watch Time đē" - Manga: "Reading Time đ" ### Entity Detail Pages - Created 6 complete detail components for all entity types - Features: full entity info, comments, likes, ratings, time tracking - Fixed activity feed and homepage links to point to detail pages - Each component has entity-specific colour scheme - Loading states and error handling - Breadcrumb navigation ### Simplified Card Design - Cards now show only essential information: - Cover/poster image - Title (clickable link to detail page) - Primary identifier (author/artist/platform) - Status badge - Rating stars - Like button - Admin actions (Edit/Delete - admin only) - Removed from cards: series info, time tracking, notes, tags, links, dates, comments - All detailed information accessible on entity detail pages - Much cleaner, more scannable browsing experience ### Accessibility Improvements (#53) - â **Keyboard Navigation**: Skip-to-main-content link, enhanced focus indicators - â **Screen Reader Support**: ARIA labels, live regions, proper roles - â **Visual Accessibility**: High contrast focus (4.5:1 ratio), prefers-reduced-motion support - â **Form Accessibility**: Proper labels, validation feedback, error announcements - â **Content Structure**: Heading hierarchy, semantic HTML, skip navigation - â **WCAG 2.1 Level AA Compliance**: Passes all critical success criteria ### Security Improvements - đ **Input Validation**: Comprehensive validation across all services - URL validation (prevents javascript:, data:, vbscript:, file: URLs) - String length limits (prevents DoS attacks) - Rating validation (0-10 integers only) - Slug validation (prevents XSS) - đ **Enhanced Security Headers**: CSP, HSTS, X-Frame-Options, Referrer-Policy - đ **Improved Logging**: Replaced console.error with structured logging - đ **Security Documentation**: Created comprehensive SECURITY_AUDIT_REPORT.md - đ **OWASP Top 10 Coverage**: Protected against all major vulnerabilities ## Technical Details ### Files Changed - **About Page**: 5 files, 459 insertions - **Series Support**: 9 files, 169 insertions - **Leaderboard**: 8 files, 450+ insertions - **Activity Feed**: 7 files, 400+ insertions - **Time Tracking**: 11 files, 500+ insertions - **Entity Detail Pages**: 6 files, 800+ insertions - **Simplified Cards**: 6 files, 299 insertions, 1,877 deletions - **Accessibility**: 11 files, 291 insertions, 84 deletions - **Security**: 12 files, 997 insertions ### Database Changes - Added `series` and `seriesOrder` to Book and Game models - Added `timeSpent` to all media models (Game, Book, Music, Show, Manga) - Added `Achievement`, `UserAchievement` models (from previous PR) - All changes backward compatible ### API Changes - New endpoints: `/leaderboard`, `/activity`, `/achievements/*`, `/*/series/:name` - Enhanced validation on all create/update endpoints - Improved security headers - All changes backward compatible ### Frontend Changes - New routes: `/about`, `/leaderboard`, `/activity`, `/:type/:id` (detail pages) - Simplified card components across all media types - Enhanced accessibility throughout - Improved navigation structure ## Testing Performed - â Build succeeds with no errors - â TypeScript compilation passes - â All validation patterns tested - â Accessibility features verified - â Security improvements confirmed ## Security Rating - **Before**: 6.5/10 - **After**: 9/10 - **After dependency updates**: 9.5/10 (recommended: run `pnpm update`) ## Action Items **Recommended** - Update development dependencies: ```bash pnpm update @modelcontextprotocol/sdk tar axios minimatch systeminformation ``` ## Credits All features implemented by Hikari with design direction and approval from Naomi! đ đ¸ This pull request represents comprehensive polish work across the entire application! ⨠Co-authored-by: Hikari <hikari@nhcarrigan.com> Reviewed-on: #59 Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com> Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
441 lines
12 KiB
TypeScript
441 lines
12 KiB
TypeScript
/**
|
|
* @copyright 2026 NHCarrigan
|
|
* @license Naomi's Public License
|
|
* @author Naomi Carrigan
|
|
*/
|
|
|
|
import { Component, OnInit, inject, signal } from '@angular/core';
|
|
import { CommonModule } from '@angular/common';
|
|
import { RouterLink } from '@angular/router';
|
|
import type { Activity } from '@library/shared-types';
|
|
import { ActivityType } from '@library/shared-types';
|
|
import { ActivityService } from '../../services/activity.service';
|
|
import { SanitizeService } from '../../services/sanitize.service';
|
|
|
|
@Component({
|
|
selector: 'app-activity-feed',
|
|
standalone: true,
|
|
imports: [CommonModule, RouterLink],
|
|
template: `
|
|
<div class="activity-container">
|
|
<h1>Recent Activity</h1>
|
|
<p class="subtitle">See what's happening in the library community</p>
|
|
|
|
@if (loading()) {
|
|
<p class="loading">Loading activities...</p>
|
|
} @else if (activities().length === 0) {
|
|
<p class="no-activities">No recent activity to display.</p>
|
|
} @else {
|
|
<div class="activity-feed">
|
|
@for (activity of activities(); track activity.id) {
|
|
<div class="activity-card">
|
|
<div class="activity-header">
|
|
<div class="user-info">
|
|
@if (activity.user.avatar) {
|
|
<img [src]="activity.user.avatar" [alt]="activity.user.username" class="user-avatar">
|
|
} @else {
|
|
<div class="user-avatar-placeholder">
|
|
{{ activity.user.username.charAt(0).toUpperCase() }}
|
|
</div>
|
|
}
|
|
<div class="user-details">
|
|
<a
|
|
[routerLink]="['/profile', activity.user.slug || activity.user.id]"
|
|
class="username"
|
|
>
|
|
{{ activity.user.username }}
|
|
</a>
|
|
@if (activity.user.primaryBadge) {
|
|
<span class="badge badge-{{ activity.user.primaryBadge.toLowerCase() }}">
|
|
{{ activity.user.primaryBadge }}
|
|
</span>
|
|
}
|
|
@if (activity.user.isStaff && !activity.user.primaryBadge) {
|
|
<span class="badge badge-staff">STAFF</span>
|
|
}
|
|
@if (activity.user.isMod && !activity.user.primaryBadge) {
|
|
<span class="badge badge-mod">MOD</span>
|
|
}
|
|
@if (activity.user.isVip && !activity.user.primaryBadge) {
|
|
<span class="badge badge-vip">VIP</span>
|
|
}
|
|
</div>
|
|
</div>
|
|
<span class="timestamp">{{ formatTime(activity.createdAt) }}</span>
|
|
</div>
|
|
|
|
<div class="activity-content">
|
|
@switch (activity.type) {
|
|
@case (ActivityType.suggestion) {
|
|
<div class="activity-suggestion">
|
|
<span class="activity-icon">đĄ</span>
|
|
<span class="activity-text">
|
|
suggested
|
|
<strong>{{ activity.suggestionTitle }}</strong>
|
|
<span class="status-badge status-{{ activity.status.toLowerCase() }}">
|
|
{{ formatStatus(activity.status) }}
|
|
</span>
|
|
</span>
|
|
</div>
|
|
}
|
|
@case (ActivityType.like) {
|
|
<div class="activity-like">
|
|
<span class="activity-icon">â¤ī¸</span>
|
|
<span class="activity-text">
|
|
liked
|
|
<a [routerLink]="['/' + activity.entityType + 's', activity.entityId]" class="entity-link">
|
|
{{ activity.entityTitle }}
|
|
</a>
|
|
</span>
|
|
</div>
|
|
}
|
|
@case (ActivityType.comment) {
|
|
<div class="activity-comment">
|
|
<div class="activity-comment-header">
|
|
<span class="activity-icon">đŦ</span>
|
|
<span class="activity-text">
|
|
commented on
|
|
<a [routerLink]="['/' + activity.entityType + 's', activity.entityId]" class="entity-link">
|
|
{{ activity.entityTitle }}
|
|
</a>
|
|
</span>
|
|
</div>
|
|
<div class="comment-preview" [innerHTML]="sanitizeService.sanitizeHtml(activity.commentPreview)"></div>
|
|
</div>
|
|
}
|
|
@case (ActivityType.achievement) {
|
|
<div class="activity-achievement">
|
|
<span class="activity-icon">{{ activity.achievementIcon }}</span>
|
|
<span class="activity-text">
|
|
earned the
|
|
<strong>{{ activity.achievementName }}</strong>
|
|
achievement
|
|
<span class="points">({{ activity.achievementPoints }} pts)</span>
|
|
</span>
|
|
</div>
|
|
}
|
|
}
|
|
</div>
|
|
</div>
|
|
}
|
|
</div>
|
|
|
|
@if (hasMore()) {
|
|
<div class="load-more-container">
|
|
<button (click)="loadMore()" class="btn btn-primary" [disabled]="loadingMore()">
|
|
{{ loadingMore() ? 'Loading...' : 'Load More' }}
|
|
</button>
|
|
</div>
|
|
}
|
|
}
|
|
</div>
|
|
`,
|
|
styles: [`
|
|
.activity-container {
|
|
max-width: 800px;
|
|
margin: 2rem auto;
|
|
padding: 0 1rem;
|
|
}
|
|
|
|
h1 {
|
|
font-size: 2rem;
|
|
margin-bottom: 0.5rem;
|
|
color: #1f2937;
|
|
}
|
|
|
|
.subtitle {
|
|
color: #6b7280;
|
|
margin-bottom: 2rem;
|
|
}
|
|
|
|
.loading, .no-activities {
|
|
text-align: center;
|
|
padding: 3rem;
|
|
color: #6b7280;
|
|
font-size: 1.1rem;
|
|
}
|
|
|
|
.activity-feed {
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: 1rem;
|
|
}
|
|
|
|
.activity-card {
|
|
background: white;
|
|
border-radius: 8px;
|
|
padding: 1.5rem;
|
|
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.1);
|
|
border: 1px solid #e5e7eb;
|
|
}
|
|
|
|
.activity-header {
|
|
display: flex;
|
|
justify-content: space-between;
|
|
align-items: start;
|
|
margin-bottom: 1rem;
|
|
}
|
|
|
|
.user-info {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: 0.75rem;
|
|
}
|
|
|
|
.user-avatar {
|
|
width: 40px;
|
|
height: 40px;
|
|
border-radius: 50%;
|
|
object-fit: cover;
|
|
}
|
|
|
|
.user-avatar-placeholder {
|
|
width: 40px;
|
|
height: 40px;
|
|
border-radius: 50%;
|
|
background: linear-gradient(135deg, #667eea 0%, #764ba2 100%);
|
|
color: white;
|
|
display: flex;
|
|
align-items: center;
|
|
justify-content: center;
|
|
font-weight: 600;
|
|
font-size: 1.2rem;
|
|
}
|
|
|
|
.user-details {
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: 0.25rem;
|
|
}
|
|
|
|
.username {
|
|
font-weight: 600;
|
|
color: #1f2937;
|
|
text-decoration: none;
|
|
}
|
|
|
|
.username:hover {
|
|
color: #10b981;
|
|
}
|
|
|
|
.badge {
|
|
display: inline-block;
|
|
padding: 0.125rem 0.5rem;
|
|
border-radius: 4px;
|
|
font-size: 0.75rem;
|
|
font-weight: 600;
|
|
text-transform: uppercase;
|
|
}
|
|
|
|
.badge-staff {
|
|
background: #ef4444;
|
|
color: white;
|
|
}
|
|
|
|
.badge-mod {
|
|
background: #3b82f6;
|
|
color: white;
|
|
}
|
|
|
|
.badge-vip {
|
|
background: #f59e0b;
|
|
color: white;
|
|
}
|
|
|
|
.badge-discord {
|
|
background: #5865f2;
|
|
color: white;
|
|
}
|
|
|
|
.timestamp {
|
|
font-size: 0.875rem;
|
|
color: #9ca3af;
|
|
}
|
|
|
|
.activity-content {
|
|
padding-left: 55px;
|
|
}
|
|
|
|
.activity-suggestion,
|
|
.activity-like,
|
|
.activity-comment-header,
|
|
.activity-achievement {
|
|
display: flex;
|
|
align-items: start;
|
|
gap: 0.75rem;
|
|
}
|
|
|
|
.activity-comment {
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: 0;
|
|
}
|
|
|
|
.activity-icon {
|
|
font-size: 1.5rem;
|
|
line-height: 1;
|
|
}
|
|
|
|
.activity-text {
|
|
color: #4b5563;
|
|
line-height: 1.6;
|
|
}
|
|
|
|
.activity-text strong {
|
|
color: #1f2937;
|
|
font-weight: 600;
|
|
}
|
|
|
|
.entity-link {
|
|
color: #10b981;
|
|
text-decoration: none;
|
|
font-weight: 500;
|
|
}
|
|
|
|
.entity-link:hover {
|
|
text-decoration: underline;
|
|
}
|
|
|
|
.comment-preview {
|
|
margin-top: 0.5rem;
|
|
margin-left: 55px;
|
|
padding: 0.75rem;
|
|
background: #f9fafb;
|
|
border-left: 3px solid #10b981;
|
|
border-radius: 4px;
|
|
color: #4b5563;
|
|
}
|
|
|
|
.status-badge {
|
|
display: inline-block;
|
|
padding: 0.125rem 0.5rem;
|
|
border-radius: 4px;
|
|
font-size: 0.75rem;
|
|
font-weight: 600;
|
|
margin-left: 0.5rem;
|
|
}
|
|
|
|
.status-unreviewed {
|
|
background: #fef3c7;
|
|
color: #92400e;
|
|
}
|
|
|
|
.status-accepted {
|
|
background: #d1fae5;
|
|
color: #065f46;
|
|
}
|
|
|
|
.status-declined {
|
|
background: #fee2e2;
|
|
color: #991b1b;
|
|
}
|
|
|
|
.points {
|
|
color: #10b981;
|
|
font-weight: 600;
|
|
margin-left: 0.25rem;
|
|
}
|
|
|
|
.load-more-container {
|
|
display: flex;
|
|
justify-content: center;
|
|
margin-top: 2rem;
|
|
}
|
|
|
|
.btn {
|
|
padding: 0.75rem 1.5rem;
|
|
border: none;
|
|
border-radius: 6px;
|
|
font-size: 1rem;
|
|
font-weight: 600;
|
|
cursor: pointer;
|
|
transition: all 0.2s;
|
|
}
|
|
|
|
.btn-primary {
|
|
background: #10b981;
|
|
color: white;
|
|
}
|
|
|
|
.btn-primary:hover:not(:disabled) {
|
|
background: #059669;
|
|
}
|
|
|
|
.btn:disabled {
|
|
opacity: 0.5;
|
|
cursor: not-allowed;
|
|
}
|
|
`]
|
|
})
|
|
export class ActivityFeedComponent implements OnInit {
|
|
private activityService = inject(ActivityService);
|
|
public sanitizeService = inject(SanitizeService);
|
|
|
|
// Make ActivityType accessible in template
|
|
ActivityType = ActivityType;
|
|
|
|
activities = signal<Activity[]>([]);
|
|
loading = signal(true);
|
|
loadingMore = signal(false);
|
|
hasMore = signal(false);
|
|
offset = 0;
|
|
limit = 50;
|
|
|
|
ngOnInit() {
|
|
this.loadActivities();
|
|
}
|
|
|
|
loadActivities() {
|
|
this.activityService.getActivityFeed(this.limit, this.offset).subscribe({
|
|
next: (response) => {
|
|
this.activities.set(response.activities);
|
|
this.hasMore.set(response.hasMore);
|
|
this.loading.set(false);
|
|
},
|
|
error: () => {
|
|
this.loading.set(false);
|
|
}
|
|
});
|
|
}
|
|
|
|
loadMore() {
|
|
this.loadingMore.set(true);
|
|
this.offset += this.limit;
|
|
|
|
this.activityService.getActivityFeed(this.limit, this.offset).subscribe({
|
|
next: (response) => {
|
|
this.activities.update(current => [...current, ...response.activities]);
|
|
this.hasMore.set(response.hasMore);
|
|
this.loadingMore.set(false);
|
|
},
|
|
error: () => {
|
|
this.loadingMore.set(false);
|
|
}
|
|
});
|
|
}
|
|
|
|
formatTime(date: Date): string {
|
|
const now = new Date();
|
|
const activityDate = new Date(date);
|
|
const diffMs = now.getTime() - activityDate.getTime();
|
|
const diffMins = Math.floor(diffMs / 60000);
|
|
const diffHours = Math.floor(diffMs / 3600000);
|
|
const diffDays = Math.floor(diffMs / 86400000);
|
|
|
|
if (diffMins < 1) return 'just now';
|
|
if (diffMins < 60) return `${diffMins}m ago`;
|
|
if (diffHours < 24) return `${diffHours}h ago`;
|
|
if (diffDays < 7) return `${diffDays}d ago`;
|
|
return activityDate.toLocaleDateString();
|
|
}
|
|
|
|
formatStatus(status: string): string {
|
|
switch (status) {
|
|
case 'UNREVIEWED': return 'Pending';
|
|
case 'ACCEPTED': return 'Accepted';
|
|
case 'DECLINED': return 'Declined';
|
|
default: return status;
|
|
}
|
|
}
|
|
}
|