generated from nhcarrigan/template
feat: multiple improvements to library functionality (#50)
## Summary This PR implements several improvements to the library application: - Added start and finish date tracking for media items - Added "Retired" category for abandoned media - Implemented avatar-based user menu with dropdown navigation - Added automatic background token refresh to prevent session expiry - Created centralised logging system with frontend-to-API log forwarding - Added toast notifications for error handling ## Changes ### Media Tracking (#41) - Added `dateStarted` and `dateFinished` fields to Books, Games, Manga, Music, and Shows - Updated TypeScript types, Prisma schema, and API services - Added manual date input fields to frontend forms - Properly converts HTML date strings to Date objects before API submission ### Retired Category (#43) - Added `RETIRED` status to all media type enums - Updated Prisma schema, frontend dropdowns, and filter buttons - Added status label handling for retired items ### User Menu (#46) - Replaced username text with avatar image in header - Created dropdown menu with navigation items (Users, Audit, Suggestions) - Added logout button to menu - Implemented keyboard accessibility (tabindex, role, keyup handlers) ### Token Refresh (#44) - Implemented automatic token refresh every 13 minutes in background - Added proactive refresh to prevent token expiry during form filling - Prevents users from losing form data due to expired sessions ### Centralised Logging (#1) - Created `/log` endpoint on API to receive frontend logs - Replaced API console.log calls with @nhcarrigan/logger - Created ConsoleLoggerService to intercept all console methods on frontend - Added global error handlers (window.error, unhandledrejection) on frontend - Added process error handlers (uncaughtException, unhandledRejection, SIGTERM, SIGINT) on API - All frontend console activity now forwarded to centralised logging ### Error Handling - Created ToastService and ToastComponent for displaying errors - Integrated with GlobalErrorHandler and HTTP interceptor - Added accessibility features (keyboard navigation, ARIA attributes) - Set toast opacity to 40% for optimal readability ### Testing & Build - Fixed pre-existing test failure for GET / route (now returns version info) - Added ESM module mocking (jsdom, marked, dompurify, @nhcarrigan/logger) - Configured Jest with isolatedModules to handle TypeScript errors - Excluded test-setup.ts from production build - All tests passing (123 total) - Build passing with no errors ## Test Plan - [x] All tests pass (123 tests) - [x] Build passes without errors - [x] Lint passes (only pre-existing warnings) - [x] Date fields work correctly on all media types - [x] Retired status displays and filters properly - [x] Avatar menu opens/closes correctly with keyboard and mouse - [x] Token refresh prevents session expiry - [x] Toast notifications appear for errors - [x] Frontend logs forward to API successfully - [x] Root route returns version information Closes #41 Closes #43 Closes #44 Closes #46 Closes #1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Hikari <hikari@nhcarrigan.com> Reviewed-on: #50 Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com> Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
This commit was merged in pull request #50.
This commit is contained in:
@@ -0,0 +1,201 @@
|
||||
/**
|
||||
* @copyright NHCarrigan
|
||||
* @license Naomi's Public License
|
||||
* @author Naomi Carrigan
|
||||
*/
|
||||
|
||||
import { MusicStatus, MusicType } from "../src/lib/music.types";
|
||||
import type { Music, CreateMusicDto, UpdateMusicDto } from "../src/lib/music.types";
|
||||
|
||||
describe("music Types", () => {
|
||||
describe("musicType enum", () => {
|
||||
it("should have the correct values", () => {
|
||||
expect(MusicType.album).toBe("ALBUM");
|
||||
expect(MusicType.single).toBe("SINGLE");
|
||||
expect(MusicType.ep).toBe("EP");
|
||||
});
|
||||
|
||||
it("should have all expected enum values", () => {
|
||||
const values = Object.values(MusicType);
|
||||
expect(values).toHaveLength(3);
|
||||
expect(values).toContain("ALBUM");
|
||||
expect(values).toContain("SINGLE");
|
||||
expect(values).toContain("EP");
|
||||
});
|
||||
});
|
||||
|
||||
describe("musicStatus enum", () => {
|
||||
it("should have the correct values", () => {
|
||||
expect(MusicStatus.listening).toBe("LISTENING");
|
||||
expect(MusicStatus.completed).toBe("COMPLETED");
|
||||
expect(MusicStatus.wantToListen).toBe("WANT_TO_LISTEN");
|
||||
});
|
||||
|
||||
it("should have all expected enum values", () => {
|
||||
const values = Object.values(MusicStatus);
|
||||
expect(values).toHaveLength(4);
|
||||
expect(values).toContain("LISTENING");
|
||||
expect(values).toContain("COMPLETED");
|
||||
expect(values).toContain("WANT_TO_LISTEN");
|
||||
expect(values).toContain("RETIRED");
|
||||
});
|
||||
});
|
||||
|
||||
describe("music interface", () => {
|
||||
it("should accept valid music object with minimal fields", () => {
|
||||
const music: Music = {
|
||||
artist: "Pink Floyd",
|
||||
createdAt: new Date("2024-01-15"),
|
||||
dateAdded: new Date("2024-01-15"),
|
||||
id: "music123",
|
||||
links: [],
|
||||
status: MusicStatus.listening,
|
||||
tags: [],
|
||||
title: "Dark Side of the Moon",
|
||||
type: MusicType.album,
|
||||
updatedAt: new Date("2024-01-16"),
|
||||
};
|
||||
|
||||
expect(music.dateCompleted).toBeUndefined();
|
||||
expect(music.rating).toBeUndefined();
|
||||
expect(music.notes).toBeUndefined();
|
||||
expect(music.coverArt).toBeUndefined();
|
||||
});
|
||||
|
||||
it("should accept valid music object with all fields", () => {
|
||||
const fullMusic: Music = {
|
||||
artist: "Pink Floyd",
|
||||
coverArt: "https://example.com/the-wall-cover.jpg",
|
||||
createdAt: new Date("2024-01-01"),
|
||||
dateAdded: new Date("2024-01-01"),
|
||||
dateCompleted: new Date("2024-01-20"),
|
||||
id: "music456",
|
||||
links: [
|
||||
{ title: "Spotify", url: "https://spotify.com/album/the-wall" },
|
||||
{ title: "Apple Music", url: "https://music.apple.com/album/the-wall" },
|
||||
],
|
||||
notes: "A rock opera masterpiece",
|
||||
rating: 5,
|
||||
status: MusicStatus.completed,
|
||||
tags: [ "progressive rock", "concept album", "classic" ],
|
||||
title: "The Wall",
|
||||
type: MusicType.album,
|
||||
updatedAt: new Date("2024-01-20"),
|
||||
};
|
||||
|
||||
expect(fullMusic.artist).toBe("Pink Floyd");
|
||||
expect(fullMusic.rating).toBe(5);
|
||||
expect(fullMusic.tags).toHaveLength(3);
|
||||
expect(fullMusic.links).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("should accept different music types", () => {
|
||||
const single: Music = {
|
||||
artist: "The Weeknd",
|
||||
createdAt: new Date("2024-02-01"),
|
||||
dateAdded: new Date("2024-02-01"),
|
||||
id: "music789",
|
||||
links: [],
|
||||
status: MusicStatus.completed,
|
||||
tags: [ "pop", "synthwave" ],
|
||||
title: "Blinding Lights",
|
||||
type: MusicType.single,
|
||||
updatedAt: new Date("2024-02-01"),
|
||||
};
|
||||
|
||||
const ep: Music = {
|
||||
artist: "The Weeknd",
|
||||
createdAt: new Date("2024-02-05"),
|
||||
dateAdded: new Date("2024-02-05"),
|
||||
id: "music999",
|
||||
links: [],
|
||||
status: MusicStatus.wantToListen,
|
||||
tags: [ "r&b", "dark" ],
|
||||
title: "My Dear Melancholy,",
|
||||
type: MusicType.ep,
|
||||
updatedAt: new Date("2024-02-05"),
|
||||
};
|
||||
|
||||
expect(single.type).toBe(MusicType.single);
|
||||
expect(ep.type).toBe(MusicType.ep);
|
||||
});
|
||||
});
|
||||
|
||||
describe("createMusicDto interface", () => {
|
||||
it("should accept DTO with required fields only", () => {
|
||||
const createDto: CreateMusicDto = {
|
||||
artist: "Fleetwood Mac",
|
||||
status: MusicStatus.wantToListen,
|
||||
title: "Rumours",
|
||||
type: MusicType.album,
|
||||
};
|
||||
|
||||
expect(createDto.rating).toBeUndefined();
|
||||
expect(createDto.notes).toBeUndefined();
|
||||
expect(createDto.coverArt).toBeUndefined();
|
||||
expect(createDto.tags).toBeUndefined();
|
||||
expect(createDto.links).toBeUndefined();
|
||||
});
|
||||
|
||||
it("should accept DTO with all fields", () => {
|
||||
const fullCreateDto: CreateMusicDto = {
|
||||
artist: "The Weeknd",
|
||||
coverArt: "https://example.com/after-hours.jpg",
|
||||
links: [ { title: "YouTube", url: "https://youtube.com/album/after-hours" } ],
|
||||
notes: "Dark synthwave vibes",
|
||||
rating: 4,
|
||||
status: MusicStatus.listening,
|
||||
tags: [ "synthwave", "pop", "r&b" ],
|
||||
title: "After Hours",
|
||||
type: MusicType.album,
|
||||
};
|
||||
|
||||
expect(fullCreateDto.artist).toBe("The Weeknd");
|
||||
expect(fullCreateDto.type).toBe(MusicType.album);
|
||||
expect(fullCreateDto.rating).toBe(4);
|
||||
expect(fullCreateDto.tags).toEqual([ "synthwave", "pop", "r&b" ]);
|
||||
expect(fullCreateDto.links).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
||||
describe("updateMusicDto type", () => {
|
||||
it("should accept empty update DTO", () => {
|
||||
const emptyUpdate: UpdateMusicDto = {};
|
||||
expect(emptyUpdate).toEqual({});
|
||||
});
|
||||
|
||||
it("should accept partial updates including dateCompleted", () => {
|
||||
const partialUpdate: UpdateMusicDto = {
|
||||
dateCompleted: new Date("2024-02-10"),
|
||||
rating: 5,
|
||||
status: MusicStatus.completed,
|
||||
};
|
||||
|
||||
expect(partialUpdate.status).toBe(MusicStatus.completed);
|
||||
expect(partialUpdate.dateCompleted).toEqual(new Date("2024-02-10"));
|
||||
expect(partialUpdate.rating).toBe(5);
|
||||
expect(partialUpdate.title).toBeUndefined();
|
||||
});
|
||||
|
||||
it("should accept full update", () => {
|
||||
const fullUpdate: UpdateMusicDto = {
|
||||
artist: "Different Artist",
|
||||
coverArt: "https://example.com/new-cover.jpg",
|
||||
dateCompleted: new Date("2024-02-15"),
|
||||
links: [ { title: "New Link", url: "https://newlink.com" } ],
|
||||
notes: "Updated after listening",
|
||||
rating: 3,
|
||||
status: MusicStatus.completed,
|
||||
tags: [ "updated", "tags" ],
|
||||
title: "Updated Album Title",
|
||||
type: MusicType.ep,
|
||||
};
|
||||
|
||||
expect(fullUpdate.title).toBe("Updated Album Title");
|
||||
expect(fullUpdate.artist).toBe("Different Artist");
|
||||
expect(fullUpdate.type).toBe(MusicType.ep);
|
||||
expect(fullUpdate.dateCompleted).toEqual(new Date("2024-02-15"));
|
||||
expect(fullUpdate.links).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user