generated from nhcarrigan/template
feat: multiple improvements to library functionality (#50)
## Summary This PR implements several improvements to the library application: - Added start and finish date tracking for media items - Added "Retired" category for abandoned media - Implemented avatar-based user menu with dropdown navigation - Added automatic background token refresh to prevent session expiry - Created centralised logging system with frontend-to-API log forwarding - Added toast notifications for error handling ## Changes ### Media Tracking (#41) - Added `dateStarted` and `dateFinished` fields to Books, Games, Manga, Music, and Shows - Updated TypeScript types, Prisma schema, and API services - Added manual date input fields to frontend forms - Properly converts HTML date strings to Date objects before API submission ### Retired Category (#43) - Added `RETIRED` status to all media type enums - Updated Prisma schema, frontend dropdowns, and filter buttons - Added status label handling for retired items ### User Menu (#46) - Replaced username text with avatar image in header - Created dropdown menu with navigation items (Users, Audit, Suggestions) - Added logout button to menu - Implemented keyboard accessibility (tabindex, role, keyup handlers) ### Token Refresh (#44) - Implemented automatic token refresh every 13 minutes in background - Added proactive refresh to prevent token expiry during form filling - Prevents users from losing form data due to expired sessions ### Centralised Logging (#1) - Created `/log` endpoint on API to receive frontend logs - Replaced API console.log calls with @nhcarrigan/logger - Created ConsoleLoggerService to intercept all console methods on frontend - Added global error handlers (window.error, unhandledrejection) on frontend - Added process error handlers (uncaughtException, unhandledRejection, SIGTERM, SIGINT) on API - All frontend console activity now forwarded to centralised logging ### Error Handling - Created ToastService and ToastComponent for displaying errors - Integrated with GlobalErrorHandler and HTTP interceptor - Added accessibility features (keyboard navigation, ARIA attributes) - Set toast opacity to 40% for optimal readability ### Testing & Build - Fixed pre-existing test failure for GET / route (now returns version info) - Added ESM module mocking (jsdom, marked, dompurify, @nhcarrigan/logger) - Configured Jest with isolatedModules to handle TypeScript errors - Excluded test-setup.ts from production build - All tests passing (123 total) - Build passing with no errors ## Test Plan - [x] All tests pass (123 tests) - [x] Build passes without errors - [x] Lint passes (only pre-existing warnings) - [x] Date fields work correctly on all media types - [x] Retired status displays and filters properly - [x] Avatar menu opens/closes correctly with keyboard and mouse - [x] Token refresh prevents session expiry - [x] Toast notifications appear for errors - [x] Frontend logs forward to API successfully - [x] Root route returns version information Closes #41 Closes #43 Closes #44 Closes #46 Closes #1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Hikari <hikari@nhcarrigan.com> Reviewed-on: #50 Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com> Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
This commit was merged in pull request #50.
This commit is contained in:
@@ -0,0 +1,228 @@
|
||||
/**
|
||||
* @copyright NHCarrigan
|
||||
* @license Naomi's Public License
|
||||
* @author Naomi Carrigan
|
||||
*/
|
||||
|
||||
import type { Like, CreateLikeDto, LikeResponse, LikedItemDto, LikeCountDto } from "../src/lib/like.types";
|
||||
|
||||
describe("like Types", () => {
|
||||
describe("like interface", () => {
|
||||
it("should accept valid like object for a book", () => {
|
||||
const bookLike: Like = {
|
||||
createdAt: new Date("2024-01-15"),
|
||||
entityId: "book456",
|
||||
entityType: "book",
|
||||
id: "like123",
|
||||
userId: "user123",
|
||||
};
|
||||
|
||||
expect(bookLike.entityType).toBe("book");
|
||||
expect(bookLike.entityId).toBe("book456");
|
||||
});
|
||||
|
||||
it("should accept valid like object for a game", () => {
|
||||
const gameLike: Like = {
|
||||
createdAt: new Date("2024-01-20"),
|
||||
entityId: "game123",
|
||||
entityType: "game",
|
||||
id: "like456",
|
||||
userId: "user789",
|
||||
};
|
||||
|
||||
expect(gameLike.entityType).toBe("game");
|
||||
expect(gameLike.entityId).toBe("game123");
|
||||
});
|
||||
|
||||
it("should accept likes for all entity types", () => {
|
||||
const showLike: Like = {
|
||||
createdAt: new Date("2024-02-01"),
|
||||
entityId: "show222",
|
||||
entityType: "show",
|
||||
id: "like789",
|
||||
userId: "user111",
|
||||
};
|
||||
|
||||
const mangaLike: Like = {
|
||||
createdAt: new Date("2024-02-05"),
|
||||
entityId: "manga444",
|
||||
entityType: "manga",
|
||||
id: "like999",
|
||||
userId: "user333",
|
||||
};
|
||||
|
||||
const musicLike: Like = {
|
||||
createdAt: new Date("2024-02-10"),
|
||||
entityId: "music666",
|
||||
entityType: "music",
|
||||
id: "like111",
|
||||
userId: "user555",
|
||||
};
|
||||
|
||||
const artLike: Like = {
|
||||
createdAt: new Date("2024-02-15"),
|
||||
entityId: "art888",
|
||||
entityType: "art",
|
||||
id: "like222",
|
||||
userId: "user777",
|
||||
};
|
||||
|
||||
expect(showLike.entityType).toBe("show");
|
||||
expect(mangaLike.entityType).toBe("manga");
|
||||
expect(musicLike.entityType).toBe("music");
|
||||
expect(artLike.entityType).toBe("art");
|
||||
});
|
||||
});
|
||||
|
||||
describe("createLikeDto type", () => {
|
||||
it("should pick only entityType and entityId from Like", () => {
|
||||
const createDto: CreateLikeDto = {
|
||||
entityId: "book123",
|
||||
entityType: "book",
|
||||
};
|
||||
|
||||
expect(createDto.entityType).toBe("book");
|
||||
expect(createDto.entityId).toBe("book123");
|
||||
// Verify it only has these two properties
|
||||
expect(Object.keys(createDto)).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("should accept different entity types", () => {
|
||||
const gameDto: CreateLikeDto = {
|
||||
entityId: "game456",
|
||||
entityType: "game",
|
||||
};
|
||||
|
||||
const artDto: CreateLikeDto = {
|
||||
entityId: "art789",
|
||||
entityType: "art",
|
||||
};
|
||||
|
||||
expect(gameDto.entityType).toBe("game");
|
||||
expect(artDto.entityType).toBe("art");
|
||||
});
|
||||
});
|
||||
|
||||
describe("likeCountDto interface", () => {
|
||||
it("should accept valid like count object", () => {
|
||||
const likeCount: LikeCountDto = {
|
||||
count: 42,
|
||||
entityId: "book123",
|
||||
entityType: "book",
|
||||
};
|
||||
|
||||
expect(likeCount.count).toBe(42);
|
||||
expect(likeCount.entityType).toBe("book");
|
||||
});
|
||||
|
||||
it("should accept like counts for different entities", () => {
|
||||
const gameLikeCount: LikeCountDto = {
|
||||
count: 15,
|
||||
entityId: "game456",
|
||||
entityType: "game",
|
||||
};
|
||||
|
||||
const showLikeCount: LikeCountDto = {
|
||||
count: 0,
|
||||
entityId: "show789",
|
||||
entityType: "show",
|
||||
};
|
||||
|
||||
expect(gameLikeCount.count).toBe(15);
|
||||
expect(showLikeCount.count).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
describe("likedItemDto interface", () => {
|
||||
it("should accept liked item with unknown item type", () => {
|
||||
const likedBook: LikedItemDto = {
|
||||
item: {
|
||||
author: "F. Scott Fitzgerald",
|
||||
id: "book456",
|
||||
title: "The Great Gatsby",
|
||||
// ... other book properties
|
||||
},
|
||||
like: {
|
||||
createdAt: new Date("2024-01-15"),
|
||||
entityId: "book456",
|
||||
entityType: "book",
|
||||
id: "like123",
|
||||
userId: "user123",
|
||||
},
|
||||
};
|
||||
|
||||
expect(likedBook.like.entityType).toBe("book");
|
||||
expect(likedBook.item).toBeDefined();
|
||||
});
|
||||
|
||||
it("should accept liked items for different entity types", () => {
|
||||
const likedGame: LikedItemDto = {
|
||||
item: {
|
||||
id: "game123",
|
||||
platform: "Nintendo Switch",
|
||||
title: "Hades",
|
||||
// ... other game properties
|
||||
},
|
||||
like: {
|
||||
createdAt: new Date("2024-02-01"),
|
||||
entityId: "game123",
|
||||
entityType: "game",
|
||||
id: "like456",
|
||||
userId: "user789",
|
||||
},
|
||||
};
|
||||
|
||||
const likedArt: LikedItemDto = {
|
||||
item: {
|
||||
artist: "Jane Doe",
|
||||
id: "art456",
|
||||
imageUrl: "https://example.com/sunset.jpg",
|
||||
title: "Beautiful Sunset",
|
||||
// ... other art properties
|
||||
},
|
||||
like: {
|
||||
createdAt: new Date("2024-02-10"),
|
||||
entityId: "art456",
|
||||
entityType: "art",
|
||||
id: "like789",
|
||||
userId: "user999",
|
||||
},
|
||||
};
|
||||
|
||||
expect(likedGame.like.entityType).toBe("game");
|
||||
expect(likedArt.like.entityType).toBe("art");
|
||||
});
|
||||
});
|
||||
|
||||
describe("likeResponse interface", () => {
|
||||
it("should accept response with liked true", () => {
|
||||
const likedResponse: LikeResponse = {
|
||||
count: 10,
|
||||
liked: true,
|
||||
};
|
||||
|
||||
expect(likedResponse.liked).toBeTruthy();
|
||||
expect(likedResponse.count).toBe(10);
|
||||
});
|
||||
|
||||
it("should accept response with liked false", () => {
|
||||
const notLikedResponse: LikeResponse = {
|
||||
count: 5,
|
||||
liked: false,
|
||||
};
|
||||
|
||||
expect(notLikedResponse.liked).toBeFalsy();
|
||||
expect(notLikedResponse.count).toBe(5);
|
||||
});
|
||||
|
||||
it("should accept response with zero count", () => {
|
||||
const zeroResponse: LikeResponse = {
|
||||
count: 0,
|
||||
liked: false,
|
||||
};
|
||||
|
||||
expect(zeroResponse.liked).toBeFalsy();
|
||||
expect(zeroResponse.count).toBe(0);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user