generated from nhcarrigan/template
feat: multiple improvements to library functionality (#50)
## Summary This PR implements several improvements to the library application: - Added start and finish date tracking for media items - Added "Retired" category for abandoned media - Implemented avatar-based user menu with dropdown navigation - Added automatic background token refresh to prevent session expiry - Created centralised logging system with frontend-to-API log forwarding - Added toast notifications for error handling ## Changes ### Media Tracking (#41) - Added `dateStarted` and `dateFinished` fields to Books, Games, Manga, Music, and Shows - Updated TypeScript types, Prisma schema, and API services - Added manual date input fields to frontend forms - Properly converts HTML date strings to Date objects before API submission ### Retired Category (#43) - Added `RETIRED` status to all media type enums - Updated Prisma schema, frontend dropdowns, and filter buttons - Added status label handling for retired items ### User Menu (#46) - Replaced username text with avatar image in header - Created dropdown menu with navigation items (Users, Audit, Suggestions) - Added logout button to menu - Implemented keyboard accessibility (tabindex, role, keyup handlers) ### Token Refresh (#44) - Implemented automatic token refresh every 13 minutes in background - Added proactive refresh to prevent token expiry during form filling - Prevents users from losing form data due to expired sessions ### Centralised Logging (#1) - Created `/log` endpoint on API to receive frontend logs - Replaced API console.log calls with @nhcarrigan/logger - Created ConsoleLoggerService to intercept all console methods on frontend - Added global error handlers (window.error, unhandledrejection) on frontend - Added process error handlers (uncaughtException, unhandledRejection, SIGTERM, SIGINT) on API - All frontend console activity now forwarded to centralised logging ### Error Handling - Created ToastService and ToastComponent for displaying errors - Integrated with GlobalErrorHandler and HTTP interceptor - Added accessibility features (keyboard navigation, ARIA attributes) - Set toast opacity to 40% for optimal readability ### Testing & Build - Fixed pre-existing test failure for GET / route (now returns version info) - Added ESM module mocking (jsdom, marked, dompurify, @nhcarrigan/logger) - Configured Jest with isolatedModules to handle TypeScript errors - Excluded test-setup.ts from production build - All tests passing (123 total) - Build passing with no errors ## Test Plan - [x] All tests pass (123 tests) - [x] Build passes without errors - [x] Lint passes (only pre-existing warnings) - [x] Date fields work correctly on all media types - [x] Retired status displays and filters properly - [x] Avatar menu opens/closes correctly with keyboard and mouse - [x] Token refresh prevents session expiry - [x] Toast notifications appear for errors - [x] Frontend logs forward to API successfully - [x] Root route returns version information Closes #41 Closes #43 Closes #44 Closes #46 Closes #1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Hikari <hikari@nhcarrigan.com> Reviewed-on: #50 Co-authored-by: Naomi Carrigan <commits@nhcarrigan.com> Co-committed-by: Naomi Carrigan <commits@nhcarrigan.com>
This commit was merged in pull request #50.
This commit is contained in:
@@ -0,0 +1,110 @@
|
||||
/**
|
||||
* @copyright NHCarrigan
|
||||
* @license Naomi's Public License
|
||||
* @author Naomi Carrigan
|
||||
*/
|
||||
|
||||
import type { Art, CreateArtDto, UpdateArtDto } from "../src/lib/art.types";
|
||||
|
||||
describe("art Types", () => {
|
||||
describe("art interface", () => {
|
||||
it("should accept valid art object with minimal fields", () => {
|
||||
const art: Art = {
|
||||
artist: "Jane Doe",
|
||||
createdAt: new Date(),
|
||||
dateAdded: new Date(),
|
||||
id: "art123",
|
||||
imageUrl: "https://example.com/sunset.jpg",
|
||||
links: [],
|
||||
tags: [],
|
||||
title: "Beautiful Sunset",
|
||||
updatedAt: new Date(),
|
||||
};
|
||||
|
||||
expect(art.description).toBeUndefined();
|
||||
expect(art.tags).toEqual([]);
|
||||
});
|
||||
|
||||
it("should accept valid art object with all fields", () => {
|
||||
const fullArt: Art = {
|
||||
artist: "John Smith",
|
||||
createdAt: new Date("2024-01-01"),
|
||||
dateAdded: new Date("2024-01-01"),
|
||||
description: "A breathtaking view of the mountains",
|
||||
id: "art456",
|
||||
imageUrl: "https://example.com/mountains.jpg",
|
||||
links: [
|
||||
{ title: "Artist Portfolio", url: "https://artist.com" },
|
||||
{ title: "Instagram", url: "https://instagram.com/artist" },
|
||||
],
|
||||
tags: [ "landscape", "nature", "mountains" ],
|
||||
title: "Mountain Landscape",
|
||||
updatedAt: new Date("2024-01-02"),
|
||||
};
|
||||
|
||||
expect(fullArt.description).toBe("A breathtaking view of the mountains");
|
||||
expect(fullArt.tags).toHaveLength(3);
|
||||
expect(fullArt.links).toHaveLength(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe("createArtDto interface", () => {
|
||||
it("should accept DTO with required fields only", () => {
|
||||
const createDto: CreateArtDto = {
|
||||
artist: "New Artist",
|
||||
imageUrl: "https://example.com/art.jpg",
|
||||
title: "New Artwork",
|
||||
};
|
||||
|
||||
expect(createDto.description).toBeUndefined();
|
||||
expect(createDto.tags).toBeUndefined();
|
||||
expect(createDto.links).toBeUndefined();
|
||||
});
|
||||
|
||||
it("should accept DTO with all fields", () => {
|
||||
const fullCreateDto: CreateArtDto = {
|
||||
artist: "Famous Artist",
|
||||
description: "Detailed description",
|
||||
imageUrl: "https://example.com/complete.jpg",
|
||||
links: [ { title: "Website", url: "https://website.com" } ],
|
||||
tags: [ "tag1", "tag2" ],
|
||||
title: "Complete Artwork",
|
||||
};
|
||||
|
||||
expect(fullCreateDto.tags).toEqual([ "tag1", "tag2" ]);
|
||||
expect(fullCreateDto.links).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
||||
describe("updateArtDto type", () => {
|
||||
it("should accept empty update DTO", () => {
|
||||
const emptyUpdate: UpdateArtDto = {};
|
||||
expect(emptyUpdate).toEqual({});
|
||||
});
|
||||
|
||||
it("should accept partial updates", () => {
|
||||
const partialUpdate: UpdateArtDto = {
|
||||
tags: [ "new-tag" ],
|
||||
title: "Updated Title",
|
||||
};
|
||||
|
||||
expect(partialUpdate.title).toBe("Updated Title");
|
||||
expect(partialUpdate.artist).toBeUndefined();
|
||||
expect(partialUpdate.tags).toEqual([ "new-tag" ]);
|
||||
});
|
||||
|
||||
it("should accept full update", () => {
|
||||
const fullUpdate: UpdateArtDto = {
|
||||
artist: "Different Artist",
|
||||
description: "New description",
|
||||
imageUrl: "https://example.com/new-image.jpg",
|
||||
links: [ { title: "New Link", url: "https://newlink.com" } ],
|
||||
tags: [ "updated", "tags" ],
|
||||
title: "Completely New Title",
|
||||
};
|
||||
|
||||
expect(fullUpdate.title).toBe("Completely New Title");
|
||||
expect(fullUpdate.links).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user