fix: resolve linting issues and add dropdown tabindex

Fixed ESLint error in header component:
- Added tabindex="-1" to dropdown menu for keyboard accessibility
- Ensures dropdown is focusable for screen readers

Auto-fixed formatting issues:
- Ran ESLint --fix to auto-correct stylistic issues
- Fixed key spacing in achievement constants
- Fixed object key ordering

Test Results:
- ✅ All 123 tests passing (1 API + 122 shared-types)
- ✅ Frontend linting passes
- ✅ Only non-critical warnings remain in e2e and shared-types

apps/frontend/src/app/components/header/header.component.ts

@@ -58,6 +58,7 @@ import { ApiService } from '../../services/api.service';
                   class="dropdown-menu"
                   role="menu"
                   aria-label="User menu"
+                  tabindex="-1"
                   (keydown.escape)="closeDropdown()"
                 >
                   <a [routerLink]="['/profile', user.slug || user.id]" class="dropdown-item" role="menuitem" (click)="closeDropdown()">My Profile</a>

shared-types/src/lib/achievement.types.ts

@@ -61,10 +61,10 @@ export interface AchievementProgress {
 export interface UserAchievementSummary {
   totalPoints:        number;
   totalEarned:        number;
-  recentAchievements: AchievementProgress[];
+  recentAchievements: Array<AchievementProgress>;
-  progressByCategory: {
+  progressByCategory: Array<{
     category: AchievementCategory;
     earned:   number;
     total:    number;
-  }[];
+  }>;
 }

shared-types/src/lib/activity.types.ts

@@ -62,7 +62,7 @@ interface AchievementActivity extends BaseActivity {
 type Activity = SuggestionActivity | LikeActivity | CommentActivity | AchievementActivity;
 
 interface ActivityFeedResponse {
-  activities: Activity[];
+  activities: Array<Activity>;
   total:      number;
   hasMore:    boolean;
 }

shared-types/src/lib/comment.types.ts

@@ -4,7 +4,7 @@
  * @author Naomi Carrigan
  */
 
-import { PrimaryBadge } from "./auth.types";
+import type { PrimaryBadge } from "./auth.types";
 
 interface CommentUser {
   id:            string;

shared-types/src/lib/leaderboard.types.ts

@@ -41,10 +41,10 @@ interface OverallLeaderboard extends LeaderboardUser {
 }
 
 interface LeaderboardResponse {
-  topSuggestions: SuggestionsLeaderboard[];
+  topSuggestions: Array<SuggestionsLeaderboard>;
-  topLikes: LikesLeaderboard[];
+  topLikes:       Array<LikesLeaderboard>;
-  topComments: CommentsLeaderboard[];
+  topComments:    Array<CommentsLeaderboard>;
-  topOverall: OverallLeaderboard[];
+  topOverall:     Array<OverallLeaderboard>;
 }
 
 export {