fix: resolve CSP and accessibility issues (#60)
Node.js CI / CI (push) Has been cancelled
Security Scan and Upload / Security & DefectDojo Upload (push) Has been cancelled

### Explanation

_No response_

### Issue

_No response_

### Attestations

- [ ] I have read and agree to the [Code of Conduct](https://docs.nhcarrigan.com/community/coc/)
- [ ] I have read and agree to the [Community Guidelines](https://docs.nhcarrigan.com/community/guide/).
- [ ] My contribution complies with the [Contributor Covenant](https://docs.nhcarrigan.com/dev/covenant/).

### Dependencies

- [ ] I have pinned the dependencies to a specific patch version.

### Style

- [ ] I have run the linter and resolved any errors.
- [ ] My pull request uses an appropriate title, matching the conventional commit standards.
- [ ] My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request.

### Tests

- [ ] My contribution adds new code, and I have added tests to cover it.
- [ ] My contribution modifies existing code, and I have updated the tests to reflect these changes.
- [ ] All new and existing tests pass locally with my changes.
- [ ] Code coverage remains at or above the configured threshold.

### Documentation

_No response_

### Versioning

_No response_

Co-authored-by: Hikari <hikari@nhcarrigan.com>
Reviewed-on: #60
This commit was merged in pull request #60.
This commit is contained in:
2026-02-20 02:12:11 -08:00
parent 888a3fbd97
commit 08795c620c
12 changed files with 463 additions and 376 deletions
+1 -1
View File
@@ -1,7 +1,7 @@
/**
* @copyright 2026 NHCarrigan
* @copyright 2026 NHCarrigan
* @license Naomi's Public License
* @author Naomi Carrigan
*/
import { getGreeting } from "../support/app.po";
+3 -2
View File
@@ -1,11 +1,12 @@
/**
* @copyright 2026 NHCarrigan
* @copyright 2026 NHCarrigan
* @license Naomi's Public License
* @author Naomi Carrigan
*/
/**
*
* Gets the greeting element from the page.
* @returns A Cypress chainable to the h1 element.
*/
export const getGreeting = (): Cypress.Chainable => {
return cy.get("h1");
+1 -1
View File
@@ -1,7 +1,7 @@
/**
* @copyright 2026 NHCarrigan
* @copyright 2026 NHCarrigan
* @license Naomi's Public License
* @author Naomi Carrigan
*/
/// <reference types="cypress" />
+1
View File
@@ -3,6 +3,7 @@
* @license Naomi's Public License
* @author Naomi Carrigan
*/
/* eslint-disable unicorn/prevent-abbreviations -- e2e is a standard Cypress filename */
/**
* This example support/e2e.ts is processed and
+1 -1
View File
@@ -1,4 +1,4 @@
<a href="#main-content" class="skip-link">Skip to main content</a>
<a href="#main-content" class="skip-link" (click)="skipToMainContent($event)">Skip to main content</a>
<app-header></app-header>
<main id="main-content" class="main-content" tabindex="-1">
<router-outlet></router-outlet>
+32
View File
@@ -1,3 +1,35 @@
// Skip to main content link - visually hidden but accessible to screen readers
.skip-link {
position: absolute !important;
width: 1px !important;
height: 1px !important;
padding: 0 !important;
margin: -1px !important;
overflow: hidden !important;
clip: rect(0, 0, 0, 0) !important;
white-space: nowrap !important;
border: 0 !important;
}
.skip-link:focus {
position: fixed !important;
top: 0 !important;
left: 0 !important;
width: auto !important;
height: auto !important;
padding: 0.75rem 1.5rem !important;
margin: 0 !important;
overflow: visible !important;
clip: auto !important;
white-space: normal !important;
background: var(--witch-rose) !important;
color: var(--witch-moon) !important;
text-decoration: none !important;
font-weight: 600 !important;
border-radius: 0 0 4px 0 !important;
z-index: 10000 !important;
}
.main-content {
min-height: calc(100vh - 60px); // Assuming header is ~60px
background-color: transparent; // Let the body background show through
+9
View File
@@ -18,4 +18,13 @@ export class App implements OnInit {
ngOnInit(): void {
this.analytics.initialise();
}
skipToMainContent(event: Event): void {
event.preventDefault();
const mainContent = document.getElementById('main-content');
if (mainContent) {
mainContent.focus();
mainContent.scrollIntoView({ behavior: 'smooth' });
}
}
}
+21 -8
View File
@@ -143,23 +143,36 @@ button {
background: var(--witch-plum);
}
// Skip to main content link
// Skip to main content link - visually hidden but accessible to screen readers
.skip-link {
position: absolute;
top: -40px;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
clip: rect(0, 0, 0, 0);
white-space: nowrap;
border: 0;
}
.skip-link:focus {
position: fixed;
top: 0;
left: 0;
width: auto;
height: auto;
padding: 0.75rem 1.5rem;
margin: 0;
overflow: visible;
clip: auto;
white-space: normal;
background: var(--witch-rose);
color: var(--witch-moon);
padding: 0.75rem 1.5rem;
text-decoration: none;
font-weight: 600;
border-radius: 0 0 4px 0;
z-index: 10000;
transition: top 0.3s;
}
.skip-link:focus {
top: 0;
}
// Enhanced focus styles for keyboard navigation