Files
hikari-desktop/src/lib/components/Markdown.test.ts
T
hikari 452fe185df
Security Scan and Upload / Security & DefectDojo Upload (push) Successful in 1m21s
CI / Lint & Test (push) Has started running
CI / Build Linux (push) Has been cancelled
CI / Build Windows (cross-compile) (push) Has been cancelled
feat: CLI v2.1.68–v2.1.74 compatibility updates (#221)
## Summary

This PR brings Hikari Desktop up to full compatibility with Claude Code CLI versions v2.1.68 through v2.1.74, implementing all changelog items audited in issues #200–#218.

## Changes

### Bug Fixes
- Remove deprecated Claude Opus 4.0 and 4.1 models from the model selector
- Auto-migrate users pinned to deprecated models to Opus 4.6

### New Features
- Add cron tool support (`CronCreate`, `CronDelete`, `CronList`) with character state mapping and `CLAUDE_CODE_DISABLE_CRON` settings toggle
- Handle `EnterWorktree` and `ExitWorktree` tools in character state mapping and tool display
- Add CLI update check with npm registry indicator in the version bar
- Add `agent_type` field and support the Agent tool rename from CLI v2.1.69
- Consume `worktree` field from status line hook events
- Display per-agent model override in the agent monitor tree
- Expose Claude Code CLI built-in slash commands (`/simplify`, `/loop`, `/batch`, `/memory`, `/context`) in the command menu with CLI badges
- Add `includeGitInstructions` toggle in settings
- Add `ENABLE_CLAUDEAI_MCP_SERVERS` opt-out setting
- Linkify MCP binary file paths (PDFs, audio, Office docs) in markdown output
- Add auto-memory panel, `/memory` slash command shortcut, and unified toast notification system
- Toast notifications for `WorktreeCreate` and `WorktreeRemove` hook events
- Sort session resume list by most recent activity, with most recent user message as preview
- Convert WSL Linux paths to Windows UNC paths when opening binary files via `open_binary_file` command
- Expose `autoMemoryDirectory` setting in ConfigSidebar (Agent Settings section)
- Add `/context` as a CLI built-in in the slash command menu
- Expose `modelOverrides` setting as a JSON textarea in ConfigSidebar (for AWS Bedrock, Google Vertex, etc.)

> **Note:** The CLI update check commit does not have a corresponding issue — it was a bonus addition during the audit sprint.

## Closes

Closes #200
Closes #201
Closes #202
Closes #205
Closes #206
Closes #207
Closes #208
Closes #209
Closes #210
Closes #211
Closes #212
Closes #213
Closes #214
Closes #215
Closes #216
Closes #217
Closes #218

Reviewed-on: #221
Co-authored-by: Hikari <hikari@nhcarrigan.com>
Co-committed-by: Hikari <hikari@nhcarrigan.com>
2026-03-13 01:34:44 -07:00

165 lines
6.0 KiB
TypeScript

/**
* Markdown Component Tests
*
* Tests the pure helper functions extracted from the Markdown component:
* - processSpoilers: wraps ||text|| syntax in spoiler spans, leaving code blocks untouched
* - highlightSearchMatches: injects <mark> tags for search terms, skipping code blocks
*
* Manual testing checklist:
* - [ ] Code blocks render with syntax highlighting and a copy button
* - [ ] ||spoiler text|| renders as a hidden span revealed on click
* - [ ] Search query highlights matching text in non-code content
* - [ ] Regular links open in the system browser via the Tauri opener
* - [ ] Binary file links invoke open_binary_file (WSL-path-aware) instead of openPath
*/
import { describe, it, expect } from "vitest";
// Mirror functions from Markdown.svelte for isolated testing
function processSpoilers(html: string): string {
const codeBlockPlaceholders: string[] = [];
let processed = html.replace(/<(pre|code)[^>]*>[\s\S]*?<\/\1>/gi, (match) => {
codeBlockPlaceholders.push(match);
return `__CODE_PLACEHOLDER_${codeBlockPlaceholders.length - 1}__`;
});
processed = processed.replace(
/\|\|(.+?)\|\|/g,
'<span class="spoiler" role="button" tabindex="0">$1</span>'
);
processed = processed.replace(/__CODE_PLACEHOLDER_(\d+)__/g, (_, index) => {
return codeBlockPlaceholders[parseInt(index)];
});
return processed;
}
function highlightSearchMatches(html: string, query: string): string {
if (!query) return html;
const codeBlockPlaceholders: string[] = [];
const tagPlaceholders: string[] = [];
let processed = html.replace(/<(pre|code)[^>]*>[\s\S]*?<\/\1>/gi, (match) => {
codeBlockPlaceholders.push(match);
return `__CODE_SEARCH_PLACEHOLDER_${codeBlockPlaceholders.length - 1}__`;
});
processed = processed.replace(/<[^>]+>/g, (match) => {
tagPlaceholders.push(match);
return `__TAG_PLACEHOLDER_${tagPlaceholders.length - 1}__`;
});
const escapedQuery = query.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
const regex = new RegExp(`(${escapedQuery})`, "gi");
processed = processed.replace(regex, '<mark class="search-highlight">$1</mark>');
processed = processed.replace(/__TAG_PLACEHOLDER_(\d+)__/g, (_, index) => {
return tagPlaceholders[parseInt(index)];
});
processed = processed.replace(/__CODE_SEARCH_PLACEHOLDER_(\d+)__/g, (_, index) => {
return codeBlockPlaceholders[parseInt(index)];
});
return processed;
}
// ---
describe("processSpoilers", () => {
it("wraps ||text|| in a spoiler span", () => {
const result = processSpoilers("<p>||secret||</p>");
expect(result).toContain('<span class="spoiler"');
expect(result).toContain("secret");
});
it("adds role=button and tabindex to spoiler spans", () => {
const result = processSpoilers("<p>||hidden||</p>");
expect(result).toContain('role="button"');
expect(result).toContain('tabindex="0"');
});
it("leaves content without spoiler markers unchanged", () => {
const html = "<p>Normal text here</p>";
expect(processSpoilers(html)).toBe(html);
});
it("handles multiple spoilers in the same string", () => {
const result = processSpoilers("<p>||a|| and ||b||</p>");
const matches = result.match(/class="spoiler"/g);
expect(matches).toHaveLength(2);
});
it("does not apply spoiler syntax inside code blocks", () => {
const html = "<pre><code>||not a spoiler||</code></pre>";
const result = processSpoilers(html);
expect(result).not.toContain('class="spoiler"');
expect(result).toContain("||not a spoiler||");
});
it("does not apply spoiler syntax inside inline code", () => {
const html = "<p>Example: <code>||inline||</code></p>";
const result = processSpoilers(html);
expect(result).not.toContain('class="spoiler"');
});
it("handles spoilers adjacent to code blocks correctly", () => {
const html = "<pre><code>code</code></pre><p>||revealed||</p>";
const result = processSpoilers(html);
expect(result).toContain('<span class="spoiler"');
expect(result).toContain("<pre><code>code</code></pre>");
});
});
describe("highlightSearchMatches", () => {
it("returns unchanged html when query is empty string", () => {
const html = "<p>hello world</p>";
expect(highlightSearchMatches(html, "")).toBe(html);
});
it("wraps matched text in a mark element", () => {
const result = highlightSearchMatches("<p>hello world</p>", "hello");
expect(result).toContain('<mark class="search-highlight">hello</mark>');
});
it("is case-insensitive", () => {
const result = highlightSearchMatches("<p>Hello World</p>", "hello");
expect(result).toContain('<mark class="search-highlight">Hello</mark>');
});
it("highlights all occurrences", () => {
const result = highlightSearchMatches("<p>cat and cat</p>", "cat");
const matches = result.match(/<mark class="search-highlight">/g);
expect(matches).toHaveLength(2);
});
it("does not highlight inside code blocks", () => {
const html = "<pre><code>hello inside code</code></pre>";
const result = highlightSearchMatches(html, "hello");
expect(result).not.toContain('<mark class="search-highlight">');
expect(result).toContain("hello inside code");
});
it("does not corrupt HTML tags", () => {
const result = highlightSearchMatches('<p class="foo">hello</p>', "hello");
expect(result).toContain('<p class="foo">');
expect(result).toContain('<mark class="search-highlight">hello</mark>');
});
it("escapes regex special characters in the query", () => {
const result = highlightSearchMatches("<p>price: $1.00</p>", "$1");
expect(result).toContain('<mark class="search-highlight">$1</mark>');
});
it("highlights text outside code blocks whilst leaving code intact", () => {
const html = "<pre><code>match here</code></pre><p>match here too</p>";
const result = highlightSearchMatches(html, "match");
expect(result).toContain("<pre><code>match here</code></pre>");
expect(result).toContain('<mark class="search-highlight">match</mark>');
});
});