nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

feat: add AskUserQuestion tool support #60

Merged
naomi merged 2 commits from feat/ask into main 2026-01-23 14:11:18 -08:00
Conversation 0 Commits 2 Files Changed 11
+497 -13
naomi commented 2026-01-23 12:58:26 -08:00
Owner
Copy Link
Copy Source

Summary

Implements support for Claude's AskUserQuestion tool, allowing Claude to ask the user questions with multiple choice options during a conversation.

Changes

  • Add UserQuestionEvent and QuestionOption types (Rust and TypeScript)
  • Detect AskUserQuestion in permission denials and emit claude:question event
  • Create UserQuestionModal component with option selection and custom answer input
  • Use stop/reconnect approach (same as PermissionModal) since Claude API doesn't accept tool_result for permission-denied tools
  • Add pendingQuestion to conversation store and hasQuestionPending derived store

Technical Notes

We discovered that Claude Code's permission denial system doesn't allow sending tool results back directly - the API rejects them with "unexpected tool_use_id found in tool_result blocks". The solution was to use the same stop/reconnect pattern that permissions use: stop the session, reconnect with context, and include the user's answer in the context restoration message.

Test Plan

  • Build compiles without errors (Rust + TypeScript)
  • Question modal appears when Claude uses AskUserQuestion
  • Can select options and submit answer
  • Answer is properly restored to Claude after reconnect

Closes #51

✨ This PR was created with help from Hikari~ 🌸

## Summary Implements support for Claude's `AskUserQuestion` tool, allowing Claude to ask the user questions with multiple choice options during a conversation. ## Changes - Add `UserQuestionEvent` and `QuestionOption` types (Rust and TypeScript) - Detect `AskUserQuestion` in permission denials and emit `claude:question` event - Create `UserQuestionModal` component with option selection and custom answer input - Use stop/reconnect approach (same as `PermissionModal`) since Claude API doesn't accept tool_result for permission-denied tools - Add `pendingQuestion` to conversation store and `hasQuestionPending` derived store ## Technical Notes We discovered that Claude Code's permission denial system doesn't allow sending tool results back directly - the API rejects them with "unexpected tool_use_id found in tool_result blocks". The solution was to use the same stop/reconnect pattern that permissions use: stop the session, reconnect with context, and include the user's answer in the context restoration message. ## Test Plan - [x] Build compiles without errors (Rust + TypeScript) - [x] Question modal appears when Claude uses `AskUserQuestion` - [x] Can select options and submit answer - [x] Answer is properly restored to Claude after reconnect Closes #51 --- ✨ This PR was created with help from Hikari~ 🌸
naomi added 1 commit 2026-01-23 12:58:26 -08:00
feat: add AskUserQuestion tool support
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 54s
Details
CI / Lint & Test (pull_request) Failing after 5m33s
Details
CI / Build Linux (pull_request) Has been skipped
Details
CI / Build Windows (cross-compile) (pull_request) Has been skipped
Details
fd80864bf1 
Implements support for Claude's AskUserQuestion tool, allowing Claude to ask
the user questions with multiple choice options during a conversation.

- Add UserQuestionEvent and QuestionOption types (Rust and TypeScript)
- Detect AskUserQuestion in permission denials and emit claude:question event
- Create UserQuestionModal component with option selection and custom answer
- Use stop/reconnect approach (same as PermissionModal) since Claude API
  doesn't accept tool_result for permission-denied tools
- Add pendingQuestion to conversation store and hasQuestionPending derived store

Closes #51
naomi added 1 commit 2026-01-23 13:13:01 -08:00
fix: lint and format issues in UserQuestionModal
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 56s
Details
CI / Lint & Test (pull_request) Successful in 14m20s
Details
CI / Build Linux (pull_request) Successful in 16m47s
Details
CI / Build Windows (cross-compile) (pull_request) Successful in 27m20s
Details
dafd1b4100
naomi merged commit 06810537a9 into main 2026-01-23 14:11:18 -08:00
naomi deleted branch feat/ask 2026-01-23 14:11:19 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#60
Delete Branch "feat/ask"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?