feat: batch of fixes and features #56

Merged

naomi merged 6 commits from feat/stuff into main 2026-01-23 11:59:22 -08:00

Conversation 0 Commits 6 Files Changed 10

+369 -5

hikari commented 2026-01-21 20:22:09 -08:00

Owner

Copy Link

Copy Source

Summary

This PR includes a batch of bug fixes and new features:

Bug Fixes

• Links in chat history now open in default browser instead of navigating within the app
  • Closes Links in chat history should open in user's default browser (#54)
• Allow spaces in tab names - space key no longer acts like enter when renaming tabs
  • Closes feat: Allow spaces in tab names (#52)

New Features

• /cd command - Change the working directory of an active tab with context preservation
  • Closes feat: Change working directory of active tab (#55)
• /search command - Search and highlight matches within the conversation
  • Closes feat: search within conversation (#32)

Test Plan

• Click a link in chat history and verify it opens in the default browser
• Rename a tab and verify spaces can be typed
• Use /cd <path> and verify the directory changes while preserving conversation context
• Use /search <query> and verify matches are highlighted in yellow
• Use /search with no args to clear the search highlighting

✨ This PR was created with help from Hikari~ 🌸

## Summary This PR includes a batch of bug fixes and new features: ### Bug Fixes - **Links in chat history now open in default browser** instead of navigating within the app - Closes #54 - **Allow spaces in tab names** - space key no longer acts like enter when renaming tabs - Closes #52 ### New Features - **`/cd` command** - Change the working directory of an active tab with context preservation - Closes #55 - **`/search` command** - Search and highlight matches within the conversation - Closes #32 ## Test Plan - [ ] Click a link in chat history and verify it opens in the default browser - [ ] Rename a tab and verify spaces can be typed - [ ] Use `/cd <path>` and verify the directory changes while preserving conversation context - [ ] Use `/search <query>` and verify matches are highlighted in yellow - [ ] Use `/search` with no args to clear the search highlighting ✨ This PR was created with help from Hikari~ 🌸

hikari added 4 commits 2026-01-21 20:22:09 -08:00

fix: open markdown links in user's default browser ... ab3f6700f6

Closes #54

fix: allow spaces in tab names ... b954158ea7

Closes #52

feat: add /cd command to change working directory 19ca7b7c6e

feat: add /search command to highlight matches in conversation ... 59c7652f3e

Closes #32

naomi added 1 commit 2026-01-22 10:02:39 -08:00

chore: format 52c0157a1a

naomi added 1 commit 2026-01-22 10:23:59 -08:00

fix: resolve XSS vulnerability in Terminal component search highlighting ... 6738cc2a62

- Created new HighlightedText component for safe text highlighting
- Replaced unsafe {@html} usage with component-based approach
- Maintains full search functionality without security risks

naomi merged commit 94991796be into main 2026-01-23 11:59:22 -08:00

naomi deleted branch feat/stuff 2026-01-23 11:59:22 -08:00

naomi referenced this issue from a commit 2026-01-23 11:59:23 -08:00

feat: batch of fixes and features (#56)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

aspect

code

Concerns the software code in the repository

aspect

dx

Concerns developers' experience with the codebase

aspect

interface

Concerns end-users' experience with the software

aspect

text

Concerns the documentation material in the repository

contribute

good first issue

A great opportunity for a team member to learn a new codebase

contribute

help wanted

Open for anyone on our team to grab.

contribute

staff only

Restricted to our executive leadership.

goal

addition

Addition of new feature

goal

fix

Bug fix

goal

improvement

Improvement to an existing feature

points

1

Very simple issue requiring minimal effort and complexity.

points

13

Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.

points

2

Simple issue that requires a bit more thought or investigation.

points

3

Moderate complexity issue requiring more substantial work.

points

5

Complex issue requiring significant effort and expertise.

points

8

Very complex issue requiring extensive work and deep expertise.

priority

critical

1

Must be fixed ASAP

priority

high

2

Stalls work on the project or its dependents

priority

low

4

Low priority and doesn't need to be rushed

priority

medium

3

Not blocking but should be fixed soon

priority

none

5

No priority, should only be performed when a developer is available

status

awaiting triage

Has not been triaged & therefore, not ready for work

status

blocked

Blocked and therefore not ready for work

status

discarded

Will not be worked on

status

discontinued

Not suitable for work as repo is in maintenance

status

label work required

Needs proper labelling before it can be worked on

status

ready for dev

Ready for work

status

ticket work required

Needs more details before it can be worked on

talk

discussion

Open for discussions and feedback

talk

question

Can be resolved with an answer

time

1 day

Approximately one full day of development work.

time

1-2 weeks

One to two weeks of focused development effort.

time

2-3 days

Two to three days of development effort.

time

4-5 days

Approximately one week of development work.

time

<1 day

Less than one day of focused work. Quick fixes or simple tasks.

time

>2 weeks

More than two weeks of development work. Must be broken down into smaller pieces.

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#56