nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

feat: consider exposing disableSkillShellExecution setting in config UI (v2.1.91) #259

New Issue
Closed
opened 2026-04-13 09:12:05 -07:00 by hikari · 1 comment
hikari commented 2026-04-13 09:12:05 -07:00
Owner
Copy Link
Copy Source

Context

Claude Code v2.1.91 added a new disableSkillShellExecution setting that prevents skills from executing shell commands. This is a security/safety toggle for users who want to restrict what skill scripts can do.

Why This Matters

Hikari Desktop already exposes several Claude Code settings via ConfigSidebar.svelte (model, API key, custom instructions, MCP servers, auto-granted tools, etc.). Adding disableSkillShellExecution would give users control over skill security without needing to manually edit their Claude config.

This is especially relevant for Hikari Desktop users who use the /skill slash command — they may want the extra safety boundary.

Tasks

  • Research what disableSkillShellExecution does exactly and whether it's a CLI flag, env var, or settings.json key
  • Decide whether to surface it as a toggle in ConfigSidebar.svelte
  • If yes: add the config key to HikariConfig in src/lib/stores/config.ts and pass it through in wsl_bridge.rs
  • Add tests for the new config option

References

  • Claude Code v2.1.91 changelog
  • src/lib/components/ConfigSidebar.svelte
  • src/lib/stores/config.ts
  • src-tauri/src/wsl_bridge.rs

✨ This issue was created with help from Hikari~ 🌸

## Context Claude Code v2.1.91 added a new `disableSkillShellExecution` setting that prevents skills from executing shell commands. This is a security/safety toggle for users who want to restrict what skill scripts can do. ## Why This Matters Hikari Desktop already exposes several Claude Code settings via `ConfigSidebar.svelte` (model, API key, custom instructions, MCP servers, auto-granted tools, etc.). Adding `disableSkillShellExecution` would give users control over skill security without needing to manually edit their Claude config. This is especially relevant for Hikari Desktop users who use the `/skill` slash command — they may want the extra safety boundary. ## Tasks - [ ] Research what `disableSkillShellExecution` does exactly and whether it's a CLI flag, env var, or settings.json key - [ ] Decide whether to surface it as a toggle in `ConfigSidebar.svelte` - [ ] If yes: add the config key to `HikariConfig` in `src/lib/stores/config.ts` and pass it through in `wsl_bridge.rs` - [ ] Add tests for the new config option ## References - Claude Code v2.1.91 changelog - `src/lib/components/ConfigSidebar.svelte` - `src/lib/stores/config.ts` - `src-tauri/src/wsl_bridge.rs` ✨ This issue was created with help from Hikari~ 🌸
hikari commented 2026-04-13 13:51:06 -07:00
Author
Owner
Copy Link
Copy Source

Resolved in PR #261. Added disable_skill_shell_execution to ClaudeStartOptions, HikariConfig, the --settings JSON block in wsl_bridge.rs, the TypeScript interface, and exposed a toggle in the Config Sidebar UI. Tests included. ✨

Resolved in PR #261. Added `disable_skill_shell_execution` to `ClaudeStartOptions`, `HikariConfig`, the `--settings` JSON block in `wsl_bridge.rs`, the TypeScript interface, and exposed a toggle in the Config Sidebar UI. Tests included. ✨
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?