nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

feat(tools): set up proper CI #2

Merged
naomi merged 10 commits from feat/tests into main 2026-01-15 20:06:48 -08:00
Conversation 0 Commits 10 Files Changed 80
+2689 -266
naomi commented 2026-01-15 10:46:17 -08:00
Owner
Copy Link
Copy Source

Explanation

No response

Issue

No response

Attestations

Dependencies

  • I have pinned the dependencies to a specific patch version.

Style

  • I have run the linter and resolved any errors.
  • My pull request uses an appropriate title, matching the conventional commit standards.
  • My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request.

Tests

  • My contribution adds new code, and I have added tests to cover it.
  • My contribution modifies existing code, and I have updated the tests to reflect these changes.
  • All new and existing tests pass locally with my changes.
  • Code coverage remains at or above the configured threshold.

Documentation

No response

Versioning

No response

### Explanation _No response_ ### Issue _No response_ ### Attestations - [ ] I have read and agree to the [Code of Conduct](https://docs.nhcarrigan.com/community/coc/) - [ ] I have read and agree to the [Community Guidelines](https://docs.nhcarrigan.com/community/guide/). - [ ] My contribution complies with the [Contributor Covenant](https://docs.nhcarrigan.com/dev/covenant/). ### Dependencies - [ ] I have pinned the dependencies to a specific patch version. ### Style - [ ] I have run the linter and resolved any errors. - [ ] My pull request uses an appropriate title, matching the conventional commit standards. - [ ] My scope of feat/fix/chore/etc. correctly matches the nature of changes in my pull request. ### Tests - [ ] My contribution adds new code, and I have added tests to cover it. - [ ] My contribution modifies existing code, and I have updated the tests to reflect these changes. - [ ] All new and existing tests pass locally with my changes. - [ ] Code coverage remains at or above the configured threshold. ### Documentation _No response_ ### Versioning _No response_
naomi added 1 commit 2026-01-15 10:46:17 -08:00
feat: start setting up CI
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 49s
Details
CI / Lint & Test (pull_request) Failing after 4m58s
Details
CI / Build Linux (pull_request) Has been skipped
Details
CI / Build Windows (cross-compile) (pull_request) Has been skipped
Details
1698735c47
naomi changed title from feat(tools): set up proper CI to WIP(tools): set up proper CI 2026-01-15 10:46:24 -08:00
naomi changed title from WIP(tools): set up proper CI to WIP: feat(tools): set up proper CI 2026-01-15 10:46:32 -08:00
naomi added 1 commit 2026-01-15 10:54:20 -08:00
fix: linting
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 48s
Details
CI / Lint & Test (pull_request) Failing after 5m8s
Details
CI / Build Linux (pull_request) Has been skipped
Details
CI / Build Windows (cross-compile) (pull_request) Has been skipped
Details
dbfd1f669d
naomi added 2 commits 2026-01-15 11:05:45 -08:00
chore: format 3abca03c2b
fix: tests
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 50s
Details
CI / Lint & Test (pull_request) Failing after 5m9s
Details
CI / Build Linux (pull_request) Has been skipped
Details
CI / Build Windows (cross-compile) (pull_request) Has been skipped
Details
51c8ff8a9f
naomi added 1 commit 2026-01-15 11:21:32 -08:00
chore: ignore pnpm cache
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 54s
Details
CI / Lint & Test (pull_request) Failing after 6m6s
Details
CI / Build Linux (pull_request) Has been skipped
Details
CI / Build Windows (cross-compile) (pull_request) Has been skipped
Details
c89679c09f
naomi added 1 commit 2026-01-15 11:31:26 -08:00
chore: more deps
CI / Lint & Test (pull_request) Failing after 11s
Details
CI / Build Linux (pull_request) Has been skipped
Details
CI / Build Windows (cross-compile) (pull_request) Has been skipped
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 49s
Details
51671945e6
naomi added 1 commit 2026-01-15 11:35:19 -08:00
fix: package conflict
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 52s
Details
CI / Lint & Test (pull_request) Successful in 14m4s
Details
CI / Build Windows (cross-compile) (pull_request) Failing after 6m11s
Details
CI / Build Linux (pull_request) Failing after 9m17s
Details
4629767ce4
naomi added 1 commit 2026-01-15 13:03:30 -08:00
fix: build pipelines
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 52s
Details
CI / Lint & Test (pull_request) Successful in 14m1s
Details
CI / Build Linux (pull_request) Successful in 16m20s
Details
CI / Build Windows (cross-compile) (pull_request) Failing after 20m26s
Details
44cc7ef542
naomi added 1 commit 2026-01-15 16:38:23 -08:00
chore: regenerate icon?
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 57s
Details
CI / Lint & Test (pull_request) Successful in 13m58s
Details
CI / Build Linux (pull_request) Successful in 16m13s
Details
CI / Build Windows (cross-compile) (pull_request) Failing after 20m53s
Details
b14d377d53
naomi added 1 commit 2026-01-15 17:22:05 -08:00
chore: add nsis?
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 54s
Details
CI / Lint & Test (pull_request) Successful in 14m13s
Details
CI / Build Linux (pull_request) Successful in 16m29s
Details
CI / Build Windows (cross-compile) (pull_request) Successful in 26m13s
Details
d4e9ea5e6b
naomi marked the pull request as ready for review 2026-01-15 20:06:41 -08:00
naomi merged commit c241544743 into main 2026-01-15 20:06:48 -08:00
naomi deleted branch feat/tests 2026-01-15 20:06:48 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#2
Delete Branch "feat/tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?