nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

fix: prevent notification sound from replaying on tab switch #172

New Issue
Closed
opened 2026-02-26 20:30:22 -08:00 by hikari · 0 comments
hikari commented 2026-02-26 20:30:22 -08:00
Owner
Copy Link
Copy Source

Bug Report

Description

When switching back to a tab whose task completed earlier (and whose completion sound already played and was acknowledged), the "task complete" notification sound fires again.

Steps to Reproduce

  1. Start a task in a tab
  2. Switch to a different tab whilst the first task runs
  3. The first task completes (sound plays, notification shown)
  4. Switch back to the first tab
  5. The completion sound plays again, despite the task having finished some time ago

Expected Behaviour

The completion sound should play exactly once — when the task first finishes. Returning to an already-finished tab should be silent.

Actual Behaviour

The completion sound replays every time the user switches back to a tab that previously completed.

Likely Cause

The notification/sound trigger is probably tied to the tab becoming active (focus/visibility event) rather than being one-shot on task completion. The "finished" state needs a flag to track whether the sound has already played, so it is not re-triggered on subsequent tab switches.

Suggested Fix

Add a boolean flag (e.g. soundPlayed or notificationFired) to each tab's state. Set it to true the first time the completion sound fires, and guard future sound triggers behind a check for that flag.

✨ This issue was created with help from Hikari~ 🌸

## Bug Report ### Description When switching back to a tab whose task completed earlier (and whose completion sound already played and was acknowledged), the "task complete" notification sound fires again. ### Steps to Reproduce 1. Start a task in a tab 2. Switch to a different tab whilst the first task runs 3. The first task completes (sound plays, notification shown) 4. Switch back to the first tab 5. The completion sound plays again, despite the task having finished some time ago ### Expected Behaviour The completion sound should play **exactly once** — when the task first finishes. Returning to an already-finished tab should be silent. ### Actual Behaviour The completion sound replays every time the user switches back to a tab that previously completed. ### Likely Cause The notification/sound trigger is probably tied to the tab becoming active (focus/visibility event) rather than being one-shot on task completion. The "finished" state needs a flag to track whether the sound has already played, so it is not re-triggered on subsequent tab switches. ### Suggested Fix Add a boolean flag (e.g. `soundPlayed` or `notificationFired`) to each tab's state. Set it to `true` the first time the completion sound fires, and guard future sound triggers behind a check for that flag. ✨ This issue was created with help from Hikari~ 🌸
naomi closed this issue 2026-02-26 23:34:51 -08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?