nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

fix: shell command execution briefly flashes a terminal window on Windows #165

New Issue
Closed
opened 2026-02-25 10:29:13 -08:00 by hikari · 0 comments
hikari commented 2026-02-25 10:29:13 -08:00
Owner
Copy Link
Copy Source

Description

Several features — including desktop notifications, MCP server list fetching, and opening files in the system editor — briefly flash a terminal/command prompt window before it immediately disappears. This is visually jarring and looks broken to users.

Affected Features

  • Desktop notifications (likely via PowerShell on Windows)
  • MCP server list operations
  • Opening files externally

Root Cause

On Windows, spawning a child process via std::process::Command defaults to creating a visible console window. The fix is to pass the CREATE_NO_WINDOW creation flag when spawning processes on Windows, which suppresses the console window entirely.

Proposed Fix

Use the windows crate or raw PROCESS_CREATION_FLAGS to set CREATE_NO_WINDOW (value 0x08000000) when building commands on Windows:

#[cfg(windows)]
{
    use std::os::windows::process::CommandExt;
    command.creation_flags(0x08000000); // CREATE_NO_WINDOW
}

This should be applied to all Command::new(...) spawns that are not expected to have user-visible terminal output.

✨ This issue was created with help from Hikari~ 🌸

## Description Several features — including desktop notifications, MCP server list fetching, and opening files in the system editor — briefly flash a terminal/command prompt window before it immediately disappears. This is visually jarring and looks broken to users. ## Affected Features - Desktop notifications (likely via PowerShell on Windows) - MCP server list operations - Opening files externally ## Root Cause On Windows, spawning a child process via `std::process::Command` defaults to creating a visible console window. The fix is to pass the `CREATE_NO_WINDOW` creation flag when spawning processes on Windows, which suppresses the console window entirely. ## Proposed Fix Use the `windows` crate or raw `PROCESS_CREATION_FLAGS` to set `CREATE_NO_WINDOW` (value `0x08000000`) when building commands on Windows: ```rust #[cfg(windows)] { use std::os::windows::process::CommandExt; command.creation_flags(0x08000000); // CREATE_NO_WINDOW } ``` This should be applied to all `Command::new(...)` spawns that are not expected to have user-visible terminal output. ✨ This issue was created with help from Hikari~ 🌸
naomi closed this issue 2026-02-25 22:55:48 -08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?