nhcarrigan/hikari-desktop
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 9 Pull Requests 36 Actions Releases 22 Activity

fix: memory files tab empty on Windows #140

Merged
naomi merged 2 commits from fix/memory-files-windows into main 2026-02-08 13:51:10 -08:00
Conversation 0 Commits 2 Files Changed 3
+52 -3
hikari commented 2026-02-08 13:06:29 -08:00
Owner
Copy Link
Copy Source

Summary

Fixes the memory files tab showing as empty on Windows production builds and the "forbidden path" error when trying to read memory files.

Changes

1. List memory files from WSL home directory (commit 1)

  • Split list_memory_files() into platform-specific implementations
  • Windows: Use WSL command with bash -l to find memory files in WSL home (~/.claude/projects/.../memory/)
  • Linux/Mac: Continue using native filesystem access
  • Previously used dirs::home_dir() which returns Windows home (C:\Users\...), but Claude Code stores files in WSL home

2. Use backend command for reading files (commit 2)

  • Changed frontend from Tauri's readTextFile plugin to read_file_content backend command
  • Tauri plugin enforces scope restrictions and can't access WSL paths on Windows
  • Our backend command already handles WSL paths correctly via read_file_via_wsl()
  • Matches the pattern used throughout the app for other file operations

Testing

  • ✅ All 426 backend tests pass
  • ✅ All frontend tests pass
  • ✅ Lint, format, and type checks pass
  • ✅ Follows existing WSL file operation patterns in codebase

Related Issues

Fixes the memory files tab functionality on Windows whilst maintaining full compatibility with Linux/Mac.

✨ This PR was created by Hikari~ 🌸

## Summary Fixes the memory files tab showing as empty on Windows production builds and the "forbidden path" error when trying to read memory files. ## Changes ### 1. List memory files from WSL home directory (commit 1) - Split `list_memory_files()` into platform-specific implementations - **Windows**: Use WSL command with `bash -l` to find memory files in WSL home (`~/.claude/projects/.../memory/`) - **Linux/Mac**: Continue using native filesystem access - Previously used `dirs::home_dir()` which returns Windows home (`C:\Users\...`), but Claude Code stores files in WSL home ### 2. Use backend command for reading files (commit 2) - Changed frontend from Tauri's `readTextFile` plugin to `read_file_content` backend command - Tauri plugin enforces scope restrictions and can't access WSL paths on Windows - Our backend command already handles WSL paths correctly via `read_file_via_wsl()` - Matches the pattern used throughout the app for other file operations ## Testing - ✅ All 426 backend tests pass - ✅ All frontend tests pass - ✅ Lint, format, and type checks pass - ✅ Follows existing WSL file operation patterns in codebase ## Related Issues Fixes the memory files tab functionality on Windows whilst maintaining full compatibility with Linux/Mac. ✨ This PR was created by Hikari~ 🌸
hikari added 2 commits 2026-02-08 13:06:29 -08:00
fix: list memory files from WSL home directory on Windows bd5d7685d8 
The memory files tab was empty on Windows production builds because
`list_memory_files()` was using `dirs::home_dir()` which returns the
Windows home directory (C:\Users\...), but Claude Code stores memory
files in the WSL home directory (~/.claude/projects/.../memory/).

Solution:
- Split into platform-specific implementations
- Windows: Use WSL command to find and list memory files in WSL home
- Linux/Mac: Continue using native filesystem access
- Use `bash -l` to ensure proper PATH and home directory resolution

This matches the pattern used for other file operations throughout
the codebase (read_file, write_file, list_directory, etc.).

Fixes empty memory files tab on Windows whilst maintaining full
functionality on Linux/Mac.

✨ This fix was created by Hikari~ 🌸
fix: use backend command to read memory files for WSL compatibility
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m23s
Details
CI / Lint & Test (pull_request) Successful in 20m3s
Details
CI / Build Linux (pull_request) Successful in 24m6s
Details
CI / Build Windows (cross-compile) (pull_request) Successful in 34m8s
Details
6f7544c8b3 
The frontend was using Tauri's `readTextFile` plugin which enforces
scope restrictions and doesn't work with WSL paths on Windows.

Changed to use our `read_file_content` backend command which:
- Already handles WSL paths correctly on Windows
- Works with absolute paths on all platforms
- Bypasses Tauri's filesystem scope restrictions
- Matches the pattern used throughout the app for file operations

This fixes the "forbidden path" error when trying to read memory
files on Windows whilst maintaining functionality on Linux/Mac.

✨ This fix was created by Hikari~ 🌸
naomi merged commit 778e016bf5 into main 2026-02-08 13:51:10 -08:00
naomi deleted branch fix/memory-files-windows 2026-02-08 13:51:10 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/hikari-desktop#140
Delete Branch "fix/memory-files-windows"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?