feat: new drafts feature and sound spam fix (#174)
Security Scan and Upload / Security & DefectDojo Upload (push) Successful in 58s
CI / Build Linux (push) Has been cancelled
CI / Build Windows (cross-compile) (push) Has been cancelled
CI / Lint & Test (push) Has been cancelled

## Summary

- **Saved Drafts feature**: Users can now save input content as drafts for later use, and manage them from a new panel
- **Sound spam fix**: The "Working on it!" sound no longer plays repeatedly when Claude makes multiple tool calls in a row

## Details

### Drafts feature
- Rust backend (`drafts.rs`) with `list_drafts`, `save_draft`, `delete_draft`, and `delete_all_drafts` commands, persisted to `hikari-drafts.json` via the Tauri Store plugin
- `draftsStore` wrapping all four commands with timestamp formatting
- `DraftPanel` overlay with insert, per-item two-step delete confirmation, delete-all with confirmation, empty state, and slide-in animation
- **Drafts** button in the top control row (pencil icon)
- **Save as Draft** floppy-disk icon button in the button wrapper (disabled when input is empty)

### Sound spam fix
- Root cause: `resetSoundState` was called on **every** `thinking` state transition, including mid-task transitions (`coding → thinking → coding`)
- Fix: only reset sound state when entering `thinking` from a clean-slate state (`idle`, `success`, or `error`) — states that genuinely mark the end of one task and the start of a new one

## Test plan
- [ ] Save a draft and verify it persists across app restarts
- [ ] Insert a draft and verify it populates the input
- [ ] Delete individual drafts and verify delete-all works
- [ ] Verify "Working on it!" plays once per user message regardless of how many tools are called

 This PR was created with help from Hikari~ 🌸

Reviewed-on: #174
Co-authored-by: Hikari <hikari@nhcarrigan.com>
Co-committed-by: Hikari <hikari@nhcarrigan.com>
This commit was merged in pull request #174.
This commit is contained in:
2026-02-27 15:07:10 -08:00
committed by Naomi Carrigan
parent fe7027c585
commit 7ebd9dc97a
8 changed files with 807 additions and 4 deletions
+232
View File
@@ -0,0 +1,232 @@
<script lang="ts">
import { onMount } from "svelte";
import { draftsStore, type Draft } from "$lib/stores/drafts";
interface Props {
onClose: () => void;
onInsert: (content: string) => void;
}
const { onClose, onInsert }: Props = $props();
let confirmingDeleteId = $state<string | null>(null);
let confirmingAll = $state(false);
const drafts = $derived(draftsStore.drafts);
const isLoading = $derived(draftsStore.isLoading);
onMount(() => {
draftsStore.loadDrafts();
});
function handleInsert(draft: Draft): void {
onInsert(draft.content);
onClose();
}
async function handleDelete(draftId: string): Promise<void> {
await draftsStore.deleteDraft(draftId);
confirmingDeleteId = null;
}
async function handleDeleteAll(): Promise<void> {
await draftsStore.deleteAllDrafts();
confirmingAll = false;
}
function truncateContent(content: string): string {
return content.length > 120 ? content.slice(0, 120) + "…" : content;
}
</script>
<div
class="fixed inset-0 bg-black/50 backdrop-blur-sm z-50 flex items-center justify-center p-4"
onclick={onClose}
role="button"
tabindex="0"
onkeydown={(e) => e.key === "Escape" && onClose()}
>
<div
class="bg-[var(--bg-primary)] border border-[var(--border-color)] rounded-lg shadow-xl max-w-2xl w-full max-h-[80vh] overflow-hidden flex flex-col"
onclick={(e) => e.stopPropagation()}
onkeydown={(e) => e.stopPropagation()}
role="dialog"
aria-labelledby="draft-panel-title"
tabindex="-1"
>
<div class="flex items-center justify-between p-6 pb-4 border-b border-[var(--border-color)]">
<h2 id="draft-panel-title" class="text-xl font-semibold text-[var(--text-primary)]">
Saved Drafts
</h2>
<div class="flex items-center gap-2">
{#if $drafts.length > 0}
{#if confirmingAll}
<div class="flex items-center gap-1">
<button
onclick={handleDeleteAll}
class="px-3 py-1.5 text-sm font-medium bg-red-500 text-white rounded-lg hover:bg-red-600 transition-colors"
>
Confirm Delete All
</button>
<button
onclick={() => (confirmingAll = false)}
class="px-3 py-1.5 text-sm font-medium bg-[var(--bg-secondary)] text-[var(--text-secondary)] rounded-lg hover:bg-[var(--bg-tertiary)] transition-colors"
>
Cancel
</button>
</div>
{:else}
<button
onclick={() => (confirmingAll = true)}
class="px-3 py-1.5 text-sm font-medium text-red-400 hover:text-red-300 transition-colors border border-red-400/30 rounded-lg hover:border-red-300/50 hover:bg-red-400/10"
>
Delete All
</button>
{/if}
{/if}
<button
onclick={onClose}
class="p-1 text-[var(--text-secondary)] hover:text-[var(--text-primary)] transition-colors"
aria-label="Close"
>
<svg class="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path
stroke-linecap="round"
stroke-linejoin="round"
stroke-width="2"
d="M6 18L18 6M6 6l12 12"
/>
</svg>
</button>
</div>
</div>
<div class="flex-1 overflow-y-auto">
{#if $isLoading}
<div class="flex items-center justify-center p-8">
<div class="text-[var(--text-tertiary)]">Loading drafts...</div>
</div>
{:else if $drafts.length === 0}
<div class="flex flex-col items-center justify-center p-8 text-center">
<svg
class="w-16 h-16 text-[var(--text-tertiary)] mb-4"
fill="none"
stroke="currentColor"
viewBox="0 0 24 24"
>
<path
stroke-linecap="round"
stroke-linejoin="round"
stroke-width="1.5"
d="M11 5H6a2 2 0 00-2 2v11a2 2 0 002 2h11a2 2 0 002-2v-5m-1.414-9.414a2 2 0 112.828 2.828L11.828 15H9v-2.828l8.586-8.586z"
/>
</svg>
<p class="text-[var(--text-secondary)]">No saved drafts yet</p>
<p class="text-sm text-[var(--text-tertiary)] mt-1">
Use "Save as Draft" to store messages for later
</p>
</div>
{:else}
<div class="divide-y divide-[var(--border-color)]">
{#each $drafts as draft (draft.id)}
<div class="p-4 hover:bg-[var(--bg-secondary)] transition-colors group">
<div class="flex items-start justify-between gap-4">
<div class="flex-1 min-w-0">
<p class="text-xs text-[var(--text-tertiary)] mb-1">
{draftsStore.formatTimestamp(draft.saved_at)}
</p>
<p
class="text-sm text-[var(--text-secondary)] font-mono whitespace-pre-wrap break-words"
>
{truncateContent(draft.content)}
</p>
</div>
<div
class="flex items-center gap-2 opacity-0 group-hover:opacity-100 transition-opacity flex-shrink-0"
>
<button
onclick={() => handleInsert(draft)}
class="btn-trans-gradient px-3 py-1.5 text-xs font-medium rounded"
title="Insert this draft"
>
Insert
</button>
{#if confirmingDeleteId === draft.id}
<div class="flex items-center gap-1">
<button
onclick={() => handleDelete(draft.id)}
class="px-2 py-1 text-xs font-medium bg-red-500 text-white rounded hover:bg-red-600 transition-colors"
>
Confirm
</button>
<button
onclick={() => (confirmingDeleteId = null)}
class="px-2 py-1 text-xs font-medium bg-[var(--bg-tertiary)] text-[var(--text-secondary)] rounded hover:bg-[var(--bg-secondary)] transition-colors"
>
Cancel
</button>
</div>
{:else}
<button
onclick={() => (confirmingDeleteId = draft.id)}
class="p-1.5 text-[var(--text-tertiary)] hover:text-red-400 transition-colors"
title="Delete draft"
>
<svg class="w-4 h-4" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path
stroke-linecap="round"
stroke-linejoin="round"
stroke-width="2"
d="M19 7l-.867 12.142A2 2 0 0116.138 21H7.862a2 2 0 01-1.995-1.858L5 7m5 4v6m4-6v6m1-10V4a1 1 0 00-1-1h-4a1 1 0 00-1 1v3M4 7h16"
/>
</svg>
</button>
{/if}
</div>
</div>
</div>
{/each}
</div>
{/if}
</div>
</div>
</div>
<style>
[role="dialog"] {
animation: slideIn 0.2s ease-out;
}
@keyframes slideIn {
from {
opacity: 0;
transform: scale(0.95) translateY(10px);
}
to {
opacity: 1;
transform: scale(1) translateY(0);
}
}
.overflow-y-auto {
scrollbar-width: thin;
scrollbar-color: var(--border-color) transparent;
}
.overflow-y-auto::-webkit-scrollbar {
width: 8px;
}
.overflow-y-auto::-webkit-scrollbar-track {
background: transparent;
}
.overflow-y-auto::-webkit-scrollbar-thumb {
background-color: var(--border-color);
border-radius: 4px;
}
.overflow-y-auto::-webkit-scrollbar-thumb:hover {
background-color: var(--accent-primary);
}
</style>
+80 -3
View File
@@ -34,7 +34,9 @@
import SnippetLibraryPanel from "$lib/components/SnippetLibraryPanel.svelte";
import QuickActionsPanel from "$lib/components/QuickActionsPanel.svelte";
import ClipboardHistoryPanel from "$lib/components/ClipboardHistoryPanel.svelte";
import DraftPanel from "$lib/components/DraftPanel.svelte";
import TextInputContextMenu from "$lib/components/TextInputContextMenu.svelte";
import { draftsStore } from "$lib/stores/drafts";
import type { Attachment } from "$lib/types/messages";
const INPUT_HISTORY_KEY = "hikari-input-history";
@@ -52,6 +54,7 @@
let showSnippetLibrary = $state(false);
let showQuickActions = $state(false);
let showClipboardHistory = $state(false);
let showDraftPanel = $state(false);
let streamerModeActive = $state(false);
// Cost estimation for pre-submission display
@@ -175,6 +178,14 @@
}
});
function clearInput() {
inputValue = "";
const activeId = get(claudeStore.activeConversationId);
if (activeId) {
claudeStore.setDraftText(activeId, "");
}
}
function handleInputChange() {
// If input is empty, allow history navigation again
// Otherwise, mark that user has manually typed
@@ -212,7 +223,7 @@
async function executeSlashCommand(): Promise<boolean> {
const { command, args } = parseSlashCommand(inputValue);
if (command) {
inputValue = "";
clearInput();
showCommandMenu = false;
matchingCommands = [];
await command.execute(args);
@@ -245,7 +256,7 @@
"error",
`Unknown command: ${message.split(" ")[0]}. Type /help for available commands.`
);
inputValue = "";
clearInput();
return;
}
@@ -261,7 +272,7 @@
userHasTyped = false;
isSubmitting = true;
inputValue = "";
clearInput();
// Capture attachments before clearing
const currentAttachments = [...attachments];
@@ -720,6 +731,22 @@ User: ${formattedMessage}`;
userHasTyped = true;
}
function handleDraftInsert(content: string): void {
inputValue = content;
userHasTyped = true;
const activeId = get(claudeStore.activeConversationId);
if (activeId) {
claudeStore.setDraftText(activeId, content);
}
}
async function handleSaveAsDraft(): Promise<void> {
const content = inputValue.trim();
if (!content) return;
await draftsStore.saveDraft(content);
clearInput();
}
function handleClipboardInsert(content: string): void {
// Insert clipboard content at cursor position or append to input
if (inputValue.trim()) {
@@ -936,6 +963,29 @@ User: ${formattedMessage}`;
<span>Clipboard</span>
</button>
<button
type="button"
onclick={() => (showDraftPanel = true)}
class="control-button"
title="Saved Drafts"
>
<svg
width="16"
height="16"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<path
d="M11 5H6a2 2 0 00-2 2v11a2 2 0 002 2h11a2 2 0 002-2v-5m-1.414-9.414a2 2 0 112.828 2.828L11.828 15H9v-2.828l8.586-8.586z"
/>
</svg>
<span>Drafts</span>
</button>
<CliVersion />
<SystemClock />
</div>
@@ -976,6 +1026,29 @@ User: ${formattedMessage}`;
</div>
{/if}
<button
type="button"
onclick={handleSaveAsDraft}
disabled={!inputValue.trim()}
class="attach-button"
title="Save as Draft"
>
<svg
width="20"
height="20"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M19 21H5a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h11l5 5v11a2 2 0 0 1-2 2z" />
<polyline points="17 21 17 13 7 13 7 21" />
<polyline points="7 3 7 8 15 8" />
</svg>
</button>
<button type="button" onclick={handleFilePicker} class="attach-button" title="Attach files">
<svg
width="20"
@@ -1041,6 +1114,10 @@ User: ${formattedMessage}`;
/>
{/if}
{#if showDraftPanel}
<DraftPanel onClose={() => (showDraftPanel = false)} onInsert={handleDraftInsert} />
{/if}
{#if contextMenuShow && textareaElement}
<TextInputContextMenu
x={contextMenuX}
+203
View File
@@ -0,0 +1,203 @@
import { describe, it, expect, vi, beforeEach } from "vitest";
import { get } from "svelte/store";
import { invoke } from "@tauri-apps/api/core";
import { setMockInvokeResult } from "../../../vitest.setup";
import { draftsStore, type Draft } from "./drafts";
const makeDraft = (id: string, content: string, saved_at: string): Draft => ({
id,
content,
saved_at,
});
describe("Draft interface", () => {
it("defines all required fields", () => {
const draft: Draft = {
id: "draft-123",
content: "Hello world",
saved_at: "2026-01-01T00:00:00+00:00",
};
expect(draft.id).toBe("draft-123");
expect(draft.content).toBe("Hello world");
expect(draft.saved_at).toBe("2026-01-01T00:00:00+00:00");
});
it("supports multiline content", () => {
const draft: Draft = {
id: "multi",
content: "Line 1\nLine 2\nLine 3",
saved_at: "2026-01-01T00:00:00+00:00",
};
expect(draft.content.includes("\n")).toBe(true);
expect(draft.content.split("\n")).toHaveLength(3);
});
});
describe("draftsStore", () => {
beforeEach(() => {
vi.clearAllMocks();
});
describe("store structure", () => {
it("has all expected methods", () => {
expect(typeof draftsStore.loadDrafts).toBe("function");
expect(typeof draftsStore.saveDraft).toBe("function");
expect(typeof draftsStore.deleteDraft).toBe("function");
expect(typeof draftsStore.deleteAllDrafts).toBe("function");
expect(typeof draftsStore.formatTimestamp).toBe("function");
});
it("has subscribable stores", () => {
expect(typeof draftsStore.drafts.subscribe).toBe("function");
expect(typeof draftsStore.isLoading.subscribe).toBe("function");
});
});
describe("loadDrafts", () => {
it("loads drafts from backend", async () => {
const mockDrafts: Draft[] = [
makeDraft("draft-1", "Hello world", "2026-01-01T00:00:00+00:00"),
];
setMockInvokeResult("list_drafts", mockDrafts);
await draftsStore.loadDrafts();
expect(invoke).toHaveBeenCalledWith("list_drafts");
expect(get(draftsStore.drafts)).toEqual(mockDrafts);
});
it("handles load errors gracefully", async () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
setMockInvokeResult("list_drafts", new Error("Failed to load"));
await draftsStore.loadDrafts();
expect(consoleSpy).toHaveBeenCalledWith("Failed to load drafts:", expect.any(Error));
consoleSpy.mockRestore();
});
it("sets isLoading during load", async () => {
const loadingStates: boolean[] = [];
const unsubscribe = draftsStore.isLoading.subscribe((val) => loadingStates.push(val));
setMockInvokeResult("list_drafts", []);
await draftsStore.loadDrafts();
unsubscribe();
expect(loadingStates).toContain(true);
expect(loadingStates.at(-1)).toBe(false);
});
});
describe("saveDraft", () => {
it("saves draft and reloads list", async () => {
const mockDraft = makeDraft("new-id", "My draft content", "2026-01-01T00:00:00+00:00");
setMockInvokeResult("save_draft", mockDraft);
setMockInvokeResult("list_drafts", [mockDraft]);
const result = await draftsStore.saveDraft("My draft content");
expect(result).toEqual(mockDraft);
expect(invoke).toHaveBeenCalledWith("save_draft", { content: "My draft content" });
});
it("returns null on error", async () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
setMockInvokeResult("save_draft", new Error("Save failed"));
const result = await draftsStore.saveDraft("content");
expect(result).toBeNull();
expect(consoleSpy).toHaveBeenCalledWith("Failed to save draft:", expect.any(Error));
consoleSpy.mockRestore();
});
});
describe("deleteDraft", () => {
it("deletes draft by ID and reloads", async () => {
setMockInvokeResult("delete_draft", undefined);
setMockInvokeResult("list_drafts", []);
const result = await draftsStore.deleteDraft("draft-123");
expect(result).toBe(true);
expect(invoke).toHaveBeenCalledWith("delete_draft", { draftId: "draft-123" });
});
it("handles delete errors gracefully", async () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
setMockInvokeResult("delete_draft", new Error("Delete failed"));
const result = await draftsStore.deleteDraft("draft-123");
expect(result).toBe(false);
expect(consoleSpy).toHaveBeenCalledWith("Failed to delete draft:", expect.any(Error));
consoleSpy.mockRestore();
});
});
describe("deleteAllDrafts", () => {
it("deletes all drafts and clears store", async () => {
// First populate the store
setMockInvokeResult("list_drafts", [makeDraft("d1", "Draft 1", "2026-01-01T00:00:00+00:00")]);
await draftsStore.loadDrafts();
expect(get(draftsStore.drafts)).toHaveLength(1);
setMockInvokeResult("delete_all_drafts", undefined);
const result = await draftsStore.deleteAllDrafts();
expect(result).toBe(true);
expect(invoke).toHaveBeenCalledWith("delete_all_drafts");
expect(get(draftsStore.drafts)).toHaveLength(0);
});
it("handles delete-all errors gracefully", async () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
setMockInvokeResult("delete_all_drafts", new Error("Delete all failed"));
const result = await draftsStore.deleteAllDrafts();
expect(result).toBe(false);
expect(consoleSpy).toHaveBeenCalledWith("Failed to delete all drafts:", expect.any(Error));
consoleSpy.mockRestore();
});
});
describe("formatTimestamp", () => {
it("formats a valid ISO timestamp", () => {
const result = draftsStore.formatTimestamp("2026-01-15T14:30:00+00:00");
// Should produce a human-readable string (locale-dependent)
expect(typeof result).toBe("string");
expect(result.length).toBeGreaterThan(0);
});
it("falls back to raw string on invalid timestamp", () => {
const invalid = "not-a-date";
const result = draftsStore.formatTimestamp(invalid);
expect(result).toBe(invalid);
});
});
});
describe("draft content handling", () => {
it("supports content with special characters", () => {
const draft = makeDraft(
"special",
"echo \"Hello\" && echo 'World'",
"2026-01-01T00:00:00+00:00"
);
expect(draft.content).toContain('"');
expect(draft.content).toContain("'");
expect(draft.content).toContain("&&");
});
it("supports very long content", () => {
const longContent = "a".repeat(1000);
const draft = makeDraft("long", longContent, "2026-01-01T00:00:00+00:00");
expect(draft.content).toHaveLength(1000);
});
});
+87
View File
@@ -0,0 +1,87 @@
import { writable } from "svelte/store";
import { invoke } from "@tauri-apps/api/core";
export interface Draft {
id: string;
content: string;
saved_at: string;
}
function createDraftsStore() {
const drafts = writable<Draft[]>([]);
const isLoading = writable(false);
async function loadDrafts(): Promise<void> {
isLoading.set(true);
try {
const list = await invoke<Draft[]>("list_drafts");
drafts.set(list);
} catch (error) {
console.error("Failed to load drafts:", error);
} finally {
isLoading.set(false);
}
}
async function saveDraft(content: string): Promise<Draft | null> {
try {
const draft = await invoke<Draft>("save_draft", { content });
await loadDrafts();
return draft;
} catch (error) {
console.error("Failed to save draft:", error);
return null;
}
}
async function deleteDraft(draftId: string): Promise<boolean> {
try {
await invoke("delete_draft", { draftId });
await loadDrafts();
return true;
} catch (error) {
console.error("Failed to delete draft:", error);
return false;
}
}
async function deleteAllDrafts(): Promise<boolean> {
try {
await invoke("delete_all_drafts");
drafts.set([]);
return true;
} catch (error) {
console.error("Failed to delete all drafts:", error);
return false;
}
}
function formatTimestamp(isoString: string): string {
const date = new Date(isoString);
if (isNaN(date.getTime())) {
return isoString;
}
try {
return date.toLocaleString(undefined, {
month: "short",
day: "numeric",
hour: "numeric",
minute: "2-digit",
});
} catch {
return isoString;
}
}
return {
drafts: { subscribe: drafts.subscribe },
isLoading: { subscribe: isLoading.subscribe },
loadDrafts,
saveDraft,
deleteDraft,
deleteAllDrafts,
formatTimestamp,
};
}
export const draftsStore = createDraftsStore();
+5 -1
View File
@@ -282,7 +282,11 @@ export async function initializeTauriListeners() {
const previousState = conv.characterState;
// New response starting — clear all per-task sound flags.
if (mappedState === "thinking") {
// Only reset when entering from a clean-slate state, not mid-task.
// Transitioning from coding/searching/mcp/typing → thinking means we're
// still within the same task (between tool calls), so the sound must not replay.
const cleanSlateStates: CharacterState[] = ["idle", "success", "error"];
if (mappedState === "thinking" && cleanSlateStates.includes(previousState)) {
claudeStore.resetSoundState(resolvedConversationId);
}