nhcarrigan/amari
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 2 Pull Requests 6 Actions Releases 1 Activity

feat: mentorship improvements and name mention notifications #14

Merged
naomi merged 5 commits from feat/highlights into main 2026-03-02 16:03:14 -08:00
Conversation 0 Commits 5 Files Changed 9
+265 -33
hikari commented 2026-03-02 15:12:59 -08:00
Owner
Copy Link
Copy Source

Summary

  • Name/title mention notifications: Amari now notifies Naomi when a message contains her name, common nicknames (nomi, nao, nae, naonao), or honorifics (goddess, queen, mistress, your/her majesty, your/her highness). Uses the same cooldown logic as mention forwarding.
  • Simplified mentee onboarding: Replaced the lengthy welcome message with a concise prompt asking the new mentee to ping Naomi with their GitHub username and name.
  • Removed offboard notification: logMenteeLeave now only logs a metric silently — no more "user must be offboarded" messages in the channel.
  • Deduplicated welcome messages: Welcomed mentee IDs are persisted to data/welcomed.txt so the onboarding message is only ever sent once, even if the role is re-assigned.

Test plan

  • Assign mentorship role to a user and confirm the new onboarding message appears
  • Re-assign the role to the same user and confirm no duplicate message is sent
  • Remove a mentee from the server and confirm no offboard message is posted
  • Send a message containing a matched name/honorific and confirm Naomi receives a DM forwarding it

✨ This PR was created with help from Hikari~ 🌸

## Summary - **Name/title mention notifications**: Amari now notifies Naomi when a message contains her name, common nicknames (`nomi`, `nao`, `nae`, `naonao`), or honorifics (`goddess`, `queen`, `mistress`, `your/her majesty`, `your/her highness`). Uses the same cooldown logic as mention forwarding. - **Simplified mentee onboarding**: Replaced the lengthy welcome message with a concise prompt asking the new mentee to ping Naomi with their GitHub username and name. - **Removed offboard notification**: `logMenteeLeave` now only logs a metric silently — no more "user must be offboarded" messages in the channel. - **Deduplicated welcome messages**: Welcomed mentee IDs are persisted to `data/welcomed.txt` so the onboarding message is only ever sent once, even if the role is re-assigned. ## Test plan - [ ] Assign mentorship role to a user and confirm the new onboarding message appears - [ ] Re-assign the role to the same user and confirm no duplicate message is sent - [ ] Remove a mentee from the server and confirm no offboard message is posted - [ ] Send a message containing a matched name/honorific and confirm Naomi receives a DM forwarding it ✨ This PR was created with help from Hikari~ 🌸
hikari added 2 commits 2026-03-02 15:12:59 -08:00
chore(docs): add claude.md f2f6775ab1
feat: notify naomi of name and title mentions
Node.js CI / CI (pull_request) Successful in 28s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 56s
Details
8ee5fa7ced
naomi added 1 commit 2026-03-02 15:37:07 -08:00
fix: remove mentee offboard notification on leave
Node.js CI / CI (pull_request) Successful in 28s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 51s
Details
a448d22e18
naomi added 1 commit 2026-03-02 15:43:40 -08:00
fix: simplify mentee onboarding message
Node.js CI / CI (pull_request) Successful in 27s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 56s
Details
5efac612f9
naomi added 1 commit 2026-03-02 15:55:25 -08:00
feat: deduplicate mentee welcome messages
Node.js CI / CI (pull_request) Successful in 29s
Details
Security Scan and Upload / Security & DefectDojo Upload (pull_request) Successful in 1m1s
Details
b1196158a5 
Track welcomed mentees in data/welcomed.txt to prevent sending the onboarding message multiple times if the mentorship role is re-assigned.
hikari changed title from feat: notify naomi of name and title mentions to feat: mentorship improvements and name mention notifications 2026-03-02 15:58:58 -08:00
naomi merged commit 5e149a29e4 into main 2026-03-02 16:03:14 -08:00
naomi deleted branch feat/highlights 2026-03-02 16:03:14 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aspect
code
Concerns the software code in the repository
aspect
dx
Concerns developers' experience with the codebase
aspect
interface
Concerns end-users' experience with the software
aspect
text
Concerns the documentation material in the repository
contribute
good first issue
A great opportunity for a team member to learn a new codebase
contribute
help wanted
Open for anyone on our team to grab.
contribute
staff only
Restricted to our executive leadership.
goal
addition
Addition of new feature
goal
fix
Bug fix
goal
improvement
Improvement to an existing feature
points
1
Very simple issue requiring minimal effort and complexity.
points
13
Extremely complex issue representing major undertakings. Should be broken down into smaller pieces.
points
2
Simple issue that requires a bit more thought or investigation.
points
3
Moderate complexity issue requiring more substantial work.
points
5
Complex issue requiring significant effort and expertise.
points
8
Very complex issue requiring extensive work and deep expertise.
priority
critical
1
Must be fixed ASAP
priority
high
2
Stalls work on the project or its dependents
priority
low
4
Low priority and doesn't need to be rushed
priority
medium
3
Not blocking but should be fixed soon
priority
none
5
No priority, should only be performed when a developer is available
status
awaiting triage
Has not been triaged & therefore, not ready for work
status
blocked
Blocked and therefore not ready for work
status
discarded
Will not be worked on
status
discontinued
Not suitable for work as repo is in maintenance
status
label work required
Needs proper labelling before it can be worked on
status
ready for dev
Ready for work
status
ticket work required
Needs more details before it can be worked on
talk
discussion
Open for discussions and feedback
talk
question
Can be resolved with an answer
time
1 day
Approximately one full day of development work.
time
1-2 weeks
One to two weeks of focused development effort.
time
2-3 days
Two to three days of development effort.
time
4-5 days
Approximately one week of development work.
time
<1 day
Less than one day of focused work. Quick fixes or simple tasks.
time
>2 weeks
More than two weeks of development work. Must be broken down into smaller pieces.
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
gurkirat hanna (Hanna Rose) hikari (Hikari) minori (Minori) naomi (Naomi Carrigan) rain teklu tim
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nhcarrigan/amari#14
Delete Branch "feat/highlights"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?