nhcarrigan/amari
9
0
Fork 0
generated from nhcarrigan/template
Code Issues 2 Pull Requests 6 Actions Releases 1 Activity

feat: protect github route with secret too
Node.js CI / Lint and Test (push) Successful in 44s
Details

Browse Source
This commit is contained in:
Naomi Carrigan
2025-08-27 19:04:06 -07:00
parent d5c0abe4d8
commit 994f50c174
3 changed files with 30 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
prod.env
+2
View File
@@ -3,3 +3,5 @@ BOT_TOKEN="op://Environment Variables - Naomi/Amari/bot token"
GH_CLIENT_ID="op://Environment Variables - Naomi/Amari/gh client id" GH_CLIENT_ID="op://Environment Variables - Naomi/Amari/gh client id"
GH_CLIENT_SECRET="op://Environment Variables - Naomi/Amari/gh client secret" GH_CLIENT_SECRET="op://Environment Variables - Naomi/Amari/gh client secret"
GH_PRIVATE_KEY="op://Environment Variables - Naomi/Amari/gh private key" GH_PRIVATE_KEY="op://Environment Variables - Naomi/Amari/gh private key"
GH_WEBHOOK_SECRET="op://Environment Variables - Naomi/Amari/gh webhook secret"
BASEROW_SECRET="op://Environment Variables - Naomi/Amari/baserow hook auth"
src/modules/processGitHubEvent.ts
+13 -3
View File
@@ -25,13 +25,23 @@ const isPull = (body: GithubPayload): body is PullRequestCreated => {
* @param request - The Fastify request payload. * @param request - The Fastify request payload.
* @param response - The Fastify reply class. * @param response - The Fastify reply class.
*/ */
// eslint-disable-next-line max-statements -- STFU. // eslint-disable-next-line max-statements, max-lines-per-function -- STFU.
export const processGithubEvent = async( export const processGithubEvent = async(
amari: Amari, amari: Amari,
// eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard. request: FastifyRequest<{
request: FastifyRequest<{ Body: GithubPayload }>, // eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard.
Body: GithubPayload;
// eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard.
Querystring: { secret: string };
}>,
response: FastifyReply, response: FastifyReply,
): Promise<void> => { ): Promise<void> => {
const { secret } = request.query;
if (secret !== process.env.GH_WEBHOOK_SECRET) {
await response.status(403).send({
message: "Invalid secret provided!",
});
}
const event = request.headers["x-github-event"]; const event = request.headers["x-github-event"];
if (typeof event !== "string") { if (typeof event !== "string") {
await response.status(400). await response.status(400).
src/server/serve.ts
+14 -10
View File
@@ -57,6 +57,7 @@ const html = `<!DOCTYPE html>
* Starts up a web server for health monitoring. * Starts up a web server for health monitoring.
* @param amari - Amari's instance. * @param amari - Amari's instance.
*/ */
// eslint-disable-next-line max-lines-per-function -- STFU.
export const instantiateServer = (amari: Amari): void => { export const instantiateServer = (amari: Amari): void => {
try { try {
const server = fastify({ const server = fastify({
@@ -68,18 +69,21 @@ export const instantiateServer = (amari: Amari): void => {
response.send(html); response.send(html);
}); });
server. server.post<{
// eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard.
Body: GithubPayload;
// eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard. // eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard.
post<{ Body: GithubPayload }>("/github", async(request, response) => { Querystring: { secret: string };
try { }>("/github", async(request, response) => {
await processGithubEvent(amari, request, response); try {
} catch (error) { await processGithubEvent(amari, request, response);
if (!(error instanceof Error)) { } catch (error) {
return; if (!(error instanceof Error)) {
} return;
await logger.error("/github route", error);
} }
}); await logger.error("/github route", error);
}
});
server. server.
// eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard. // eslint-disable-next-line @typescript-eslint/naming-convention -- Fastify standard.