From 36e095991c65029db3c946e198af0ab0b25898da Mon Sep 17 00:00:00 2001
From: Hikari <hikari@nhcarrigan.com>
Date: Thu, 12 Mar 2026 23:28:22 -0700
Subject: [PATCH] fix: suppress non-critical RetroAchievements fetch errors

Errors from the RA API are silently swallowed since the job retries
every 10 minutes and failures are expected during brief outages.
---
 src/modules/checkAchievements.ts | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/modules/checkAchievements.ts b/src/modules/checkAchievements.ts
index 2a20225..18776a3 100644
--- a/src/modules/checkAchievements.ts
+++ b/src/modules/checkAchievements.ts
@@ -23,7 +23,6 @@ import {
   type MessageActionRowComponentBuilder,
 } from "discord.js";
 import { ids } from "../config/ids.js";
-import { logger } from "../utils/logger.js";
 import type { Amari } from "../interfaces/amari.js";
 
 const username = "naomilgbt";
@@ -117,9 +116,7 @@ export const checkRetroAchievements = async(
         flags:      [ MessageFlags.IsComponentsV2 ],
       });
     }));
-  } catch (error) {
-    if (error instanceof Error) {
-      await logger.error("checkRetroAchievements module", error);
-    }
+  } catch {
+    // Fetch errors from RetroAchievements are non-critical; the job retries every 10 minutes.
   }
 };